Ecosyste.ms: Timeline

Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.

erights

erights created a review comment on a pull request on endojs/endo
It can throw, and it is fine if that throw interrupts the flow. But we don't rely on that in the sense that if we did suppress the throw and the value were not `undefined` afterwards, we'd still ge...

View on GitHub

erights created a review on a pull request on endojs/endo

View on GitHub

erights pushed 5 commits to markm-2598-set-func-proto-undefined endojs/endo
  • fix(compartment-mapper): Defer all importHook errors when importing a… (#2610) … dependency if they're intended to b... 28999e8
  • fix(compartment-mapper): top-level "this" is "module.exports" (#2620) For CJS compat, the top-level `this` must be e... a923f4e
  • fix(ses): fix #2598 with cauterizeProperty reuse f57790e
  • fixup! doccomment 47e1e5b
  • fixup! review suggestion 7beacaa

View on GitHub

erights created a review comment on a pull request on endojs/endo
Done

View on GitHub

erights created a review on a pull request on endojs/endo

View on GitHub

erights created a review comment on a pull request on endojs/endo
Done

View on GitHub

erights created a review on a pull request on endojs/endo

View on GitHub

erights pushed 1 commit to markm-2598-set-func-proto-undefined endojs/endo

View on GitHub

erights created a review comment on a pull request on endojs/endo
@kriskowal , please advise on how to arrange to pass a proper Reporter here.

View on GitHub

erights created a review on a pull request on endojs/endo

View on GitHub

erights pushed 1 commit to markm-2598-set-func-proto-undefined endojs/endo

View on GitHub

erights opened a draft pull request on endojs/endo
fix(ses): fix #2598 with cauterizeProperty reuse
<!-- < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < ☺ v ✰ Thanks for creating a PR! ✰ ☺ > > > > > > > > > > > > > > > > > > > > > > > > > > > > >...
erights created a branch on endojs/endo

markm-2598-set-func-proto-undefined - Endo is a distributed secure JavaScript sandbox, based on SES

erights created a review comment on a pull request on endojs/endo
Might it even make sense to break this file up into a `ses/src-xs/lockdown-shim.js` and `ses/src-xs/compartment-shim.js`, and then change `ses/src-xs/index.js` to be that much more similar?

View on GitHub

erights created a review comment on a pull request on endojs/endo
I notice that this PR does not modify `lockdown.js` which defines the `repairIntrinsics` being called here. Nor does it modify `tame-harden.js` or `make-hardener.js` used by `repairIntrinsics` to m...

View on GitHub

erights created a review comment on a pull request on endojs/endo
Minor: This file is intended to be an xs-flavored alternative to ses/index.js. Two minor changes would help a reader see and understand the parallelism: - Move ses/index.js to ses/src/index.js,...

View on GitHub

erights created a review on a pull request on endojs/endo

View on GitHub

erights created a review comment on a pull request on endojs/endo
I don't understand > loading modules from original sources (which is not possible at runtime on XS) What about this is not possible on XS?

View on GitHub

erights created a review comment on a pull request on endojs/endo
Keep the errors connected re causal console log output ```suggestion Fail`Cannot bundle: encountered deferredError ${deferredError}`, ``` Also, consider for other asserts. Unless we...

View on GitHub

erights created a review comment on a pull request on endojs/endo
If you truly want to add/change an entry in an older NEWS section, could you add something to the "Next release" section to make clear what is new?

View on GitHub

erights created a review comment on a pull request on endojs/endo
Did you mean to include this under "v1.3.0" rather than "Next version"?

View on GitHub

erights created a review on a pull request on endojs/endo
Review so far

View on GitHub

erights created a review on a pull request on endojs/endo
Review so far

View on GitHub

erights created a review on a pull request on endojs/endo
LGTM

View on GitHub

erights created a comment on a pull request on endojs/endo
See also https://github.com/Agoric/agoric-sdk/issues/10375

View on GitHub

erights created a comment on an issue on Agoric/agoric-sdk
See also https://github.com/endojs/endo/pull/2223 Note that the JS standard now has 4 cause-ish Error properties: - `cause` for all errors except `SuppressedError`! (Is this an oversight or b...

View on GitHub

erights created a review on a pull request on endojs/endo
> Would not mind a nod from @erights Nod!

View on GitHub

erights opened a pull request on tc39/agendas
Missing backquote
Just a drive-by noticed while doing something else
erights created a branch on tc39/agendas

erights-patch-2 - TC39 meeting agendas

erights opened a pull request on tc39/agendas
2 proposals + schedule constraints
Immutable ArrayBuffers for stage 2 Stabilize for stage 1 with links coming Schedule constraints: I will likely miss Monday
Load more