Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
erights created a review comment on a pull request on Agoric/agoric-sdk
This still doesn't seem quite right. Your code does indeed do per instance, which is indeed what I suggested. But don't we need per instance per incarnation? AFAICT, this only gets set by the `init...
erights created a review comment on a pull request on Agoric/agoric-sdk
Given your method naming convention `foo` vs `unfilteredFoo`, should these state variables be renamed to ```suggestion index: 0, unfilteredIndex: 0, ``` ?
erights created a review comment on a pull request on endojs/endo
Separately, it looks like a bug that > the test in intrinsics.js is inconsistently stricter than the https://github.com/endojs/endo/pull/1221 test in permit-intrinsics.js and runs first Could...
erights created a review on a pull request on endojs/endo
LGTM module suggestions, especially https://github.com/endojs/endo/pull/2563#discussion_r1807040061
erights created a review comment on a pull request on endojs/endo
Is it because the test in intrinsics.js is inconsistently stricter than the #1221 test in permit-intrinsics.js and runs first? I also looked at the definition of these three functions to see wha...
erights created a review comment on a pull request on endojs/endo
I'm confused. Why doesn't https://github.com/endojs/endo/pull/1221 make this a non-issue, setting the `.prototype` to `undefined` itself?
erights created a review comment on a pull request on endojs/endo
Please explain the Hermes bug you're bypassing below, in addition to the commit link.
erights created a review comment on a pull request on endojs/endo
Likewise. Is there an issue for this Hermes bug?
erights created a review comment on a pull request on endojs/endo
Just checking: We do not have any such problem with async functions or generator functions? Only with async generator functions?
erights created a review comment on a pull request on endojs/endo
Is it possible for `%AsyncGeneratorPrototype%` to be absent while `%AsyncIteratorPrototype%` is present? If so, is there some means to discover `%AsyncIteratorPrototype%` without `%AsyncGeneratorPr...
erights created a review comment on a pull request on endojs/endo
Please add at least a comment or a type that makes clear the conditional nature of this export. Maybe even a rename to imply its conditional nature? Since this export is exported static state th...
erights created a review comment on a pull request on endojs/endo
Indeed, because of this breaking change issue, we haven't even moved forward on https://github.com/endojs/endo/pull/2008
erights created a review comment on a pull request on endojs/endo
Agreed. That's another reason we cannot get away with it.
erights created a review comment on a pull request on Agoric/agoric-sdk
What is gained from the extra indirection here of first forming the list of alternatives and then feeding them to an `M.or`? Do you expect to make some other use of `LogEntryAlternatives`?
erights created a review comment on a pull request on Agoric/agoric-sdk
Why is it that this one needs the name indirection but the other ops do not? In general my reaction is that I understand why such indirection adds value to C programs, but not to JS programs. Espec...
erights created a review comment on a pull request on Agoric/agoric-sdk
These lines are surprisingly asymmetric. How about just ```suggestion startGeneration, doFulfill, doReject, // doCall, // unimplemented in the current plan ``` ? Alterna...
erights created a review comment on a pull request on endojs/endo
Yes. For strings, normal lexicographic ordering is overwhelmingly more expected than shortlex. For binaries of different length, I don't think there is any one overwhelming expectation. FWIW, if...
erights created a review on a pull request on Agoric/agoric-sdk
> This likely should move into Endo itself Yes. I would prefer that you do it this way from the outset. If you then want to make it available to agoric-sdk before the next round of endo sync, ...