Ecosyste.ms: Timeline

Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.

eediallo

eediallo created a comment on a pull request on CodeYourFuture/Module-Data-Groups
> Great work. Keep it up. @CE-0 thank you!

View on GitHub

eediallo created a review comment on a pull request on CodeYourFuture/Module-Data-Groups
could not see it. please help

View on GitHub

eediallo created a review on a pull request on CodeYourFuture/Module-Data-Groups

View on GitHub

eediallo pushed 1 commit to sprint-1-exercices eediallo/Module-Data-Groups

View on GitHub

eediallo created a review comment on a pull request on CodeYourFuture/Module-Data-Groups
It's not! because the elements of the unique array can still be changed if unique is declared with const.

View on GitHub

eediallo created a review on a pull request on CodeYourFuture/Module-Data-Groups

View on GitHub

eediallo pushed 1 commit to sprint-1-exercices eediallo/Module-Data-Groups

View on GitHub

eediallo created a review comment on a pull request on CodeYourFuture/Module-Data-Groups
I can remove the item variable and just compare element with target.

View on GitHub

eediallo created a review on a pull request on CodeYourFuture/Module-Data-Groups

View on GitHub

eediallo created a review comment on a pull request on CodeYourFuture/Module-Data-Groups
I wanted to get two decimal places to make the result of the calculation correct but because this ```num.toFixed(2)``` is a string that's why I am converting it back to a float. I do not know wheth...

View on GitHub

eediallo created a review comment on a pull request on CodeYourFuture/Module-Data-Groups
Oh, yeah. The function checks if n is a number and odd. What do you think about renaming it to **isNumberAndFloat**?

View on GitHub

eediallo created a review on a pull request on CodeYourFuture/Module-Data-Groups

View on GitHub

eediallo created a review comment on a pull request on CodeYourFuture/Module-Data-Groups
because max changes. It is not a constant value

View on GitHub

eediallo created a review comment on a pull request on CodeYourFuture/Module-Data-Groups
an empty array will be returned.

View on GitHub

eediallo created a review on a pull request on CodeYourFuture/Module-Data-Groups

View on GitHub

eediallo pushed 1 commit to todo-list eediallo/Module-Data-Groups

View on GitHub

eediallo created a review comment on a pull request on CodeYourFuture/Module-Data-Groups
It will sort the elements of the list array as strings in ascending order which would not be helpful in our case.

View on GitHub

eediallo created a review on a pull request on CodeYourFuture/Module-Data-Groups

View on GitHub

eediallo pushed 1 commit to todo-list eediallo/Module-Data-Groups
  • resets the input field to be blank eb33931

View on GitHub

eediallo pushed 1 commit to todo-list eediallo/Module-Data-Groups

View on GitHub

eediallo pushed 1 commit to todo-list eediallo/Module-Data-Groups
  • call addNewTodo function onSubmit e7bfb2f

View on GitHub

eediallo pushed 1 commit to todo-list eediallo/Module-Data-Groups

View on GitHub

eediallo pushed 1 commit to todo-list eediallo/Module-Data-Groups
  • removes list html content 1df7d9d

View on GitHub

eediallo pushed 1 commit to todo-list eediallo/Module-Data-Groups

View on GitHub

eediallo pushed 1 commit to todo-list eediallo/Module-Data-Groups

View on GitHub

eediallo pushed 1 commit to todo-list eediallo/Module-Data-Groups

View on GitHub

eediallo pushed 1 commit to todo-list eediallo/Module-Data-Groups
  • adds tickIcon and bin icon 3958050

View on GitHub

eediallo pushed 1 commit to todo-list eediallo/Module-Data-Groups

View on GitHub

eediallo pushed 1 commit to todo-list eediallo/Module-Data-Groups
  • displays initial todo list 4a4d05a

View on GitHub

eediallo pushed 1 commit to todo-list eediallo/Module-Data-Groups

View on GitHub

Load more