Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
dckc created a review comment on a pull request on Agoric/agoric-sdk
oic... this is saying "if the CLI arg doesn't have chainPolicies, fill it in from MAINNET" maybe that's good enough
dckc created a review comment on a pull request on Agoric/agoric-sdk
to get this to show up next to `blockWindowSize`, maybe... ```suggestion blockWindowMaxAmount: 20000000000n, ```
dckc pushed 7 commits to dc-fu-wd-fees Agoric/agoric-sdk
- feat(fast-usdc): creatorFacet method to withdraw fees - test: 1 positive, 1 negative - liquidity pool: feeRecipien... f8e55d0
- chore: regen binary snapshot d55afaa
- refactor(fast-usdc): publishDisplayInfo is not specific to fast-usdc 084a59b
- core(fast-usdc): fix FastUSDCKit['creatorFacet'] type 411c792
- feat(fast-usdc): core eval script to distribute fees 6202f15
- chore(boot): snapshot non-trivial FastUSDC metrics move metrics test after advance 6ea0458
- test(boot): distribute FastUSDC contract fees cc2cf0e
dckc created a review comment on a pull request on Agoric/dapp-offer-up
by "concise method syntax" we mean what MDN calls [Method definitions](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Method_definitions): ```suggestion makeTra...
dckc created a review comment on a pull request on Agoric/dapp-offer-up
any particular reason to drop this bit of documentation?
dckc created a comment on an issue on Agoric/dapp-offer-up
@amessbee nice work on #27! The logs of the first part of `start:contract` are so much nicer... ``` Run yarn start:contract Waiting for blockchain to start... ...................................
dckc created a review comment on a pull request on Agoric/dapp-offer-up
oops... I should have checked this part; it doesn't seem to work for me. If I do `yarn start:contract` before `yarn start:docker`, I get: ``` $ yarn start:contract Waiting for blockchain to st...
dckc created a comment on a pull request on Agoric/dapp-offer-up
yay! much nicer DX! ``` Run yarn start:contract Waiting for blockchain to start... .............................................................................................. agd-1 | 202...
dckc pushed 1 commit to gibson-u18-inq Agoric/agoric-sdk
- test: terminate contract given boardID not via contract governor e492a14
dckc pushed 1 commit to gibson-u18-inq Agoric/agoric-sdk
- test: find contract via governor; kill them both - contractGovernorExecutor: define ContractGovernorKit kind - upg... 4606c14
dckc pushed 7 commits to dc-fu-wd-fees Agoric/agoric-sdk
- feat(fast-usdc): creatorFacet method to withdraw fees - test: 1 positive, 1 negative - liquidity pool: feeRecipien... 25fe741
- test(fast-usdc): regen snapshots w/feeRecipient facets e89db5e
- refactor(fast-usdc): publishDisplayInfo is not specific to fast-usdc 4f8357c
- core(fast-usdc): fix FastUSDCKit['creatorFacet'] type cf4530a
- feat(fast-usdc): core eval script to distribute fees b6d1f69
- chore: move fast-usdc metrics test after advance to show non-trivial metrics 850bf07
- WIP: bootstrap test of withdrawing fees f2b2384
dckc created a review comment on a pull request on Agoric/agoric-sdk
again, I don't think the marshaller needs to be passed in
dckc created a review comment on a pull request on Agoric/agoric-sdk
can `policy` have remotables in it? if not, you can use a data-only marshaller that's local to this function.
dckc created a review comment on a pull request on Agoric/agoric-sdk
The board marshaller looks like overkill.
dckc created a review comment on a pull request on Agoric/agoric-sdk
this should use LegibleCapData then, I think
dckc created a review comment on a pull request on Agoric/agoric-sdk
oh. this is why I couldn't find any way that `chainInfo` could vary. ambient access to `process.env`. ```suggestion { env, config = `../${env.FILE || 'config.yaml'}`, } ``` o...
dckc created a review comment on a pull request on Agoric/agoric-sdk
the function for documenting vstorage supports rendering this nicely. There's a show function or something.
dckc created a review comment on a pull request on Agoric/agoric-sdk
should the name change? it doesn't make a FeedPolicy any more
dckc created a review comment on a pull request on Agoric/agoric-sdk
how could this happen? I don't see any way that `chainInfo` could vary.
dckc created a review comment on a pull request on Agoric/agoric-sdk
seems like there should be a try/finally to prevent `temp` from getting stuck in the test keyring
dckc created a review comment on a pull request on Agoric/agoric-sdk
This seems like sort of the opposite of a mock. ```suggestion const runT = { ```
dckc created a review comment on a pull request on Agoric/agoric-sdk
would this suffice? ```suggestion } as Pick<ExecutionContext, 'log' | 'is'>; ```
dckc created a review comment on a pull request on Agoric/agoric-sdk
```suggestion const job = parseCommandLine(); if (!job) return; const { command, mnemonic, oracles, provisionOracles } = job; ```
dckc created a review comment on a pull request on Agoric/agoric-sdk
I'd rather we don't hide use of this very powerful `process.exit` authority under the name `parseCommandLine()`. Return `undefined` or throw or something instead, please?
dckc created a review comment on a pull request on Agoric/agoric-sdk
please move this Usage string constant to the top of the file. I was going to ask for a file comment, but this is in some ways better. The file name gave very little clue about what it's for ...