Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
dckc created a branch on Agoric/agoric-sdk
dc-fastlp-vbank - monorepo for the Agoric Javascript smart contract platform
dckc created a review comment on a pull request on Agoric/agoric-sdk
in case it makes you feel any better, the approach goes back to the vaults release. https://github.com/Agoric/agoric-sdk/blob/ba3b776444425bbcb275ce918794d9259f8e15da/packages/inter-protocol/src...
dckc created a review comment on a pull request on Agoric/agoric-sdk
hm. yeah... `kubectl cp` seems like what we're doing... a comment about "file changed as we read it" might be nice.
dckc created a review on a pull request on Agoric/agoric-sdk
looks good, presuming the file shows up in the ci artifacts
dckc created a review on a pull request on Agoric/agoric-sdk
looks good, presuming the file shows up in the ci artifacts
dckc created a review comment on a pull request on Agoric/agoric-sdk
I suggest that result of `makeOperator` in the test file should not include an `.admin` property; the returned value should represent what an operator can do, and operators don't have `admin` autho...
dckc created a review on a pull request on Agoric/agoric-sdk
my earlier comments were considered to my satisfaction
dckc created a review comment on a pull request on Agoric/agoric-sdk
I'm used to seeing... ```suggestion const charterIDs = [...retiredContractInstances.keys()].filter(k => ```
dckc created a review comment on a pull request on Agoric/agoric-sdk
log it/them? I'd feel better seeing positive evidence in a ci log.
dckc created a review comment on a pull request on Agoric/agoric-sdk
are we relying on this identifier syntax somewhere? It seems like there should be helper functions to construct and parse it. perhaps near `provideRetiredInstances`?
dckc created a review comment on a pull request on Agoric/agoric-sdk
I wonder if/when `retiredContractInstances` should be added in [vats/src /core/types-ambient.d.ts](https://github.com/Agoric/agoric-sdk/blob/master/packages/vats/src/core/types-ambient.d.ts)
dckc created a review comment on a pull request on Agoric/agoric-sdk
Spurious `await`? ```suggestion const terms = harden({ ```
dckc created a review comment on a pull request on Agoric/agoric-sdk
This reads as if any label in `econCharterKit` overrides the one on line 335. ```suggestion const previousCharterKit = { ...econCharterKit, label }; ```
dckc created a review comment on a pull request on Agoric/agoric-sdk
maybe this means `makeOperator` can lose the awkward `admin` thing altogether?
dckc created a review comment on a pull request on Agoric/agoric-sdk
Whether a store is durable is supposed to be a function of what sort of zone, I think. I think `durable: true` is a noop for a durable zone and ignored by a heap zone. ```suggestion const...
dckc created a review comment on a pull request on Agoric/agoric-sdk
this makes it look like the customer decides when things are risky. I would expect that to be in `makeOracleOperator`.
dckc created a review comment on a pull request on Agoric/agoric-sdk
We'll want to test this in a3p and perhaps emerynet and other instagoric networks. I don't think there's any reason to expect the board id to be the same. I suggest threading it thru as a parameter...
dckc created a review comment on a pull request on Agoric/agoric-sdk
re testing... you can add ava tests in [p:upgrade-19](https://github.com/Agoric/agoric-sdk/tree/master/a3p-integration/proposals/p%3Aupgrade-19). They can access the kernel db; for example [registr...
dckc created a review comment on a pull request on Agoric/agoric-sdk
The PR description shows how board052184 was derived from v110 using, presumably, a mainnet database. Why v110? I don't see any mention of it in #9483.
dckc created a review comment on a pull request on Agoric/agoric-sdk
re "No excess authority is requested" -- `governedContractKits` is access to the admin facets of many governed contracts other than the one we're working with here, so strictly speaking, that's exc...
dckc created a review on a pull request on Agoric/agoric-sdk
To support testing in environments other than mainnet, I suggest threading the boardID thru as a parameter. And I have some suggestions on adding an a3p-integration test.
dckc created a review on a pull request on Agoric/agoric-sdk
To support testing in environments other than mainnet, I suggest threading the boardID thru as a parameter. And I have some suggestions on adding an a3p-integration test.