Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
dckc created a review comment on a pull request on Agoric/agoric-sdk
I suppose the preconditions for `forwarded(...)` are in a state transition diagram somewhere, but it would be nice to have them here locally. In particular, this would throw if you call it twice...
dckc created a review comment on a pull request on Agoric/agoric-sdk
what does "not necessarily an exact match" mean? isn't "same forwarding account and amount" the relevant definition of "matching"?
dckc created a review comment on a pull request on Agoric/agoric-sdk
we should use the log/tracer, shouldn't we?
dckc created a review comment on a pull request on Agoric/agoric-sdk
this tracer shouldn't call itself `'Advancer'`. out of scope of this PR, but since you're in the neighborhood...
dckc created a review comment on a pull request on Agoric/agoric-sdk
the "undefined in case..." docstring looks outdated
dckc created a review comment on a pull request on Agoric/agoric-sdk
#10510 is closed. should this TODO still be here?
dckc created a review on a pull request on Agoric/agoric-sdk
here are some comments based on one read / skim
dckc created a review on a pull request on Agoric/agoric-sdk
here are some comments based on one read / skim
dckc created a comment on an issue on Agoric/agoric-sdk
## 15 blocks - 1:30 to 2:40 From evidence to advanced seems to take 15 blocks. At 7 sec, that's 1:30. But [one explorer](https://agoric.explorers.guru/) shows 12.37 sec avg block time. At that r...
dckc created a comment on an issue on Agoric/agoric-sdk
## 13 sec to advance Looking at ci logs from Dec 12, 14, and 16, we're pretty consistent at 13 sec from 1st OCW evidence to completion of advancement IBC transfer. Details: [fast-usdc-perf.m...
dckc pushed 24 commits to dc-fastlp-vbank Agoric/agoric-sdk
- feat: storage-test-utils report missing data 02c111b
- test: DRY setup of status-manager test 12627ee
- test: quieter advancer test 8c5bf85
- refactor: inline publishStatus 28cc2f6
- refactor: full marshaller e3f49be
- feat: record fee split in transaction 8846972
- record transaction fees (#10715) closes: #10578 ## Description Adds the fee `split` to the Disbursed status of Tra... 9418efc
- chore: constrain fast-usdc config for Mainnet caf6d7a
- test: disabled operators 621e22f
- refactor: TransactionFeed attest 0b57a65
- refactor: sync submitEvidence 1e52a41
- refactor: attest by operatorId fb4ff30
- feat: operator majority logic bc28201
- feat: error on conflicting evidence cd2a40c
- Operator attestation policy (#10721) TODO in code ## Description Update `TransactionFeed` to publish when a majorit... 9e5f628
- feat(fast-usdc): detect transfer completion in cli 2828444
- feat(fast-usdc): detect transfer completion in cli (#10717) fixes https://github.com/Agoric/agoric-sdk/issues/10339 ... 6fbd20a
- test: turn on test of priceAuthority registry 702e494
- Turn on test of priceAuthority registry (#10731) closes: #10727 ## Description Add the existing test `registry-tes... 274240a
- feat(fast-usdc): add FastLP/ufastlp to vbank ae1963e
- and 4 more ...
dckc created a review comment on a pull request on Agoric/agoric-sdk
is there some reason not to do `yarn ava *.test.js`? or `yarn ava`?
dckc created a review on a pull request on Agoric/agoric-sdk
presuming I'm reading the issue correctly, this looks fine.
dckc created a review on a pull request on Agoric/agoric-sdk
presuming I'm reading the issue correctly, this looks fine.
dckc created a comment on a pull request on Agoric/agoric-sdk
I need to think more carefully about correctness / collisions too.
dckc created a review comment on a pull request on Agoric/agoric-sdk
yeah; that's goofy. I fixed it so `lpId` is definitely a string instead of making the other side maybe null.
dckc pushed 1 commit to dc-fastlp-vbank Agoric/agoric-sdk
- fixup! test(boot): FastLP balance not in wallet record a5dff2f
dckc created a review comment on a pull request on Agoric/agoric-sdk
This should be "raising a non-error" per [house style on Errors and Control Flow](https://github.com/Agoric/agoric-sdk/wiki/Errors-and-Control-Flow)
dckc created a review comment on a pull request on Agoric/agoric-sdk
yeah; there's no rest endpoint in the bootstrap world
dckc pushed 3 commits to dc-fastlp-vbank Agoric/agoric-sdk
dckc created a review comment on a pull request on Agoric/agoric-sdk
yes. A ZCFMint is the normal Zoe API for a token issued by a contract.
dckc created a review comment on a pull request on Agoric/agoric-sdk
good idea... I think I can do that...