Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
dckc created a review comment on a pull request on Agoric/agoric-sdk
copy/paste left-over. if I change anything else, I'll remove the parameter. not worth another round of ci on its own, I suggest
dckc created a review comment on a pull request on Agoric/agoric-sdk
Thanks for #10713; I looked it over and made some comments. The cycle time in multi-chain testing is extremely high, so I'm not eager to go beyond this 1 test file for this feature. In genera...
dckc created a review comment on a pull request on Agoric/agoric-sdk
Have you considered the [seatLike](https://github.com/Agoric/agoric-sdk/blob/master/multichain-testing/tools/e2e-tools.js#L595) `.getOfferResult()` API?
dckc created a review comment on a pull request on Agoric/agoric-sdk
if there's no status, `status.id` will throw, right? ```suggestion (u) => u?.status.id === offerId && (u?.status.result || u?.status.error), ```
dckc created a review comment on a pull request on Agoric/agoric-sdk
This coupling still seems odd to me. To my mind, fast-usdc is in the agoric-sdk for logistical reasons; any 3rd party developer should be able to make a similar app. Do we expect 3rd-party devel...
dckc created a review comment on a pull request on Agoric/agoric-sdk
here we are with another copy of the `getOfferResult()` logic.
dckc created a review comment on a pull request on Agoric/agoric-sdk
in what way is this a kit? it looks like 1 object with methods, not a kit of facets.
dckc created a review on a pull request on Agoric/agoric-sdk
It's good to capture more of the common idioms. Some parts of this appeal to me more than others...
dckc created a review on a pull request on Agoric/agoric-sdk
It's good to capture more of the common idioms. Some parts of this appeal to me more than others...
dckc pushed 1 commit to dc-fastlp-vbank Agoric/agoric-sdk
- fixup! test: get FastLP/ufastlp balance from x/bank query 5d8d308
dckc opened an issue on Agoric/agoric-sdk
how to limit excess authority when registering a vbank asset
## What is the Problem Being Solved? #10709 uses the usual `E(bankManager).addAsset(...)` idiom to register FastLP. But `bankManager` has much more authority than this: it can create a vbank pur...
dckc created a review comment on a pull request on Agoric/agoric-sdk
I haven't thought carefully about whether this is sufficient test coverage.
dckc created a review comment on a pull request on Agoric/agoric-sdk
why ask for updates since 0 again? isn't the n+1th call supposed to pass in the updateCount from the nth call?
dckc created a review comment on a pull request on Agoric/agoric-sdk
is this a red-alert situation? It seems like we recover: we don't act on inconsistent evidence.
dckc created a review comment on a pull request on Agoric/agoric-sdk
if we have to use this in anger, I expect we'll want to see which operator submitted which evidence. is that already traced?
dckc created a review comment on a pull request on Agoric/agoric-sdk
the change from `pending.values()` to `found`... I had to think a bit to convince myself that make no difference.
dckc created a review comment on a pull request on Agoric/agoric-sdk
this seems to be the gist of it.
dckc created a review comment on a pull request on Agoric/agoric-sdk
good; the "unknown transaction" test mixed in testing this, and I wondered about reducing coverage.
dckc created a review on a pull request on Agoric/agoric-sdk
looks pretty good this review is a bit rushed, so you may want to get more eyes. or let me know if you want me to look more closely.
dckc created a review on a pull request on Agoric/agoric-sdk
looks pretty good this review is a bit rushed, so you may want to get more eyes. or let me know if you want me to look more closely.
dckc pushed 47 commits to dc-fastlp-vbank Agoric/agoric-sdk
- test: advance and settle as a macro - include `agoric` and `noble` EUD destinations 092056b
- chore: "oracles accept" handles already accepted invs - mainly to facilitate active development; allows test to be r... 1eb9eb1
- test(acceptance): skip make proposal and vote; seems flaky 4ce1540
- test(multichain): fusdc "advance and settle" as a macro (#10692) refs: #10597 ## Description - tests additional FUS... 9e124c3
- chore(vaultFactory): add core-eval for null upgrade vaultFactory 1eb858d
- chore(a3p): add new submissions from governance acceptance tests 662fa2c
- chore(governance):Refactor makeGovernanceDriver methods to be contract agnostic 75c8a12
- fix(a3p): change test execution order rel #10574 c9bd9a4
- test(a3p): extend governance testing coverage 4b660fd
- chore(a3p): refactor makeVStorage to be aligned with batchQuery.js rel: #10574 938d615
- test(a3p): extend governance test with proposals history dccf7bc
- chore(vaultFactory): include insightful comments dc7388c
- fix(a3p): minor fixes to governance test and helpers ecddebd
- fix(vaultFactory): fix proposal description Co-authored-by: Chris Hibbert <[email protected]> bc1f87a
- fix(a3p): remove duplicated await cc4c1a2
- chore: switch using waitForElectionResult, eliminate flakiness refs: https://github.com/Agoric/agoric-sdk/issues/10708 28b4884
- test(a3p): extend governance test coverage for acceptance proposal (#10555) closes: https://github.com/Agoric/BytePi... 9835fb0
- lint: tsc checkJs 293ac50
- chore(deps): link agoric-sdk 3c63de2
- feat: getValues for sequence nodes b5698ce
- and 27 more ...
dckc created a review comment on a pull request on Agoric/documentation
p.s. here's hoping for the day when we don't have to maintain these docs in 2 places - https://github.com/Agoric/agoric-sdk/issues/4291