Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
dckc created a review comment on a pull request on Agoric/agoric-sdk
can we be sure this is the 1st offer in that table?
dckc created a review comment on a pull request on Agoric/agoric-sdk
yikes! This is a good test of the package, isn't it?
dckc created a review comment on a pull request on Agoric/agoric-sdk
hm. is this step in the diagrams in our current spec? IOU a check.
dckc created a review comment on a pull request on Agoric/agoric-sdk
`Math.random` is ambient authority. There's only 1 caller of this function. Please move it to the test script or inline it so that we're not exporting functions that close over ambient authority.
dckc created a review comment on a pull request on Agoric/agoric-sdk
no IST? I would expect Oracle operators need IST. I wonder when / where they get it...
dckc created a review comment on a pull request on Agoric/agoric-sdk
yeah; we should have a helper in `@agoric/fast-usdc/tools/` for building this whole offer spec.
dckc created a review comment on a pull request on Agoric/agoric-sdk
`makeDenomTools` looks pretty interesting. We should keep an eye out for re-invention of similar things and migrate them to the orch package.
dckc created a review comment on a pull request on Agoric/agoric-sdk
I/we should check that product is OK with this constraint.
dckc created a review comment on a pull request on Agoric/agoric-sdk
we want/need this to finish before `setupTestKeys(...)`, right? ```suggestion await deleteTestKeys(accounts).catch(); ``` we don't have lint for dangling promises in multichain-testing?
dckc created a review comment on a pull request on Agoric/agoric-sdk
are those arbitrary values chosen by us? Or is there an external design constraint here? If so, let's please cite it.
dckc created a review comment on a pull request on Agoric/agoric-sdk
`startContract` wants a string for `feedPolicy`? ah... it's just taking `flags()`. Let's `stringify` here.
dckc created a review comment on a pull request on Agoric/agoric-sdk
can the caller `JSON.stringify` it? It would be nice to `@returns { FeedPolicy }`.
dckc created a review on a pull request on Agoric/agoric-sdk
I gotta run. I rushed this review a little, so you may want more eyes. But as you say, only test code, so low risk.
dckc created a review on a pull request on Agoric/agoric-sdk
I gotta run. I rushed this review a little, so you may want more eyes. But as you say, only test code, so low risk.
dckc created a review comment on a pull request on Agoric/agoric-sdk
ah... I misread. I was thinking that the `splitHookedAddressUnsafe` returned the specimen.
dckc created a review comment on a pull request on Agoric/agoric-sdk
This seems to test only that the call does not err. Is that right? I'm curious what happens to `#fragment`.
dckc created a review comment on a pull request on Agoric/agoric-sdk
another place where `BaseAddressLengthBytes` has to be 2.
dckc created a review comment on a pull request on Agoric/agoric-sdk
elsewhere we act like the number of bytes in a base address length is a parameter, and we do loops and stuff. Why not hard-code 2 bytes everywhere?
dckc created a review on a pull request on Agoric/agoric-sdk
dealing with byte slices and such is quite a bit nicer in go than JS, isn't it :) Before I approve, I think I should understand the change in `golang/cosmos/x/vtransfer/keeper/keeper.go`.
dckc created a review on a pull request on Agoric/agoric-sdk
dealing with byte slices and such is quite a bit nicer in go than JS, isn't it :) Before I approve, I think I should understand the change in `golang/cosmos/x/vtransfer/keeper/keeper.go`.
dckc created a review comment on a pull request on Agoric/agoric-sdk
I don't know how to read this change. What does it do?
dckc created a review comment on a pull request on Agoric/agoric-sdk
supply chain audit notes: I don't see any yarn.lock changes re `bech32`, so I'll pass on that without further remark. `query-string@^9.1.1` seems to be new. npm shows 13M weekly downloads. Clear...
dckc created a review comment on a pull request on Agoric/agoric-sdk
Sometimes I wonder whether I should be using ses-ava. For my edification: what motivated you to use it here?
dckc created a review comment on a pull request on Agoric/agoric-sdk
To check default length limits against expected fast-usdc usage, let's please add a test to replace what's currently in the fast usdc test fixture: `agoric16kv2g7snfc4q24vg3pjdlnnqgngtjpwtetd2h689n...
dckc created a review comment on a pull request on Agoric/agoric-sdk
after mulling over what this test establishes, I thought about property testing / fuzzing to be sure the encoding is unambiguous - that no 2 distinct inputs lead to the same encoded address. But...