Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
dckc created a review comment on a pull request on Agoric/agoric-sdk
Why all the `importBundle` gymnastics? I suppose it's to test that `address-hooks.js` works in a compartment. If so, a 1-line comment to that effect seems cost-effective.
dckc created a review comment on a pull request on Agoric/agoric-sdk
I have a vague memory that this `URL(...).pathname` idiom is to be avoided. @kriskowal , does this ring a bell? My habit is to use `createRequire`. In fact, i'm pretty sure I picked that up f...
dckc created a review comment on a pull request on Agoric/agoric-sdk
it still blows me away that the JS stdlib doesn't include array comparison operators.
dckc created a review on a pull request on Agoric/agoric-sdk
I finished reviewing the JS part, which is handy, cuz now I grok the design...
dckc created a review on a pull request on Agoric/agoric-sdk
I finished reviewing the JS part, which is handy, cuz now I grok the design...
dckc created a review comment on a pull request on Agoric/agoric-sdk
For the production UI, the proposal should include `want` too, based on shareWorth like in withdraw. For test use, we may want to be able to specify it manually. I wonder if `--amount` should...
dckc created a review comment on a pull request on Agoric/agoric-sdk
There's a TOCTTOU issuer here: the `shareWorth` could change between the time we read it here and the time our offer gets to the contract. As an enhancement, we could add some sort of acceptable...
dckc created a review comment on a pull request on Agoric/agoric-sdk
let's include the want too. I suggest using `USDCProposalShapes['withdraw']` for a static check. You could even do an early dynamic check (see `makeProposalShapes`).
dckc created a review comment on a pull request on Agoric/agoric-sdk
re-reading [Prepare / Commit](https://github.com/Agoric/agoric-sdk/wiki/Prepare-Commit), the `try` / `catch` is only in order _in case the commit phase is not atomic_.
dckc created a review comment on a pull request on Agoric/agoric-sdk
why a record? why not `return make;`? in case there are other facets later or something? that doesn't seem like your style.
dckc created a review comment on a pull request on Agoric/agoric-sdk
```suggestion const newKey = key.slice('make'.length); ```
dckc created a review comment on a pull request on Agoric/agoric-sdk
I thought about a record like this, but sometimes you have to pass `makeA` into `prepareB`.
dckc pushed 1 commit to dc-define-kinds-sync Agoric/agoric-sdk
- SPIKE: define all kinds in a sync function 8ddd588
dckc created a review comment on a pull request on hindley-milner-systems/dapp-ertp-airdrop
oh... though max length makes sense for `address`, since the app actually knows the lengh. maybe `proof` has an app-specified max length too; I dunno
dckc created a review comment on a pull request on hindley-milner-systems/dapp-ertp-airdrop
They have built-in limits.
dckc created a review comment on a pull request on Agoric/agoric-sdk
let's change that to `100_000_000`.
dckc created a review comment on a pull request on Agoric/agoric-sdk
```suggestion test('fast-usdc withdraw command', async t => { ```
dckc created a review comment on a pull request on Agoric/agoric-sdk
please change this amount likewise so that `--amount 1.00` denotes `AmountMath.make(usdc, 1_000_000n)`.