Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
dckc created a review comment on a pull request on Agoric/agoric-sdk
```suggestion test('fast-usdc deposit command', async t => { ```
dckc created a review on a pull request on Agoric/agoric-sdk
change `withdraw --amount` to work like `deposit --amount`, please
dckc created a review on a pull request on Agoric/agoric-sdk
change `withdraw --amount` to work like `deposit --amount`, please
dckc created a review comment on a pull request on Agoric/agoric-sdk
ah. right; you'd have to test for `'fetch' in opts`. oh well.
dckc created a comment on an issue on Agoric/agoric-sdk
> Also fix up the "description" package.json of fast-usdc was done in #10364
dckc opened a draft pull request on Agoric/agoric-sdk
SPIKE: define all kinds in a sync function
experiment for discussion best reviewed with "hide whitespace changes" cf. https://github.com/Agoric/agoric-sdk/pull/10661/files/90f1a97768443c3b880639bd5bca4e9fbdd691ed#r1877591039 cc @tu...
dckc created a branch on Agoric/agoric-sdk
dc-define-kinds-sync - monorepo for the Agoric Javascript smart contract platform
dckc pushed 4 commits to dc-start-fast-usdc Agoric/agoric-sdk
- chore(a3p-integration): exit on error in fast-usdc a3p test 046779f
- feat(fast-usdc): limited operation before connecting to noble - contract start can't wait for noble account creatio... eb82ae3
- feat(builders): --noNoble option for init-fast-usdc 508a3e0
- chore(a3p-integration): use --noNoble for fast-usdc c9ba09e
dckc created a review comment on a pull request on Agoric/agoric-sdk
oh yeah... adding noble _is_ required. to prevent [that error](#issuecomment-2529788780)
dckc pushed 10 commits to dc-start-fast-usdc Agoric/agoric-sdk
- fix(z:acceptance): fix flakey `z:acceptance/vaults.test.js` closes: #10599 fix: remove TODO comment fix: format fix 82447f3
- fix(z:acceptance): fix flakey `z:acceptance/vaults.test.js` (#10643) closes: #10599 ## Description #10599 pointed ... 74ab972
- chore(vat-upgrade): upgrade agoricNames, test old values are preserved Refs: https://github.com/Agoric/agoric-sdk/is... 56330f4
- chore(vat-upgrade): enhance test coverage of agoricNames functionality after upgrade Refs: #10408 fix: lint fixes ... e35d9d6
- chore(vat-upgrade): simulate what init-chain-info.js is doing https://github.com/Agoric/agoric-sdk/pull/10571/commit... cd35800
- chore(vat-upgrade): upgrade agoricNames, test old values are preserved (#10616) closes: https://github.com/Agoric/ag... 86e3b2d
- chore(a3p-integration): exit on error in fast-usdc a3p test 3d5ba50
- feat(fast-usdc): limited operation before connecting to noble - contract start can't wait for noble account creatio... 6a47d0b
- feat(builders): --noNoble option for init-fast-usdc 8a5c824
- chore(a3p-integration): use --noNoble for fast-usdc 8874419
dckc created a comment on a pull request on Agoric/agoric-sdk
now what?!?!? ``` #32 52.37 2024-12-09T23:14:06.913Z SwingSet: vat: v72: chainHub: registered connections [ 'agoric-3<->cosmoshub-4', 'agoric-3<->noble-1', 'agoric-3<->omniflixhub-1', 'agoric-3...
dckc created a review comment on a pull request on Agoric/agoric-sdk
The interface guard doesn't prevent calling this function with a `borrowSeat` that doesn't have enough USDC. Check `isGTE(borrowSeat.getAmountAllocated('USDC'), amountToRepay)` before calling `a...
dckc created a review comment on a pull request on Agoric/agoric-sdk
given that we're now actually consuming the args and checking them, is logging them still useful?
dckc created a review comment on a pull request on Agoric/agoric-sdk
using the same name (`repay`) with different semantics (sometimes fees, sometimes without) is asking for trouble, IME. maybe... ```suggestion returnToPool: M.call( ``` ```suggest...
dckc created a review comment on a pull request on Agoric/agoric-sdk
check `repayCall[2]` against some literal data? maybe the value of an amount?
dckc created a review comment on a pull request on Agoric/agoric-sdk
Is there any reason to make this a record?
dckc created a review comment on a pull request on Agoric/agoric-sdk
why stringify the error? why not let `log` do that? this will lose stack info, no?
dckc created a review comment on a pull request on Agoric/agoric-sdk
Is how common it is relevant? We're talking user funds here, after all.
dckc created a review on a pull request on Agoric/agoric-sdk
I don't see any correctness problems, but I'm not ready to approve without some discussion.
dckc created a review on a pull request on Agoric/agoric-sdk
I don't see any correctness problems, but I'm not ready to approve without some discussion.
dckc created a review comment on a pull request on Agoric/documentation
I prefer SVG from slides, if that's handy... but this is a substantial improvement. I couldn't figure out how to hide the youtube controls in a screenshot.
dckc created a review comment on a pull request on Agoric/agoric-sdk
@turadg once suggested that I stick to literals for this sort of thing. I tend to agree. ```suggestion id: `lpDeposit-1234`, ``` You could make a separate test assertion that `t.is(no...
dckc created a review comment on a pull request on Agoric/agoric-sdk
likewise: ```suggestion USDC: { brand: USDC, value: 100n }, ``` but as I say, if somebody gives 100 in a CLI arg, I'd expect to see: ```suggestion USDC: { brand: USD...
dckc created a review comment on a pull request on Agoric/agoric-sdk
nice. maybe add that to the `oracle attest` command?
dckc created a review comment on a pull request on Agoric/agoric-sdk
I'm surprised `markeMarshal` doesn't require these to be remotables. I usually have to do: ```suggestion const USDC = Far('usdcbrand'); const FastLP = Far('fastlpbrand'); ```