Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
dckc created a review comment on a pull request on Agoric/agoric-sdk
I wonder about demoting `deposit` and `withdraw` under `lp`. Didn't @turadg considered that option and decide against it?
dckc created a review comment on a pull request on Agoric/agoric-sdk
Let's not make people write `1000000` for 1 USDC. **important** Use `parseDecimal` here (based on `assertParsableNumber`) and then once you have the `usdc` brand from vstorage, `parseRatio` is r...
dckc created a review comment on a pull request on Agoric/agoric-sdk
boring. Here's hoping we clean that up: #10491
dckc created a review comment on a pull request on Agoric/agoric-sdk
These can't both be omitted, right? ```suggestion * @param {( * { vstorageKit?: Awaited<ReturnType<typeof makeVstorageKit>> } * | { fetch: Window['fetch'] }) ```
dckc created a review comment on a pull request on Agoric/agoric-sdk
thinking: I don't understand how that typechecks. `undefined` isn't a `BoardSlottingMarshaller`
dckc created a comment on an issue on Agoric/agoric-sdk
Recent work seems to treat the whole BoardRemote thing as a nuisance: ``` $ ack XXX | grep -i boardremote boot/test/orchestration/contract-upgrade.test.ts:65: // @ts-expect-error XXX Boar...
dckc created a comment on a pull request on Agoric/agoric-sdk
The issue says: > Also fix up the "description" package.json of fast-usdc I don't see any relevant changes.
dckc created a review comment on a pull request on Agoric/agoric-sdk
Why would we want it to be noticeable? It's only here due to limitations in tsc or the Passable type or something.
dckc created a review comment on a pull request on Agoric/agoric-sdk
The schema is below in `stateShape`, right? That's how I knew to write the code this way: it refused to store the state record without this property.
dckc created a review comment on a pull request on Agoric/agoric-sdk
it didn't. I tried a helper for the 1st arg and then took it out, and used the more concise form when I took it out. I realized the second arg didn't need the line-breaks either.
dckc created a review comment on a pull request on Agoric/agoric-sdk
yes, it's more dependencies, but without a connection to noble, the whole notion of "fast usdc" goes away. It's supported only for a limited form of testing. If somebody forgot to set the flag, the...
dckc pushed 3 commits to dc-start-fast-usdc Agoric/agoric-sdk
dckc created a comment on a pull request on Agoric/agoric-sdk
odd [ci failure](https://github.com/Agoric/agoric-sdk/actions/runs/12242887453/job/34151354324?pr=10641#step:5:6288)... ``` k 17 - upgrading › upgrade-vats › upgrade vat-board %ava-dur=84021ms ...
dckc created a review comment on a pull request on Agoric/documentation
as if people hold objects? that hurts my brain. I'll have to think it over.
dckc created a review comment on a pull request on Agoric/documentation
rely as in "reliance set" comes from [Concurrency Among Strangers](https://papers.agoric.com/papers/concurrency-among-strangers/full-text/). I'll think about where to work that in.
dckc pushed 3 commits to dc-start-fast-usdc Agoric/agoric-sdk
dckc created a review comment on a pull request on Agoric/agoric-sdk
after internal discussion, I realized operating with no noble connection is change to the advancer API, so we might as well put the new method there.
dckc created a review comment on a pull request on Agoric/agoric-sdk
good catch; turns out the `noble:` one is _not_ necessary after all.