Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
dckc created a review comment on a pull request on Agoric/agoric-sdk
This address... it's not used for anything other than bech32 checksum validation, right? How about using `bech32.encode('agoric', Array(20).fill(0))` aka `agoric1qqqqqqqqqqqqqqqqqqqqhlgkpj`?
dckc created a review comment on a pull request on Agoric/agoric-sdk
again, my brain goes: not `ChainAddressShape`? I can see that it's correct, but using the same name for 2 things is hurting my brain.
dckc created a review comment on a pull request on Agoric/agoric-sdk
using `.toString()` with `q(...)` looks odd somehow. hm.
dckc created a review comment on a pull request on Agoric/agoric-sdk
I wonder if we're ok with negative block numbers. ```suggestion blockNumber: M.nat(), ```
dckc created a review comment on a pull request on Agoric/agoric-sdk
Using the same property name for a string here and a `ChainAddress` elsewhere is hurting my tiny brain.
dckc created a review comment on a pull request on Agoric/agoric-sdk
we seem to throw away all but the `.value` without checking it. Just use a string?
dckc created a review comment on a pull request on Agoric/agoric-sdk
what a pain that `.getAddress()` is async. Surely it's in the account exo state.
dckc created a review comment on a pull request on Agoric/agoric-sdk
chainId is `noble-1` but not `agoric-3`?
dckc created a review comment on a pull request on Agoric/agoric-sdk
as noted above if we're using `JSON.parse`, we might as well get rid of the regex and `Object.fromEntries`.
dckc created a review on a pull request on Agoric/agoric-sdk
I need to understand better what `intermediateRecipient` is used for. None of the rest of the comments are important/critical.
dckc created a review on a pull request on Agoric/agoric-sdk
I need to understand better what `intermediateRecipient` is used for. None of the rest of the comments are important/critical.
dckc created a review comment on a pull request on Agoric/agoric-sdk
I'm struggling to get the relevant invariant in my head. Something that combines `observedBrands` with `state.updatingOracleQuote`
dckc created a review comment on a pull request on Agoric/agoric-sdk
I never did know the difference. Ooh! we have [docs](https://github.com/Agoric/agoric-sdk/blob/d6a7ffb6290c63287c4e1fda66d188440105c2a7/packages/zoe/src/contractFacet/types-ambient.d.ts#L234C1-L235...
dckc created a review comment on a pull request on Agoric/agoric-sdk
I was expecting this to get set to `xsnap` somewhere in ci, but I don't see it. I'm not certain where the bar should be. hm.
dckc created a review on a pull request on Agoric/agoric-sdk
if we want a measurement in every ci run, this doesn't seem to get us there yet
dckc created a review on a pull request on Agoric/agoric-sdk
if we want a measurement in every ci run, this doesn't seem to get us there yet
dckc created a comment on a pull request on Agoric/agoric-sdk
> ℹ fusdc advance computrons (3 oracles) 46517841n 46.5Mc is over 1/2 of the current 65Mc block budget. So no more than 1 per block, and that's if all the oracles report in 1 block. My [p...
dckc created a review comment on a pull request on Agoric/documentation
```suggestion The methodKit parameter to `exoClassKit` is a record where each value is a collection of methods. Each property defines a facet ```
dckc created a review comment on a pull request on Agoric/documentation
I made a patterns cheat-sheet at https://docs.agoric.com/reference/zoe-api/zoe-contract-facet.html#proposal-shapes, but that context is specialized to proposal shapes. hm. Perhaps using glossary...
dckc created a review comment on a pull request on Agoric/documentation
Is "SwingSet" in the reader's vocabulary at this point? Link to glossary entry?
dckc created a review comment on a pull request on Agoric/documentation
```suggestion The methods argument of `exoClass()` is a collection of methods, written in [concise method ``` or "... record of methods ..."
dckc created a review comment on a pull request on Agoric/documentation
```suggestion Fields of the object returned by the `init` function become fields of the persistent state. (_These cannot currently be changed on upgrade, though we're considering relaxing that re...
dckc created a review comment on a pull request on Agoric/documentation
"needs"? as in _every_ long-running multi-customer contract _must_ be upgradable? Immutable contracts are ideal in some ways, no?
dckc created a review on a pull request on Agoric/documentation
Fixing the links is important. The rest of the comments are just suggestions.
dckc created a review on a pull request on Agoric/documentation
Fixing the links is important. The rest of the comments are just suggestions.
dckc published a release on hindley-milner-systems/dapp-ertp-airdrop
v0.1.2 beta
goal: testnet deployment of code with a corresponding clean ci log TODO: - [ ] attach bundles ## What's Changed * Restore Test Suite Integrity and Lint Compliance by @tgrecojs in https://...
dckc created a comment on an issue on hindley-milner-systems/dapp-ertp-airdrop
Doing it in co would in some ways be ideal, but verifying it manually might be plenty for now.