Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
danielpasker created a review comment on a pull request on shaynisanov/GymnastLink-Web
dont pass the post by state. pass the postId as a queryParam and fetch the post again
danielpasker pushed 7 commits to main shaynisanov/GymnastLink-Web
- create workout api in the server 8f225ae
- create workout page in the client 958a16c
- accidentally added }, so i removed it ed786f3
- fix comments 942d62d
- remove generatedWorkout and workoutPlan 18f6e5a
- Merge branch 'main' of https://github.com/shaynisanov/GymnastLink-Web into feat/workouts-page 621b891
- Merge pull request #7 from shaynisanov/feat/workouts-page Feat/workouts page 19fede5
danielpasker closed a pull request on shaynisanov/GymnastLink-Web
Feat/workouts page
danielpasker created a review on a pull request on shaynisanov/GymnastLink-Web
I think we should join the states, if you dont then tell me, it will make the code better in my opinion.
danielpasker created a review on a pull request on shaynisanov/GymnastLink-Web
I think we should join the states, if you dont then tell me, it will make the code better in my opinion.
danielpasker created a review comment on a pull request on shaynisanov/GymnastLink-Web
No you dont, make the prop a trinary based on weather the _id is undefined (true for generated one and false for existing)
danielpasker created a review comment on a pull request on shaynisanov/GymnastLink-Web
use one type for both (with nullable fields), then use them in one state...
danielpasker created a review comment on a pull request on shaynisanov/GymnastLink-Web
it doesn't matter. It is always one or the other to display, and they contain the same kind of data. so why 2?
danielpasker pushed 1 commit to fix/make-images-nullable shaynisanov/GymnastLink-Web
- fix UserAvatar directory 004ddee
danielpasker opened a pull request on shaynisanov/GymnastLink-Web
fix/make-images-nullable
address that non-existing images are null and not undefined
danielpasker created a branch on shaynisanov/GymnastLink-Web
fix/make-images-nullable - The final project of web course
danielpasker created a review comment on a pull request on shaynisanov/GymnastLink-Web
why sending the userId from client you can get it from the body using authMiddleware. see example with RequestWithUserId
danielpasker created a review comment on a pull request on shaynisanov/GymnastLink-Web
what is it for? I dont think you use it
danielpasker created a review comment on a pull request on shaynisanov/GymnastLink-Web
if you use ine state this function is not needed
danielpasker created a review comment on a pull request on shaynisanov/GymnastLink-Web
rem is for font. use px
danielpasker created a review comment on a pull request on shaynisanov/GymnastLink-Web
also here remove it
danielpasker created a review comment on a pull request on shaynisanov/GymnastLink-Web
remove the return
danielpasker created a review comment on a pull request on shaynisanov/GymnastLink-Web
same notes about the name container and width auto
danielpasker created a review comment on a pull request on shaynisanov/GymnastLink-Web
you seem to not use prettier at all, please do. and if you do see if the prettierrc is used
danielpasker created a review comment on a pull request on shaynisanov/GymnastLink-Web
its not a form, call it WorkoutDetails
danielpasker created a review comment on a pull request on shaynisanov/GymnastLink-Web
if you use one state you dont need all this separation
danielpasker created a review comment on a pull request on shaynisanov/GymnastLink-Web
remove the return
danielpasker created a review comment on a pull request on shaynisanov/GymnastLink-Web
why 2 different states? combine them into displayedWorkout or something