Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
danafallon created a review comment on a pull request on artie-labs/transfer
re: my last comment - shouldn't this continue being formatted in ms since that's the format specified in `extTime`?
danafallon created a review comment on a pull request on artie-labs/transfer
Is this not taking the NestedKind's type and format into account?
danafallon created a review comment on a pull request on artie-labs/transfer
Could we only do this if `originalFormat` is nil, so we don't hit an error if we're not going to use the default anyway?
danafallon created a review comment on a pull request on artie-labs/transfer
This can be passed into the constructor on the line above, right?
danafallon created a review comment on a pull request on artie-labs/transfer
Should we make this method take a receiver `t` and use `t.layout()` as the last arg here?
danafallon pushed 1 commit to dana/artie-integration artie-labs/integrations-extras
- Remove images readme file fdc022b
danafallon pushed 1 commit to dana/artie-integration artie-labs/integrations-extras
- Another readme suggestion Co-authored-by: Ursula Chen <[email protected]> e72bf73
danafallon pushed 1 commit to dana/artie-integration artie-labs/integrations-extras
- Readme suggestion Co-authored-by: Ursula Chen <[email protected]> 111af2b
danafallon pushed 1 commit to dana/artie-integration artie-labs/integrations-extras
- Remove marketing language from readme Co-authored-by: Ursula Chen <[email protected]> 79ef4f4
danafallon created a review comment on a pull request on artie-labs/transfer
Ah okay so we won't start storing the tz info for existing columns, but if a new column is created that should be tz-aware then we will store it. Seems reasonable 👍
danafallon created a review comment on a pull request on artie-labs/transfer
Is this comment still true?
danafallon created a review comment on a pull request on artie-labs/transfer
Nit: want to call this `TimezoneOffsetFormat`? So it's clear that it's just being used as a format string and not a hardcoded offset that we're using for anything.