Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
danafallon created a review comment on a pull request on artie-labs/transfer
It looks like before, if we received a timestamp with tz/offset info, we discarded the tz and stored it without it. Now we'll start storing the tz. Is this change going to result in ddl changes to ...
danafallon created a review comment on a pull request on artie-labs/transfer
Although with the multiple lines that could make it hard to read, so I'm also good with leaving it as is.
danafallon created a review comment on a pull request on artie-labs/transfer
How come we're doing this 500 times?
danafallon created a review comment on a pull request on artie-labs/transfer
My main concern was addressed on the other comment, but yeah it might be nice to add a backup check here too, just in case.
danafallon created a review comment on a pull request on artie-labs/transfer
Ah I see, I thought this was the only place we were checking that but now I see that this is just to handle the edge case where different precisions come through for different rows, to make sure we...
danafallon created a review comment on a pull request on artie-labs/transfer
Since this has access to the existing column metadata, is this a better place to check that the new precision is greater than the previous?
danafallon created a review comment on a pull request on artie-labs/transfer
If the column wasn't in `columnToNewLengthMap` then we could end up setting the length to something lower than it currently is. That could cause problems right?
danafallon created a review comment on a pull request on DataDog/integrations-extras
This is currently missing a `source_type_id` because I'm not sure what to use for it. I see in the docs that this should have been generated when I ran `ddev create`, but I don't see an integer ID ...
danafallon pushed 1 commit to dana/artie-integration artie-labs/integrations-extras
- Use tabular format for metrics in readme 4908da4
danafallon created a review comment on a pull request on artie-labs/integrations-extras
Here's how it looks: https://github.com/artie-labs/integrations-extras/blob/bf1b04b1908d3497f6a7133b11506bbcd0813cea/artie/README.md
danafallon created a review comment on a pull request on artie-labs/integrations-extras
Oh it's the same in practice, but datadog's style guidelines want links to be formatted like this.
danafallon created a review comment on a pull request on artie-labs/integrations-extras
Instead of what?
danafallon pushed 1 commit to dana/artie-integration artie-labs/integrations-extras
- Add more integration fields bf1b04b