Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
dakotaramos created a comment on an issue on NREL/HOPP
Just a note, now that @kbrunik has added some additional details, the current cambium API can pull projections for data from 2025-2050 in 5 year intervals, so 1) if you need this for years prior th...
dakotaramos created a review comment on a pull request on NREL/HOPP
removed definition of greet2_no_ccs_central_h2 in this file as it is not used
dakotaramos pushed 1 commit to hopp_lca_pr dakotaramos/HOPP
- removed unused greet file reference in greet_data.py f3dad4c
dakotaramos pushed 2 commits to hopp_lca_pr dakotaramos/HOPP
dakotaramos created a review comment on a pull request on NREL/HOPP
I guess I haven't run into errors because I never hit this except block. I imagine I should add import time to cambium_data.py to resolve this.
dakotaramos created a review comment on a pull request on NREL/HOPP
I dont see any changes here? @johnjasa
dakotaramos pushed 1 commit to hopp_lca_pr dakotaramos/HOPP
- Update hopp/simulation/technologies/resource/greet_data.py Co-authored-by: John Jasa <[email protected]> 01c6743
dakotaramos created a review comment on a pull request on NREL/HOPP
We can delete the reference to it in this file but cannot delete the actual file as there are dependencies / links between GREET 1 and GREET 2 docs.
dakotaramos created a review comment on a pull request on NREL/HOPP
I originally identified more sig figs in the comments, Masha suggested we keep it to 3-6 sig figs
dakotaramos created a review comment on a pull request on NREL/HOPP
I pulled this from the parent class's implementation of call_api() in resource.py, its part of an outer while loop to try to API up to 5 times before failing.
dakotaramos pushed 1 commit to hopp_lca_pr dakotaramos/HOPP
- Update hopp/simulation/technologies/resource/cambium_data.py Co-authored-by: John Jasa <[email protected]> 3edfe6e
dakotaramos pushed 1 commit to hopp_lca_pr dakotaramos/HOPP
- Update hopp/simulation/resource_files/greet/README.md Co-authored-by: John Jasa <[email protected]> aa6f9a0
dakotaramos created a review comment on a pull request on NREL/HOPP
Sounds good to me, I'm on board with your inclination of leave as is for now.
dakotaramos pushed 2 commits to hopp_lca_pr dakotaramos/HOPP
dakotaramos created a review comment on a pull request on NREL/HOPP
Confirmed with Cambium API admin these are the only status codes it is set to return, ie: the test suite is comprehensive of possible HTTPS responses
dakotaramos created a comment on a pull request on NREL/HOPP
Flagging dates of possible Cambium API slow downs due to database updates (James Morris): "Late-Nov or early-Dec we'll be uploading the new Standard Scenarios which might make the db a little sl...
dakotaramos created a review comment on a pull request on NREL/HOPP
I used this to run the processing that creates the default files used for pytesting, so i see some value in keeping it there for future, but can easily remove and add back in.
dakotaramos created a review comment on a pull request on NREL/HOPP
They are part of the parent resource class, I was running into some where errors without them defined because of the attrs used in the parent Resource class. Open to removing them if we can find a ...