Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
croissanne created a tag on osbuild/cockpit-composer
53 - Composer generates custom images suitable for deploying systems or uploading to the cloud. It integrates into Cockpit as a frontend for osbuild composer
croissanne created a branch on croissanne/cockpit-composer
testlib-330 - Composer generates custom images suitable for deploying systems or uploading to the cloud. It integrates into Cockpit as a frontend for Lorax Composer.
croissanne created a comment on a pull request on osbuild/osbuild
> > My big questions are: > > > > 1. Do we want to instead make our own format that the solver returns and then have specific stages that understand that format to write the module and failsafe ...
croissanne pushed 30 commits to empty-err croissanne/image-builder-frontend
- Wizard: Add component to select Azure HyperV generation b4e7fe8
- Wizard: Integrate HyperV selection in Azure target options This determines the generation the image will get registe... c1378a7
- src/test: Add test for HyperV generation c0801cd
- Wizard: Conditionally hide package recommendations This shows package recommendations only when RHEL 8 or RHEL 9 are... b16243f
- devDeps: Manually bump msw from 2.6.0 to 2.6.6 This bumps msw from 2.6.0 to 2.6.6 c268267
- Wizard: Basic Locale step This adds Locale step basics and file structure. 6e97304
- build(deps-dev): bump @typescript-eslint/parser from 8.8.1 to 8.17.0 Bumps [@typescript-eslint/parser](https://githu... cbe04c5
- Wizard: Add locale structure to store and mapper This creates structure and actions for the locale customization in ... e4e83d4
- build(deps-dev): bump @typescript-eslint/eslint-plugin Bumps [@typescript-eslint/eslint-plugin](https://github.com/t... 11e0bbd
- tsconfig: update to es2021 b3b69c3
- api: union undefined Set the option to generate union undefined types for objects that have optional items. This wil... bad7742
- multiple: set pagination defaults Set pagination defaults, otherwise these might be `undefined`. 4125a9c
- pagination 877497f
- multiple: set sane defaults Set sane defaults for some types rather than setting them to `undefined`. This is so tha... d4436dc
- multiple: check when var is possibly undefined In cases where a field on an object might be undefined, rather omit t... 0d4bb26
- tsconfig: exactOptionalPropertyTypes This is a recommended setting, see: https://www.typescriptlang.org/tsconfig/#ex... 696cc4f
- Wizard: Add timezone structure to store and mapper This creates structure and actions for the timezone customization... ab446c2
- Wizard: Add Timezone dropdown and NTP servers input This adds a Timezone select, the select is typeahead and allows ... 6427dc5
- Wizard: Add Timezone step to Review lists This adds a Timezone overview to the Review step. c851d4a
- test: Add more test coverage for Timezone step This adds more tests for the Timezone step: - 'Step Timezone' -> 'rev... b8915da
- and 10 more ...
croissanne opened a pull request on osbuild/image-builder-frontend
ci.sh: inject debug ids using sentry-cli
Since we're building with konflux now, we lost the debug ids. By injecting the debug ids in konflux we regain unminified sourcemaps in sentry. Note that jenkins will continue to upload the sourcema...
croissanne created a branch on croissanne/image-builder-frontend
sentry-cli-inject - OSBuild Installer Frontend
croissanne opened a pull request on osbuild/image-builder-frontend
store/enhancedImageBuilderApi: handle empty error data
Turns out it can also return `{error: data: {}}`, so without `errors` inside the data object.
croissanne created a branch on croissanne/image-builder-frontend
empty-err - OSBuild Installer Frontend
croissanne created a review on a pull request on osbuild/image-builder
I'm ok with this. In the FE you can indeed choose whatever snapshot date, but it will pick the closest snapshot it has. So if you enter 1970 as a date, it'll pick whatever oldest snapshot it has.
croissanne created a review on a pull request on osbuild/osbuild-composer
other than @mvo5's comments lgtm :)
croissanne pushed 1 commit to main osbuild/osbuild-composer
- schutzbot/tests: bump rhel10 to nightly, update tf sha and osbuild deps Bump RHEL 10 from beta to nightly by updatin... f5a5705
croissanne closed a pull request on osbuild/osbuild-composer
tests: Bump RHEL 10 from beta to nightly and update osbuild deps SHA
Related to [COMPOSER-2384](https://issues.redhat.com/browse/COMPOSER-2384?filter=-1) Bumping RHEL 10 from beta image to nightly. Also updating osbuild dependency SHA.
croissanne created a review comment on a pull request on osbuild/osbuild-composer
Like the context isn't passed from up above, but created in this function.
croissanne created a review comment on a pull request on osbuild/osbuild-composer
can we just call this "isInstanceRunning"? I thinkit makes it a bit clearer.
croissanne created a review comment on a pull request on osbuild/osbuild-composer
I'm not sure if we should share the same context here? It probably doesn't matter that much but I don't get the rationale for doing so here.
croissanne created a review comment on a pull request on osbuild/osbuild-composer
I think generally error wrapping is used to wrap deeper errors, not really make a list of them. So maybe we should just add the errors to a slice and then join them together in the end? I think it ...
croissanne created a review comment on a pull request on osbuild/osbuild-composer
I think defining this struct up to instead of an anonymous struct would make it more readable.
croissanne created a review on a pull request on osbuild/osbuild-composer
thanks, looks good overall Could you reword this commit message though? ``` Usually the parent does not exist when also the secure instance is older than 2h, but this an extra safeguard that ...
croissanne created a review on a pull request on osbuild/osbuild-composer
thanks, looks good overall Could you reword this commit message though? ``` Usually the parent does not exist when also the secure instance is older than 2h, but this an extra safeguard that ...
croissanne created a review on a pull request on osbuild/osbuild-composer
In general we don't put the jira ticket in the commit message itself, just the PR title. edit: woops clicked review too soon, still reviewing.
croissanne created a review comment on a pull request on osbuild/osbuild-composer
Eh, looks ok to me. https://awscli.amazonaws.com/v2/documentation/api/2.0.33/reference/ec2/describe-instances.html#options are the filters, and i don't see launchtemplate