Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
arno-lunarg created a review on a pull request on KhronosGroup/Vulkan-ValidationLayers
arno-lunarg created a review on a pull request on KhronosGroup/Vulkan-ValidationLayers
arno-lunarg created a comment on an issue on KhronosGroup/Vulkan-ValidationLayers
Thank you for spotting that! Especially since the error spat at me when testing that was awful, and the debugger would not even break ...
arno-lunarg opened a pull request on KhronosGroup/Vulkan-ValidationLayers
gpuav: Fix / 0 in draw mesh indirect validation
Closes https://github.com/KhronosGroup/Vulkan-ValidationLayers/issues/9014arno-lunarg created a review on a pull request on KhronosGroup/Vulkan-ValidationLayers
arno-lunarg created a review on a pull request on KhronosGroup/Vulkan-ValidationLayers
arno-lunarg created a review comment on a pull request on KhronosGroup/Vulkan-ValidationLayers
```suggestion The `VkDescriptorSet` object contains a buffer with a `PostProcessDescriptorIndexSlot` for each descriptor in it. This "descriptor index slot" holds information that can only be know...
arno-lunarg created a review on a pull request on KhronosGroup/Vulkan-ValidationLayers
arno-lunarg created a review comment on a pull request on KhronosGroup/Vulkan-ValidationLayers
New text needs to be proofread. Add a definition for `PostProcessDescriptorIndexSlot`. Ping me after!
arno-lunarg created a review on a pull request on KhronosGroup/Vulkan-ValidationLayers
arno-lunarg deleted a branch arno-lunarg/Vulkan-ValidationLayers
arno-gpuav-debug-label-validation-cmd
arno-lunarg pushed 1 commit to main KhronosGroup/Vulkan-ValidationLayers
- gpuav: Add debug label regions to validation cmds 541a2d4
arno-lunarg created a review comment on a pull request on KhronosGroup/Vulkan-ValidationLayers
This is a valid concern, so I switched to creating a temporary `Location` storing debug region name for no longer than needed: ```cpp Location loc_with_debug_region(loc, debug_region_name); ```
arno-lunarg created a review on a pull request on KhronosGroup/Vulkan-ValidationLayers
arno-lunarg created a review comment on a pull request on KhronosGroup/Vulkan-ValidationLayers
ごめんなさい 🙇♂️🙇♂️🙇♂️
arno-lunarg created a review on a pull request on KhronosGroup/Vulkan-ValidationLayers
arno-lunarg pushed 7 commits to arno-gpuav-debug-label-validation-cmd arno-lunarg/Vulkan-ValidationLayers
- layers: Cleanup Buffer::ComputeSize It always has been `ComputeValidSize` under the hood, so remove needless abstrac... 7bd8c8b
- tests: Prove image layout works with descriptor indexing 826b9ea
- tests: Add FindSupportedCompressedFormat 0382d40
- layers: Improve error message for copies 33efe00
- layers: Fixes for image buffer copies 94c43f2
- tests: Remove FindSupportedCompressedFormat 9d24718
- gpuav: Add debug label regions to validation cmds 564dc13
arno-lunarg pushed 1 commit to main KhronosGroup/Vulkan-ValidationLayers
- layers: Cleanup Buffer::ComputeSize It always has been `ComputeValidSize` under the hood, so remove needless abstrac... 7bd8c8b
arno-lunarg closed a pull request on KhronosGroup/Vulkan-ValidationLayers
layers: Cleanup Buffer::ComputeSize
It always has been `ComputeValidSize` under the hood, so remove needless abstractionsarno-lunarg pushed 3 commits to gpuav-add-comment arno-lunarg/Vulkan-ValidationLayers
arno-lunarg created a comment on a pull request on KhronosGroup/Vulkan-ValidationLayers
> I am happy with the `validation_cmd` to `cmd_validation` change, but there is an upcoming extension that will be released soon that has GPU-AV being worked on and they have spent a lot of effort ...
arno-lunarg created a review comment on a pull request on KhronosGroup/Vulkan-ValidationLayers
Ok, will change!
arno-lunarg created a comment on an issue on KhronosGroup/Vulkan-ValidationLayers
Tried locally on tiny mesh large, looks like it was working!
arno-lunarg created a review comment on a pull request on KhronosGroup/Vulkan-ValidationLayers
`Location` always being passed around as `const`, I made `debug_region` mutable to avoid having to modify all `const Location&`
arno-lunarg created a review on a pull request on KhronosGroup/Vulkan-ValidationLayers
arno-lunarg pushed 1 commit to arno-gpuav-debug-label-validation-cmd arno-lunarg/Vulkan-ValidationLayers
- gpuav: Add debug label regions to validation cmds 887d36a
arno-lunarg created a review comment on a pull request on KhronosGroup/Vulkan-ValidationLayers
No `const std::string&` to make passing temporary `std::string` illegal: pointer would be dangling
arno-lunarg created a review on a pull request on KhronosGroup/Vulkan-ValidationLayers
arno-lunarg pushed 1 commit to arno-gpuav-debug-label-validation-cmd arno-lunarg/Vulkan-ValidationLayers
- gpuav: Add debug label regions to validation cmds 0164c30