Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
arno-lunarg created a review comment on a pull request on KhronosGroup/Vulkan-ValidationLayers
True!
arno-lunarg created a review comment on a pull request on KhronosGroup/Vulkan-ValidationLayers
This is how I use `GetDebugRegionName`, anything looking wrong @artem-lunarg ?
arno-lunarg opened a pull request on KhronosGroup/Vulkan-ValidationLayers
gpuav: Update debug label regions management
Took some of what Artem did for syncval Add debug label regions for debug printf Still need to add support for secondary command buffers, not so easy
arno-lunarg created a branch on arno-lunarg/Vulkan-ValidationLayers
arno-debug-label-gpu-av - Vulkan Validation Layers
arno-lunarg created a comment on an issue on KhronosGroup/Vulkan-ValidationLayers
Nice! Just know that the fix is essentially to give up validation. Since we don't serialize validation metadata, de-serialized acceleration structure are assumed to be valid. No easy way around tha...
arno-lunarg pushed 1 commit to arno-debug-label-region-2 arno-lunarg/Vulkan-ValidationLayers
- layers: Rework LoggingLabel::Export Remove the need for a staging std::vector e64c318
arno-lunarg pushed 1 commit to arno-debug-label-region-2 arno-lunarg/Vulkan-ValidationLayers
- layers: Rework LoggingLabel::Export Remove the need for a staging std::vector 69c9eb5
arno-lunarg opened a pull request on KhronosGroup/Vulkan-ValidationLayers
layers: Rework LoggingLabel::Export
Remove the need for a staging std::vector
arno-lunarg created a branch on arno-lunarg/Vulkan-ValidationLayers
arno-debug-label-region-2 - Vulkan Validation Layers
arno-lunarg created a review comment on a pull request on KhronosGroup/Vulkan-ValidationLayers
Yeah I was not sure about this one, if a debug region is defined as you say then `stacked` adds no value. But I don't want to go back to `LabelCommand` , again it appears nowhere in the spec so yo...
arno-lunarg created a review comment on a pull request on KhronosGroup/Vulkan-ValidationLayers
Oh ok that's why you named it like so But yeah it just wraps a VkDebugUtilsLabelEXT, something that is use both to define regions and also just insert a label. `DebugUtilsLabel` itself does not di...
arno-lunarg created a review comment on a pull request on KhronosGroup/Vulkan-ValidationLayers
I could just now rename `DebugUtilsLabel::label_name` to `DebugUtilsLabel::name`, no need to reming `label_` ```suggestion label_stack.emplace_back(label_region.name.empty() ? "(empty...
arno-lunarg created a review comment on a pull request on KhronosGroup/Vulkan-ValidationLayers
The original code was not doing that, but I think I need to check that `label` is not `Empty` before exporting it?
arno-lunarg created a review comment on a pull request on KhronosGroup/Vulkan-ValidationLayers
Reworked `Export` to avoid needless copies
arno-lunarg created a review comment on a pull request on KhronosGroup/Vulkan-ValidationLayers
Doing this was my first goal, then things got where they are : 3
arno-lunarg opened a pull request on KhronosGroup/Vulkan-ValidationLayers
layers: Renaming related to debug label regions
Multiple renaming relate to debug label regions. I was working on adding support for debug label regions in GPU-AV, and looking for what we already had was hard. Few of the old names related to ...
arno-lunarg created a branch on arno-lunarg/Vulkan-ValidationLayers
arno-debug-label-regions - Vulkan Validation Layers
arno-lunarg created a review comment on a pull request on KhronosGroup/Vulkan-ValidationLayers
```suggestion bool ValidateBindingOnGPU(const DescriptorBinding &binding, bool is_dynamic_accessed) const { ``` Function defined in a header are likely to be inlined anyway, and `inline` bein...
arno-lunarg created a review comment on a pull request on KhronosGroup/Vulkan-ValidationLayers
Needless `vector` copies will be done here, just have one copy during the last iteration Also, do we truly need a deep copy?
arno-lunarg created a review comment on a pull request on KhronosGroup/Vulkan-ValidationLayers
should not be needed?
arno-lunarg created a review on a pull request on KhronosGroup/Vulkan-ValidationLayers
I think there are needless deep vector copies, aside that LGTM