Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
arno-lunarg created a review on a pull request on KhronosGroup/Vulkan-ValidationLayers
I think there are needless deep vector copies, aside that LGTM
arno-lunarg closed a pull request on KhronosGroup/Vulkan-ValidationLayers
GPU-AV: Add debug label regions to instrumentation error messages
Still need to add it to debug printfarno-lunarg created a review comment on a pull request on KhronosGroup/Vulkan-ValidationLayers
aaaand did that
arno-lunarg created a review on a pull request on KhronosGroup/Vulkan-ValidationLayers
arno-lunarg created a comment on a pull request on KhronosGroup/Vulkan-ValidationLayers
Will add support for debug printf and tests with secondary command buffers tomorrow
arno-lunarg pushed 10 commits to arno-gpuav-debug-labels arno-lunarg/Vulkan-ValidationLayers
- layers: Fix message formatting in WSI validation dda0b17
- layers: Fix handling of deserialized accel struct After a deserialization, VVL has no info on how the deserialized a... d952704
- tests: Deserialized accel struct no false positive 21e6c02
- layers: Fix VU 04087 Need to check that family indices are not equal 3a6023c
- tests: Add ownership transfer tests for 09049 and 09052 There is validation but not the tests for: VUID-VkBufferMemo... 8bbdd7e
- layers: Improve ValidateDescriptor aff9d28
- gpu: Prevent false positives for aliased bindings 62286d3
- tests: Prevent false positives for aliased bindings e7100bb
- gpuav: Add debug label regions to instrumentation errors 7bae578
- tests: Add GPU-AV debug label regions tests de4b2ec
arno-lunarg created a review comment on a pull request on KhronosGroup/Vulkan-ValidationLayers
But I can just move `LabelCommand` outside `vvl::CommandBuffer`
arno-lunarg created a review on a pull request on KhronosGroup/Vulkan-ValidationLayers
arno-lunarg created a review comment on a pull request on KhronosGroup/Vulkan-ValidationLayers
[For the compiler to know that `LabelCommand` is within ](https://stackoverflow.com/questions/1021793/how-do-i-forward-declare-an-inner-class)
arno-lunarg created a review on a pull request on KhronosGroup/Vulkan-ValidationLayers
arno-lunarg created a review comment on a pull request on KhronosGroup/Vulkan-ValidationLayers
ah leftover!
arno-lunarg created a review on a pull request on KhronosGroup/Vulkan-ValidationLayers
arno-lunarg created a review comment on a pull request on KhronosGroup/Vulkan-ValidationLayers
I had that lol, but then I was like "what I really want is for some string to not be in one particular message, not necessarily all of them"
arno-lunarg created a review on a pull request on KhronosGroup/Vulkan-ValidationLayers
arno-lunarg created a review comment on a pull request on KhronosGroup/Vulkan-ValidationLayers
I have to use reverse iterators, doing a reverse loop by hand is messy, it looks ass but at least I am sure the reverse loop is not messed up : /
arno-lunarg created a review on a pull request on KhronosGroup/Vulkan-ValidationLayers
arno-lunarg created a review comment on a pull request on KhronosGroup/Vulkan-ValidationLayers
I will remove `label_command`, but keep the others
arno-lunarg created a review on a pull request on KhronosGroup/Vulkan-ValidationLayers
arno-lunarg created a review comment on a pull request on KhronosGroup/Vulkan-ValidationLayers
We have to carry a value in the logging lambda, a pointer/reference would be dangling at error logging time. And that value may not be there if not within a debug label region, so have to use an op...
arno-lunarg created a review on a pull request on KhronosGroup/Vulkan-ValidationLayers
arno-lunarg created a review comment on a pull request on KhronosGroup/Vulkan-ValidationLayers
no because `LabelCommand` is withing `vvl::CommandBuffer` : /
arno-lunarg created a review on a pull request on KhronosGroup/Vulkan-ValidationLayers
arno-lunarg opened a pull request on KhronosGroup/Vulkan-ValidationLayers
GPU-AV: Add debug label regions to instrumentation error messages
Still need to add it to debug printfarno-lunarg created a branch on arno-lunarg/Vulkan-ValidationLayers
arno-gpuav-debug-labels - Vulkan Validation Layers
arno-lunarg created a review comment on a pull request on KhronosGroup/Vulkan-ValidationLayers
Not sure why this `dummy` assignment is not considered dead code, and the following `+=` is, I trust your judgment on this!
arno-lunarg created a review on a pull request on KhronosGroup/Vulkan-ValidationLayers
arno-lunarg deleted a branch arno-lunarg/Vulkan-ValidationLayers
arno-fix-deserialized-accel-structs-validation