Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
almogdepaz created a review comment on a pull request on Chia-Network/chia-blockchain
this doesn't really make sense to me in the case of the short_sync methods or even for add block
almogdepaz created a review comment on a pull request on Chia-Network/chia-blockchain
i dont have a strong opinion on that, if we do it the other way around we need to throw an explicit exception for when we dont have the block
almogdepaz created a review comment on a pull request on Chia-Network/chia-blockchain
the hight is an optimization for most cases where we now the hight of the block (the only case we dont is unfinished blocks) i agree with all your points, im still trying to figure out exactly w...
almogdepaz pushed 1 commit to assert-height-to-hash-in-contains-block Chia-Network/chia-blockchain
- use try in wallet blockchain 14c3339
almogdepaz pushed 1 commit to track_wp_tasks Chia-Network/chia-blockchain
- Update chia/full_node/full_node.py Co-authored-by: Kyle Altendorf <[email protected]> bff98d9
almogdepaz created a review comment on a pull request on Chia-Network/chia-blockchain
this list is length n = 2 at most
almogdepaz created a review comment on a pull request on Chia-Network/chia-blockchain
i dont think this is simpler, we have two loops instead of one and i feel this is less readable
almogdepaz pushed 1 commit to assert-height-to-hash-in-contains-block Chia-Network/chia-blockchain
- remove assert 9c1eab1
almogdepaz pushed 1 commit to assert-height-to-hash-in-contains-block Chia-Network/chia-blockchain
- remove assert 6feaf13
almogdepaz pushed 1 commit to remove-contains_height Chia-Network/chia-blockchain
- use peak height inside contains height 91831b4
almogdepaz pushed 1 commit to assert-height-to-hash-in-contains-block Chia-Network/chia-blockchain
- handle none b229e7e
almogdepaz pushed 1 commit to assert-height-to-hash-in-contains-block Chia-Network/chia-blockchain
- fix recursion 74b27f4
almogdepaz pushed 1 commit to assert-height-to-hash-in-contains-block Chia-Network/chia-blockchain
- use try_block_record 0fcbac1
almogdepaz pushed 1 commit to assert-height-to-hash-in-contains-block Chia-Network/chia-blockchain
- use_height_if_available e06555f
almogdepaz opened a draft pull request on Chia-Network/chia-blockchain
add assertions
<!-- Merging Requirements: - Please give your PR a title that is release-note friendly - In order to be merged, you must add the most appropriate category Label (Added, Changed, Fixed) to your PR...
almogdepaz created a comment on a pull request on Chia-Network/chia-blockchain
i feel like we can consolidate all the methods for adding blocks in test in to one, not necessarily in this pr but i think it would reduce errors for people writing tests
almogdepaz created a branch on Chia-Network/chia-blockchain
assert-height-to-hash-in-contains-block - Chia blockchain python implementation (full node, farmer, harvester, timelord, and wallet)
almogdepaz created a review comment on a pull request on Chia-Network/chia-blockchain
oh right, ok i think [chain_a[-1]] would maybe be more clear for someone who is not familiar with what we are doing
almogdepaz created a review comment on a pull request on Chia-Network/chia-blockchain
theres a better way to do this instead of randomly trying, you can enforce the sp the block would be created after, so you can make sure the chain_a would be infused after the chain_b block, you ca...
almogdepaz created a review comment on a pull request on Chia-Network/chia-blockchain
i think chain_a[-1] instead of chain_a[-1:] since the intention is to only add one block here