Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
almogdepaz created a comment on a pull request on Chia-Network/chia-blockchain
> This is a great simplification. I think that, perhaps, the original intent shifted a little bit though. The description suggests the fork info isn't necessary, but the change makes it mandatory. ...
almogdepaz pushed 1 commit to refactor_fork_info_usage Chia-Network/chia-blockchain
- assert height in process states edaccaa
almogdepaz pushed 1 commit to refactor_fork_info_usage Chia-Network/chia-blockchain
- rename vars c79ec6b
almogdepaz created a review comment on a pull request on Chia-Network/chia-blockchain
yes i added the post processing and the finish_sync calls to better emulate the original flow from full_node.py, its needed so we notify the wallets on the peak changes
almogdepaz created a review comment on a pull request on Chia-Network/chia-blockchain
thanks i originally did all this to avoid using fork_2 which needs to be optional and then opted for just doing new variable per case so its easier to read but i dont mind, changed
almogdepaz pushed 1 commit to refactor_fork_info_usage Chia-Network/chia-blockchain
- test_cat_creation assert height da52a26
almogdepaz pushed 1 commit to refactor_fork_info_usage Chia-Network/chia-blockchain
- assert sync all height for all wallets 8ea5323
almogdepaz pushed 1 commit to refactor_fork_info_usage Chia-Network/chia-blockchain
- wait for wallet height in nft test cf8118a
almogdepaz pushed 1 commit to refactor_fork_info_usage Chia-Network/chia-blockchain
- assert height in cat test a64f169
almogdepaz created a review comment on a pull request on Chia-Network/chia-blockchain
skip_known_blocks or something i guess, maybe start_from_fork
almogdepaz created a comment on a pull request on Chia-Network/chia-blockchain
> > ok, so the main change is doing the prevalidaition concurrently for different batches ? > > Correct. There was some separation work since it used to be quite intertwined. The `AugmentedBlock...
almogdepaz created a review comment on a pull request on Chia-Network/chia-blockchain
ok i thought gather returns on completion but i see now that we are waiting for all of them to complete, it ok if it keeps the order but i would add a comment since this can break the sync
almogdepaz pushed 1 commit to refactor_fork_info_usage Chia-Network/chia-blockchain
- revert known block info change 83745cf
almogdepaz pushed 1 commit to refactor_fork_info_usage Chia-Network/chia-blockchain
- fix failed reorg test f8f71b4
almogdepaz pushed 17 commits to refactor_fork_info_usage Chia-Network/chia-blockchain
- Update changelog for 2.4.4 (#18700) ef11555
- Update CHANGELOG.md ea5402f
- Merge commit 'ef11555e45c4222f1ac481479cda3d2f731ca523' into checkpoint/main_from_release_2.4.4_ef11555e45c4222f1ac48... 04431a5
- Require fewer arguments for `chia wallet coins split` in the CLI (#18689) * initial commit * add test the other ... 21c6f39
- checkpoint: into main from release/2.4.4 @ ef11555e45c4222f1ac481479cda3d2f731ca523 (#18713) Source hash: ef11555e4... ce6733a
- Add `combine_coins` Known Issue to changelog (#18702) Add Known issue around `combine_coins` 3973952
- Merge commit '39739520211670d398173f87cd1e97c755274195' into checkpoint/main_from_release_2.4.4_39739520211670d398173... bf90e13
- [CHIA-1635] Add default for `number_of_coins` in `CombineCoins` (#18704) Add default for `number_of_coins` in `Combi... 3ce4acb
- Remove Python 3.8 support and update source to 3.9 standards (#18687) * manual python 3.8 removals * poetry * ... 9c8557a
- fix bluebox 658d356
- Fix bluebox shutdown (#18725) ### Purpose: Use a temporary file as a flag for when bluebox threads should abort ... 23b1cb5
- Move some files closer to where they should live. (#18465) * Move to `chia.full_node.util.safe_cancel_task` * Mov... f69233a
- checkpoint: into main from release/2.4.4 @ 39739520211670d398173f87cd1e97c755274195 (#18717) Source hash: 397395202... 263f7ac
- [CHIA-1561] validate UnfinishedBlocks and signature in thread pool (#18730) validate UnfinishedBlocks and signature ... bbe5077
- CHIA-1626 Move some modules to the utils virtual project (#18692) Move some modules to the utils virtual project. 6c2c13a
- build(deps): bump boto3 from 1.34.143 to 1.35.43 (#18732) Bumps [boto3](https://github.com/boto/boto3) from 1.34.143... 470ae0f
- Merge branch 'main' into refactor_fork_info_usage ce10ec4
almogdepaz created a review comment on a pull request on Chia-Network/chia-blockchain
something im missing here, what keeps the order of the blocks we are prevalidating ?
almogdepaz created a review comment on a pull request on Chia-Network/chia-blockchain
something im missing here, what keeps the order of the blocks we are prevalidating ?
almogdepaz created a review comment on a pull request on Chia-Network/chia-blockchain
i think this name is confusing since it suggest that the order is not relevant and this should only be relevant for the blocks under the actual fork point (not the one we are guessing from the wp...
almogdepaz created a comment on a pull request on Chia-Network/chia-blockchain
> ne in the new pipeline step. My understanding is that the term "pre-validation" we use isn't very well defined (other than the part of the validation that can be done independently of the surroun...
almogdepaz created a comment on a pull request on Chia-Network/chia-blockchain
@arvidn im not sure im following the description of this pr, from what i understand the full validation and adding to the db still happens inside blockchain.add_block right ? i see the changes...
almogdepaz created a review comment on a pull request on Chia-Network/chia-blockchain
+1 on explaining why we need this new case
almogdepaz pushed 1 commit to refactor_fork_info_usage Chia-Network/chia-blockchain
- remove init file from log dir 58ac803
almogdepaz pushed 1 commit to refactor_fork_info_usage Chia-Network/chia-blockchain
- restore comment 8352060