Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
Waelthus created a review comment on a pull request on igmhub/picca
so the estimator by JM (on which we base the covar output as well) is different from the estimator actually used. I think this is sub-optimal and we might want to use JMs in the future. We'd defini...
Waelthus created a review comment on a pull request on igmhub/picca
the issue for me is not where exactly the documentation is, but at least on first glance it's somewhat hard to follow the code even looking at JMs note next to it. So we should probably try to stre...
Waelthus created a tag on igmhub/picca
v9.9.0 - set of tools for continuum fitting, correlation function calculation, cosmological fits...
Waelthus closed a pull request on igmhub/picca
[bump minor] p1d masking change
change the p1d combination to reject short spectra or spectra with heavy masking based on a certain fraction of spectrum, not number of pixels.
Waelthus closed a pull request on igmhub/picca
[bump minor] Update publish-to-test-pypi.yml
This should hopefully fix #1083. Bumping the version so that the rule is triggered on merge
Waelthus created a comment on a pull request on igmhub/picca
sounds good to go for me then. Let's merge this after seeing if the other PR succeeded in fixing the deployment.
Waelthus created a comment on a pull request on igmhub/picca
I'll merge this now and we'll see if it fixes the issue
Waelthus created a review comment on a pull request on igmhub/picca
are we now using Jean-Marc's estimator here, and is that just the same as before? Or are we using something else?
Waelthus created a review comment on a pull request on igmhub/picca
Overall I think this code could have some simplification/clarification. Maybe we should add the covariance document to picca and explicitely mention which quantities are which with equation numbers...
Waelthus created a review comment on a pull request on igmhub/picca
This changes the weights to be proper weights and not sqrts? Most other changes are just renaming things...
Waelthus created a review comment on a pull request on igmhub/picca
the -1 in the factor here seems to be the second actual change (i.e. the correction for finite sample size aka 1/(N-1) factors in variance calculations)
Waelthus created a comment on a pull request on igmhub/picca
I personally last looked at this with @moonlovist (i.e. Ting) in Hawaii. Not sure what the current status is. But given that the PR just adds a new script, there shouldn't be any issues outside of ...
Waelthus created a comment on a pull request on desihub/desispec
not sure if the fix should be applied when computing nightlybias or if this should actually fail... Also still needs to be tested.
Waelthus created a comment on an issue on desihub/desispec
I confirm the issue, and I think it was introduced when we disallowed calibfinder to run with darks in DESI_SPECTRO_CALIB for normal analyses. So I guess the PR above will fix this behaviour by all...
Waelthus opened a pull request on desihub/desispec
allow fallback to darks/biases in DESI_SPECTRO_CALIB if running ccdcalib
should fix #2399
Waelthus pushed 1 commit to more_useful_desi_dark_table_error desihub/desispec
- use better error message 87922ab
Waelthus created a branch on desihub/desispec
more_useful_desi_dark_table_error - DESI spectral pipeline
Waelthus created a comment on an issue on desihub/desispec
it looks like this would happen if there are no new files to be added, cannot really check retroactively what happened there as files are changed already. Did you generate new files with modified h...
Waelthus created a comment on a pull request on schoeneberg/lym1d
or rather, I'm pretty sure the wrapper would need some changes to accomodate this, i.e. to allow running nuisance mode for the alternative options; and now that I look at it I guess naming things `...
Waelthus opened a pull request on schoeneberg/lym1d
add additional options to likelihood/emulator for Deltastar/nstar/alphastar
This PR is to add additional options for building the emulator on Delta_star/n_star, and allowing for replacing omega_m by alpha_star which are precomputed on newer models.hdf5 files. It also allow...