Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
RnkSngh created a review comment on a pull request on open-ibc/vibc-core-smart-contracts
re second nit though I added messaging as you requested, thanks for the suggestion
RnkSngh created a review comment on a pull request on open-ibc/vibc-core-smart-contracts
(assuming you meant I _don't_ need the `exit 1` ) I think we actually do need this `exit 1` to cause the root workflow to fail ; not sure if this is default behavior or maybe it's an os thing b...
RnkSngh pushed 1 commit to raunak/fix-go-bindings open-ibc/vibc-core-smart-contracts
- modify go bindings generation to fail if abi gen isn't found 0f8d8e3
RnkSngh closed a pull request on open-ibc/vibc-core-smart-contracts
modify go bindings generation to fail if abi gen isn't found
Despite us attempting to check go bindings in our CI, our `make bindings-gen-go` command was not properly checking - we weren't properly installing `abigen` since we were using `go install` inste...
RnkSngh pushed 1 commit to raunak/fail-on-abigen-not-installed open-ibc/vibc-core-smart-contracts
- modify go bindings generation to fail if abi gen isn't found 8f25bb7
RnkSngh created a review comment on a pull request on open-ibc/vibc-core-smart-contracts
yea, I can add the check for the command itself, but i think we should still keep this in case something else about the abigen command returns a non-zero exit
RnkSngh pushed 1 commit to raunak/fix-go-bindings open-ibc/vibc-core-smart-contracts
- default to not running fork tests d49d52e
RnkSngh created a review comment on a pull request on open-ibc/vibc-core-smart-contracts
ah you meant msg.sender of the dest chain, yes i can add
RnkSngh published a release on open-ibc/vibc-core-smart-contracts
v4.0.15
## What's Changed * add example proof api contract by @RnkSngh in https://github.com/open-ibc/vibc-core-smart-contracts/pull/278 **Full Changelog**: https://github.com/open-ibc/vibc-core-smart-co...
RnkSngh closed a pull request on open-ibc/vibc-core-smart-contracts
add example proof api contract
<!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced the `Venus` smart contract for validating events across block...
RnkSngh created a review comment on a pull request on open-ibc/vibc-core-smart-contracts
sure! changed
RnkSngh created a review comment on a pull request on open-ibc/vibc-core-smart-contracts
actually, I think it might be slightly complicated to find the original sender of the log, since we have to json decode it?
RnkSngh created a review comment on a pull request on open-ibc/vibc-core-smart-contracts
valid. I remove rlp byes and substitute for sender. Maybe receipt root is more useful here as well
RnkSngh pushed 1 commit to raunak/example-proof-api-dapp open-ibc/vibc-core-smart-contracts
- add example proof api contract b85cb34
RnkSngh pushed 1 commit to raunak/example-proof-api-dapp open-ibc/vibc-core-smart-contracts
- add example proof api contract e0679de
RnkSngh published a release on open-ibc/vibc-core-smart-contracts
v4.0.14
## What's Changed * increment height in peptide proof by @RnkSngh in https://github.com/open-ibc/vibc-core-smart-contracts/pull/277 **Full Changelog**: https://github.com/open-ibc/vibc-core-smart...
RnkSngh pushed 1 commit to main open-ibc/vibc-core-smart-contracts
- increment height in peptide proof b9f269e
RnkSngh closed a pull request on open-ibc/vibc-core-smart-contracts
increment height in peptide proof
<!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Updated the `CrossL2Prover` contract to improve receipt validation logi...