Ecosyste.ms: Timeline

Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.

LukeHagar

LukeHagar created a review on a pull request on sveltejs/kit

View on GitHub

LukeHagar pushed 1 commit to crossws LukeHagar/kit
  • corrected package.json versions dda7298

View on GitHub

LukeHagar pushed 19 commits to main LukeHagar/crossws
  • chore(deps): update all non-major dependencies (#89) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.nor... f9d0946
  • chore(deps): update all non-major dependencies (#98) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.nor... 3c852d9
  • chore(deps): update all non-major dependencies (#99) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.nor... 630577f
  • chore(deps): update all non-major dependencies (#100) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.no... ad0b7e2
  • chore(deps): update all non-major dependencies (#101) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.no... b5fda3a
  • chore(deps): update autofix-ci/action digest to 551dded (#104) Co-authored-by: renovate[bot] <29139614+renovate[bot]... 708b1d0
  • chore: update deps bef0f4f
  • docs: add `destr` tip for JSON parsing (#109) 14b4f6b
  • chore(examples): fix typo (#107) f33efaf
  • chore(deps): update codecov/codecov-action action to v5 (#92) Co-authored-by: renovate[bot] <29139614+renovate[bot]@... 676c577
  • feat: support throwing responses in `upgrade` hook (#91) Co-authored-by: Pooya Parsa <[email protected]> c850a66
  • chore: remote unused type e3c2cf5
  • feat(peer): support `context` (#110) d17eee6
  • feat: shared context between `upgrade` hook and `peer` (#111) 35842c6
  • chore: update build config 3f5a5dc
  • chore: fix upgrade hook type regression in #91 ee7b282
  • fix(types): `peer.request` always has `.headers` if defined e915f8d
  • fix(types): mark `peer.request` as always defined 8fbb59b
  • chore(release): v0.3.2 a1cab88

View on GitHub

LukeHagar created a review comment on a pull request on sveltejs/kit
fixed

View on GitHub

LukeHagar created a review on a pull request on sveltejs/kit

View on GitHub

LukeHagar pushed 1 commit to crossws LukeHagar/kit

View on GitHub

LukeHagar created a review comment on a pull request on sveltejs/kit
Done

View on GitHub

LukeHagar created a review on a pull request on sveltejs/kit

View on GitHub

LukeHagar pushed 1 commit to crossws LukeHagar/kit
  • moved adapter integration, added response getter to HttpError 6408350

View on GitHub

LukeHagar pushed 1 commit to crossws LukeHagar/kit

View on GitHub

LukeHagar pushed 1 commit to crossws LukeHagar/kit

View on GitHub

LukeHagar pushed 1 commit to crossws LukeHagar/kit

View on GitHub

LukeHagar pushed 1 commit to crossws LukeHagar/kit

View on GitHub

LukeHagar created a review comment on a pull request on sveltejs/kit
I'll set things up for the response getter now

View on GitHub

LukeHagar created a review on a pull request on sveltejs/kit

View on GitHub

LukeHagar pushed 1 commit to crossws LukeHagar/kit
  • ditching reject function for existing error 29fdfec

View on GitHub

LukeHagar created a review on a pull request on sailpoint-oss/typescript-sdk

View on GitHub

LukeHagar created a review comment on a pull request on sveltejs/kit
That may be the easiest method, as we could very simply add a resaponse gettor to the HttpError implementation

View on GitHub

LukeHagar created a review on a pull request on sveltejs/kit

View on GitHub

LukeHagar created a review comment on a pull request on sveltejs/kit
So that would mean that you could throw a response or an error with a response method on it?

View on GitHub

LukeHagar created a review on a pull request on sveltejs/kit

View on GitHub

LukeHagar pushed 1 commit to crossws LukeHagar/kit

View on GitHub

LukeHagar created a review comment on a pull request on sveltejs/kit
Oh I see what your saying, seems like a fine idea to me. I'll make it so.

View on GitHub

LukeHagar created a review on a pull request on sveltejs/kit

View on GitHub

LukeHagar created a review comment on a pull request on sveltejs/kit
is there a common interface the types share that we can align on or should I just add a helper function to accept either type from either package?

View on GitHub

LukeHagar created a review on a pull request on sveltejs/kit

View on GitHub

LukeHagar created a review comment on a pull request on sveltejs/kit
Absolutely but the flow that allows this to drop into the existing routing flow is going to require a normal response return here, even through its just discarded

View on GitHub

LukeHagar created a review on a pull request on sveltejs/kit

View on GitHub

LukeHagar created a review comment on a pull request on sveltejs/kit
Well sure, but the handle function for example only returns responses, what would you propose instead?

View on GitHub

LukeHagar created a review on a pull request on sveltejs/kit

View on GitHub

Load more