Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
LukeHagar pushed 1 commit to crossws LukeHagar/kit
- Update documentation/docs/30-advanced/15-websockets.md Co-authored-by: Ben McCann <[email protected]... 0ea72ab
LukeHagar pushed 1 commit to crossws LukeHagar/kit
- Update documentation/docs/30-advanced/15-websockets.md Co-authored-by: Ben McCann <[email protected]... 1fed29d
LukeHagar pushed 1 commit to crossws LukeHagar/kit
- Update documentation/docs/30-advanced/15-websockets.md Co-authored-by: Ben McCann <[email protected]... ff58988
LukeHagar pushed 1 commit to crossws LukeHagar/kit
- Update documentation/docs/30-advanced/15-websockets.md Co-authored-by: Ben McCann <[email protected]... fda8a68
LukeHagar created a review comment on a pull request on sveltejs/kit
I'll set things up for the response getter now
LukeHagar pushed 1 commit to crossws LukeHagar/kit
- ditching reject function for existing error 29fdfec
LukeHagar created a review comment on a pull request on sveltejs/kit
That may be the easiest method, as we could very simply add a resaponse gettor to the HttpError implementation
LukeHagar created a review comment on a pull request on sveltejs/kit
So that would mean that you could throw a response or an error with a response method on it?
LukeHagar pushed 1 commit to crossws LukeHagar/kit
- Update documentation/docs/30-advanced/15-websockets.md Co-authored-by: Ben McCann <[email protected]... cc58820
LukeHagar created a review comment on a pull request on sveltejs/kit
Oh I see what your saying, seems like a fine idea to me. I'll make it so.
LukeHagar created a review comment on a pull request on sveltejs/kit
is there a common interface the types share that we can align on or should I just add a helper function to accept either type from either package?
LukeHagar created a review comment on a pull request on sveltejs/kit
Absolutely but the flow that allows this to drop into the existing routing flow is going to require a normal response return here, even through its just discarded
LukeHagar created a review comment on a pull request on sveltejs/kit
Well sure, but the handle function for example only returns responses, what would you propose instead?
LukeHagar pushed 1 commit to crossws LukeHagar/kit
- Update packages/kit/src/exports/index.js Co-authored-by: Tee Ming <[email protected]> 2a9971f
LukeHagar created a review comment on a pull request on sveltejs/kit
[HttpError is detailed here](https://github.com/sveltejs/kit/blob/01f001bd861e399027a580c9402b7b6206de3d24/packages/kit/src/runtime/control.js#L1) its the bare minimum content for an error response...
LukeHagar created a review comment on a pull request on sveltejs/kit
I did, but SvelteKit has existing methods of typing the exports that require no direct user action for the intellisense to populate, and I would like to get this export working the same way.
LukeHagar pushed 1 commit to crossws LukeHagar/kit
- Update documentation/docs/30-advanced/15-websockets.md Co-authored-by: Pooya Parsa <[email protected]> 0abeb17
LukeHagar created a review comment on a pull request on sveltejs/kit
So I actually have it modeled this way as it better reflects the existing flow for the error function in SvelteKit, but if we were able to align on the throw types and get all package working well ...