Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
LukeHagar pushed 1 commit to crossws LukeHagar/kit
- Update packages/kit/src/exports/index.js Co-authored-by: Tee Ming <[email protected]> 2a9971f
LukeHagar created a review comment on a pull request on sveltejs/kit
[HttpError is detailed here](https://github.com/sveltejs/kit/blob/01f001bd861e399027a580c9402b7b6206de3d24/packages/kit/src/runtime/control.js#L1) its the bare minimum content for an error response...
LukeHagar created a review comment on a pull request on sveltejs/kit
I did, but SvelteKit has existing methods of typing the exports that require no direct user action for the intellisense to populate, and I would like to get this export working the same way.
LukeHagar pushed 1 commit to crossws LukeHagar/kit
- Update documentation/docs/30-advanced/15-websockets.md Co-authored-by: Pooya Parsa <[email protected]> 0abeb17
LukeHagar created a review comment on a pull request on sveltejs/kit
So I actually have it modeled this way as it better reflects the existing flow for the error function in SvelteKit, but if we were able to align on the throw types and get all package working well ...
LukeHagar created a review comment on a pull request on sveltejs/kit
Returning a `101` here actually causes internal error in crossws with undici that I saw, but I could have missed something.
LukeHagar created a review comment on a pull request on sveltejs/kit
I think mostly yes, but notably the crossws package expects a thrown Response rather than HttpError. Otherwise I'm fine with a less exhaustive status list.
LukeHagar pushed 1 commit to crossws LukeHagar/kit
- adjusted implementation to only use responses and the updated crossws package 70202e3
LukeHagar created a comment on a pull request on unjs/crossws
Hey @pi0, Close frame doesnt seem to be fully supported cross platform, so I think we just move on with what is already implemented, I think we have everything we need.
LukeHagar closed a pull request on unjs/crossws
feat: add `accept` and `reject` functions to `upgrade` hook interface for more explicit auth flow
Related #88 This PR is intended to discuss the interface for the upgrade hook, as it stands right now the usage can be a bit ambiguous, this PR shows what I think is a simpler flow for most peo...
LukeHagar closed a pull request on LukeHagar/plex-api-fiddle
Init API-Fiddle adapter 16656f3f
A new adapter was created between a workspace on API-Fiddle and this repository. This PR adds the workspace file to this repository.