Ecosyste.ms: Timeline

Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.

HT154

HT154 created a branch on HT154/pkl

external-reader-deadlock-fix - A configuration as code language with rich validation and tooling.

HT154 pushed 2 commits to main HT154/pkl
  • Fix semver comparison logic (#773) Fix `isLessThan` logic between semvers 4b4d81b
  • Use ANSI colors for test results; more polish (#771) Any thrown Pkl Errors are colored in the simple test report! ... 40a08af

View on GitHub

HT154 created a review comment on a pull request on apple/pkl
Given that the resolver types are shared between the client readers and external readers, is org.pkl.core.externalreader really the right place for these types?

View on GitHub

HT154 created a review on a pull request on apple/pkl

View on GitHub

HT154 created a comment on an issue on apple/pkl
> Is there a reason why `-x` isn't defined as "set output.value"? Modules can set `output.text` directly so `output.value` may be ignored entirely.

View on GitHub

HT154 created a comment on an issue on apple/pkl
This a dupe of #742

View on GitHub

HT154 pushed 9 commits to main HT154/pkl
  • Polish external reader API/implementation (#759) - keep implementation classes internal to their packages - make cl... cc72f9d
  • Use VmObjectBuilder in Listing.distinct(By) implementations (#760) 1be1fe4
  • Eagerly check listing/mapping in iterables (#752) There is currently a bug around resolving variables within the ite... 66d751f
  • Refine external reader API (#762) * Encapsulate message transport by removing `ExternalReaderProcess.getTransport` a... e217cfc
  • Add color to error formatting (#746) * Add color to error formatting * Apply suggestions from code review Co-a... 03462fe
  • Update to GraalVM 23.0.6 and GraalVM for JDK 17.0.12 (#765) GraalVM for JDK 17.0.12 is the final Critical Patch Upda... d501798
  • Update commonmark and test dependencies (#767) 3f38173
  • More external reader refinements (#766) * org.pkl.core.Readers -> org.pkl.core.Closeables * Remove coupling between... fa25fb4
  • Remove pkl.core.messaging from core APIs (#770) 9692504

View on GitHub

HT154 deleted a branch HT154/pkl

external-reader-refinements-final-final-2

HT154 opened a pull request on apple/pkl
Remove pkl.core.messaging from core APIs
HT154 created a branch on HT154/pkl

external-reader-refinements-final-final-2 - A configuration as code language with rich validation and tooling.

HT154 created a review comment on a pull request on apple/pkl
The constructors for the resolver classes take a `MessageTransport` so I these do need to move?

View on GitHub

HT154 created a review on a pull request on apple/pkl

View on GitHub

HT154 created a review comment on a pull request on apple/pkl
I think I get it? I'm still tripping over how Java does things. The idea here is to ensure that nothing in `org.pkl.core.messaging` ends up in the `org.pkl.core.module`/`resource` public API, ri...

View on GitHub

HT154 created a review on a pull request on apple/pkl

View on GitHub

HT154 pushed 1 commit to more-external-reader-refinements HT154/pkl

View on GitHub

HT154 pushed 1 commit to more-external-reader-refinements HT154/pkl

View on GitHub

HT154 created a review comment on a pull request on apple/pkl
Not in love with the naming here, but it's necessary to disambiguate and accurately describes the functionality. These classes are a straight move, though git doesn't show that.

View on GitHub

HT154 created a review on a pull request on apple/pkl

View on GitHub

HT154 opened a pull request on apple/pkl
More external reader refinements
* Rename `org.pkl.core.Readers` -> `org.pkl.core.Closeables` * Remove coupling between `pkl.core.module`/`resource` and `pkl.core.messaging`
HT154 pushed 1 commit to more-external-reader-refinements HT154/pkl
  • Remove coupling between pkl.core.module/resource and pkl.core.messaging 05edf47

View on GitHub

HT154 pushed 1 commit to more-external-reader-refinements HT154/pkl
  • org.pkl.core.Readers -> org.pkl.core.Closeables 6821fc8

View on GitHub

HT154 created a comment on a pull request on apple/pkl
@translatenix Yup, needed some more time to chew on these > Did you consider addressing this one? > > * org.pkl.core.module.ResourceReaders API is (too) tightly coupled to reader protocol via...

View on GitHub

HT154 created a branch on HT154/pkl

more-external-reader-refinements - A configuration as code language with rich validation and tooling.

HT154 deleted a branch HT154/pkl

external-reader-api-refinement

HT154 created a review comment on a pull request on apple/pkl
Worth calling out handling for evaluating non-ASCII file module URIs and the executor exception handling stuff too?

View on GitHub

HT154 created a review on a pull request on apple/pkl

View on GitHub

HT154 created a review comment on a pull request on apple/pkl
Should the external reader flags be called out here as well?

View on GitHub

HT154 created a review comment on a pull request on apple/pkl
Do the additions to the evaluator settings (external readers, color from #746) need to be covered here too?

View on GitHub

HT154 created a review on a pull request on apple/pkl

View on GitHub

Load more