Ecosyste.ms: Timeline

Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.

HT154

HT154 created a review comment on a pull request on apple/pkl
Hmm, I had renamed this to align with `ResourceReaders.MessageTransport` since, like that class, this one is used by both external readers and client readers. I think I'd prefer to keep this name a...

View on GitHub

HT154 created a review on a pull request on apple/pkl

View on GitHub

HT154 created a review comment on a pull request on apple/pkl
I think this was to hard-differentiate between server messages and external reader messages, based on one of our discussions quite a while back. Definitely open to revising this.

View on GitHub

HT154 created a review on a pull request on apple/pkl

View on GitHub

HT154 created a review comment on a pull request on apple/pkl
`externalreader` sounds good to me. I was following the lead of `evaluatorSettings` 😅

View on GitHub

HT154 created a review on a pull request on apple/pkl

View on GitHub

HT154 created a review comment on a pull request on apple/pkl
Haha this actually goes back to my original proposal of a new pkl-msgapi project! Agreed on, if we eventually decide to publish this, having these bits be standalone and on doing that as followup w...

View on GitHub

HT154 created a review on a pull request on apple/pkl

View on GitHub

HT154 created a comment on a pull request on apple/pkl
Hmm I think this may be a legitimate difference in how things are handled on different OSs: ``` Changed content at line 6: expecting: ["at 日本語_error#日本語 (file:///$snippetsDir/input/modules/%E...

View on GitHub

HT154 pushed 1 commit to nihongjouzu HT154/pkl
  • Hopefully fix windows support f8605ec

View on GitHub

HT154 pushed 2 commits to external-readers HT154/pkl
  • Improve backcompat for new language binding libs on old pkl versions Box Bytes, fix error CLI handling during projec... 60da0f9
  • Apply suggestions from code review Co-authored-by: Daniel Chao <[email protected]> Apply suggestions from cod... e561cc3

View on GitHub

HT154 pushed 6 commits to external-readers HT154/pkl
  • Implement SPICE-0009 External Readers [SPICE-0009](https://github.com/apple/pkl-evolution/pull/10) New close flow 477b454
  • docs b9c7a19
  • Add ExternalReaderRuntime, lots of test coverage 6920775
  • Add doc comments to new public APIs bac0086
  • Improve backcompat for new language binding libs on old pkl versions Box Bytes, fix error CLI handling during projec... be40970
  • Apply suggestions from code review Co-authored-by: Daniel Chao <[email protected]> Apply suggestions from cod... 9323690

View on GitHub

HT154 pushed 1 commit to external-readers HT154/pkl
  • Refactor out External*Resolver classes, rename ResourceReaders.ExternalDelegate and ModuleKeys.External to MessageTra... 97313c9

View on GitHub

HT154 pushed 25 commits to external-readers HT154/pkl
  • Set lower limit for glob pattern resolution in test mode (#693) Motivation: Speed up the test that verifies enforce... 475f29c
  • Improve let-expression examples (#680) (#699) Because I did not understand what a `Let Expression` should be and the... 421711b
  • Replace some usages of java.lang.String.replaceAll with String.replace (#701) Both methods replace all occurrences. ... 1022cf3
  • Fix invalid syntax in doc comments of pkl:reflect members (#703) 7ac51f1
  • Fix formatting of let expressions (#702) 2add291
  • Fix error in spread documentation (#704) 9b5c5a5
  • Fix double unary minus (#697) Fix an issue where doubly unary minus (e.g. `--1`) on int/float literals are incorrect... 62c796a
  • Update dependencies (#689) - Update dependencies by deleting lock files and regenerating them with `gw updateDepende... d271b62
  • Refactor message-passing logic into pkl-core This is preparatory work for [SPICE-0009](https://github.com/apple/pkl-... 28cdbbf
  • Split server-specific messages/encoding/decoding back into pkl-server 87016a7
  • Implement SPICE-0009 External Readers [SPICE-0009](https://github.com/apple/pkl-evolution/pull/10) 30312a1
  • New close flow e4d2651
  • docs 70c91cf
  • Add ExternalReaderRuntime, lots of test coverage 9bc3cc3
  • Add doc comments to new public APIs 99aba3d
  • Improve backcompat for new language binding libs on old pkl versions bdb3c5a
  • Box Bytes, fix error CLI handling during project load 9d705dc
  • Apply suggestions from code review Co-authored-by: Daniel Chao <[email protected]> da6f7cf
  • Apply suggestions from code review Co-authored-by: Daniel Chao <[email protected]> ff28289
  • Rename --external-* CLI flags to --external-*-reader 0c9ef1f
  • and 5 more ...

View on GitHub

HT154 pushed 11 commits to nihongjouzu HT154/pkl
  • Set lower limit for glob pattern resolution in test mode (#693) Motivation: Speed up the test that verifies enforce... 475f29c
  • Improve let-expression examples (#680) (#699) Because I did not understand what a `Let Expression` should be and the... 421711b
  • Replace some usages of java.lang.String.replaceAll with String.replace (#701) Both methods replace all occurrences. ... 1022cf3
  • Fix invalid syntax in doc comments of pkl:reflect members (#703) 7ac51f1
  • Fix formatting of let expressions (#702) 2add291
  • Fix error in spread documentation (#704) 9b5c5a5
  • Fix double unary minus (#697) Fix an issue where doubly unary minus (e.g. `--1`) on int/float literals are incorrect... 62c796a
  • Update dependencies (#689) - Update dependencies by deleting lock files and regenerating them with `gw updateDepende... d271b62
  • Fix handling of file: module URIs with non-ASCII characters Closes #653 d91e9b5
  • Refactor to IoUtils; Cover FileResolver, StackFrameTransformer; more tests 0a2c4d6
  • Hopefully fix windows support 02d193e

View on GitHub

HT154 pushed 8 commits to parse-dynamic-disallow-default HT154/pkl
  • Replace some usages of java.lang.String.replaceAll with String.replace (#701) Both methods replace all occurrences. ... 1022cf3
  • Fix invalid syntax in doc comments of pkl:reflect members (#703) 7ac51f1
  • Fix formatting of let expressions (#702) 2add291
  • Fix error in spread documentation (#704) 9b5c5a5
  • Fix double unary minus (#697) Fix an issue where doubly unary minus (e.g. `--1`) on int/float literals are incorrect... 62c796a
  • Update dependencies (#689) - Update dependencies by deleting lock files and regenerating them with `gw updateDepende... d271b62
  • Error when JSON/YAML parsing would set property `default` in a Dynamic Resolves #561 ea57d3b
  • Improved error messages ed92c3e

View on GitHub

HT154 created a review comment on a pull request on apple/pkl
I'm not sure that's any less surprising to users than throwing an exception here, but it at least broadens the set of valid inputs rather than shrinks it. Would love some input from the core team o...

View on GitHub

HT154 created a review on a pull request on apple/pkl

View on GitHub

HT154 pushed 1 commit to parse-dynamic-disallow-default HT154/pkl

View on GitHub

HT154 created a review comment on a pull request on apple/pkl
Ah good catch. I think I've got this sorted, but I have no way to test on windows to be sure.

View on GitHub

HT154 created a review on a pull request on apple/pkl

View on GitHub

HT154 pushed 1 commit to nihongjouzu HT154/pkl
  • Hopefully fix windows support aec1da9

View on GitHub

HT154 pushed 1 commit to nihongjouzu HT154/pkl
  • Refactor to IoUtils; Cover FileResolver, StackFrameTransformer; more tests 2bb9201

View on GitHub

HT154 created a review comment on a pull request on apple/pkl
Yup, just forgot to push the updated snippets. Fixed now!

View on GitHub

HT154 created a review on a pull request on apple/pkl

View on GitHub

HT154 pushed 1 commit to nihongjouzu HT154/pkl
  • Refactor to IoUtils; Cover FileResolver, StackFrameTransformer; more tests a7b312d

View on GitHub

HT154 deleted a branch HT154/pkl

double-invert-fix

HT154 created a comment on a pull request on apple/pkl
I refactored this into `IoUtils`, adopted it in `FileResolved` and also `StackFrameTransformer`, and added some more test coverage. I suspect most other usage of `Path.of` in the codebase is at ...

View on GitHub

HT154 pushed 1 commit to nihongjouzu HT154/pkl
  • Refactor to IoUtils; Cover FileResolver, StackFrameTransformer; more tests ee42e1a

View on GitHub

HT154 created a review comment on a pull request on apple/pkl
Added a `ParseException` type that takes and renders SnakeYAML's `Mark`, eg. ``` –– Pkl Error –– Error parsing YAML document. 3 | x = new yaml.Parser{}.parse(""" ^^^^^^^^^^^^^^^^^^^^...

View on GitHub

Load more