Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
Daksh14 created a review comment on a pull request on dusk-network/rusk
We have 2 abstractions now, SecureWalletFile and `WalletFilePath` I'm not a big fan of abstractions themselves and we should only keep these abstractions if a user is going to use them as a library...
Daksh14 created a review comment on a pull request on dusk-network/rusk
If there are no bounds do we need to be generic over F?
Daksh14 created a review comment on a pull request on dusk-network/rusk
Saving the password here in the memory is necessary? I don't think its secure also given this struct is gonna live for the duration of the wallet's instance. Can we have it like before where the pa...
Daksh14 created a review on a pull request on dusk-network/rusk
I have lots of RFC(s) and comments for this refactor, we can sync to go over them also if thats easier
Daksh14 created a review on a pull request on dusk-network/rusk
I have lots of RFC(s) and comments for this refactor, we can sync to go over them also if thats easier
Daksh14 created a review on a pull request on dusk-network/rusk
Please next time keep the changes as atomic as you can, I can see the changes are ordered in the description of the PR but it just makes it harder to review
Daksh14 created a review on a pull request on dusk-network/rusk
The arm build isnt triggered because no changes are made to rusk-wallet. It should be run once before merging into master to avoid broken CI
Daksh14 pushed 3 commits to master dusk-network/rusk
- rusk-wallet: Fix contract deploy properly serialize init args Add proper check for wasm file location a3db50c
- rusk-wallet: Change cap of init buffer for contract deployment Signed-off-by: Daksh <[email protected].... b46ccf9
- Merge pull request #3090 from dusk-network/fix_contract_deploy rusk-wallet: Fix contract deploy properly serialize i... 9e2e712
Daksh14 closed a pull request on dusk-network/rusk
rusk-wallet: Fix contract deploy properly serialize init args
Add proper check for wasm file location
Daksh14 pushed 1 commit to fix_contract_deploy dusk-network/rusk
- rusk-wallet: Change cap of init buffer for contract deployment Signed-off-by: Daksh <[email protected].... b46ccf9
Daksh14 pushed 1 commit to fix_contract_deploy dusk-network/rusk
- rusk-wallet: Change init arg size 4138b06
Daksh14 pushed 1 commit to fix_contract_deploy dusk-network/rusk
- rusk-wallet: Change cap of init buffer for contract deployment Signed-off-by: Daksh <[email protected].... fc64953
Daksh14 opened a pull request on dusk-network/rusk
rusk-wallet: Fix contract deploy properly serialize init args
Add proper check for wasm file location
Daksh14 created a branch on dusk-network/rusk
fix_contract_deploy - The reference Dusk platform implementation and tools
Daksh14 opened a pull request on dusk-network/rusk
rusk-wallet: Fix syncing check
Insert last pos after we insert notes
Daksh14 pushed 1 commit to fix_sync_status dusk-network/rusk
- rusk-wallet: Fix syncing check Insert last pos after we insert notes Signed-off-by: Daksh <[email protected]... 7a2f8d5
Daksh14 created a branch on dusk-network/rusk
fix_sync_status - The reference Dusk platform implementation and tools
Daksh14 created a review comment on a pull request on dusk-network/rusk
I changed the method to use the `stake_info` method now double check and let me know @moCello
Daksh14 created a review comment on a pull request on dusk-network/rusk
please check the contents of `get_stake_reward` function. It requires a helper function because we need to access the state that means we have to be connected to the chain and be online which can b...
Daksh14 created a review comment on a pull request on dusk-network/rusk
Amt is now optional and if its none then all the available rewards will be withdrawn @HDauven @moCello
Daksh14 pushed 1 commit to withdraw_partial_rewards dusk-network/rusk
- rusk-wallet: Withdraw all rewards if none specified 8ed3093
Daksh14 created a review comment on a pull request on dusk-network/rusk
I think we should include tests for negative integers, and out of bounds check? Overflow while arithmetic?