Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
BrianWhitneyAI created a review comment on a pull request on AllenInstitute/biofile-finder
Resolved in [03c770b](https://github.com/AllenInstitute/biofile-finder/pull/389/commits/03c770bc20447a5d27bbb7dde49360e254854308)
BrianWhitneyAI created a review comment on a pull request on AllenInstitute/biofile-finder
for record. Consensus was env is used elsewhere and should remain
BrianWhitneyAI created a review comment on a pull request on AllenInstitute/biofile-finder
This is for backwards compatibility. Right now its possible this.path is '/allen' in this case we want to return it.
BrianWhitneyAI created a review comment on a pull request on AllenInstitute/biofile-finder
We dont have labkey download for staging files I believe so this function default returns the cloud path for the staging file which can be downloaded
BrianWhitneyAI pushed 1 commit to feature/derive_local_path AllenInstitute/biofile-finder
- update test:desktop script 6a6b2c8
BrianWhitneyAI pushed 1 commit to feature/derive_local_path AllenInstitute/biofile-finder
- Add backwards compat 03c770b
BrianWhitneyAI created a review comment on a pull request on AllenInstitute/biofile-finder
In regards to `Cache Eviction Date` I don't think that we should use this yet since it has not been backfilled and will only show up on new annotations. We would not reach a state where the file pa...
BrianWhitneyAI created a review comment on a pull request on AllenInstitute/biofile-finder
The backwards compatibility is to handle file.path being '/allen' or the updated version where file.path = cloud path. I thought that we were fully past that after the new file rebuild, hence tryin...
BrianWhitneyAI created a review comment on a pull request on AllenInstitute/biofile-finder
Not sure what the comment is here but my interpretation is this format allows us to create our own annotations in BFF which we later propagate with the file properties.
BrianWhitneyAI created a review comment on a pull request on AllenInstitute/biofile-finder
removed in [3bee712](https://github.com/AllenInstitute/biofile-finder/pull/389/commits/3bee712c637ad2bf7571bed19b960fe11de85598)
BrianWhitneyAI created a review comment on a pull request on AllenInstitute/biofile-finder
Not any more.... removed in [3bee712](https://github.com/AllenInstitute/biofile-finder/pull/389/commits/3bee712c637ad2bf7571bed19b960fe11de85598)
BrianWhitneyAI created a review comment on a pull request on AllenInstitute/biofile-finder
I made getLocalPath as a function in [3bee712](https://github.com/AllenInstitute/biofile-finder/pull/389/commits/3bee712c637ad2bf7571bed19b960fe11de85598). However I left get localPath where it cal...
BrianWhitneyAI created a review comment on a pull request on AllenInstitute/biofile-finder
Yep!, adding the Environment adds an indent that GitHub doesn't like.
BrianWhitneyAI created a review comment on a pull request on AllenInstitute/biofile-finder
resolved by removing in [3bee712](https://github.com/AllenInstitute/biofile-finder/pull/389/commits/3bee712c637ad2bf7571bed19b960fe11de85598)
BrianWhitneyAI created a review comment on a pull request on AllenInstitute/biofile-finder
Resolved by deriving from cloud path in [3bee712](https://github.com/AllenInstitute/biofile-finder/pull/389/commits/3bee712c637ad2bf7571bed19b960fe11de85598)
BrianWhitneyAI created a review comment on a pull request on AllenInstitute/biofile-finder
Resolved by removing in [3bee712](https://github.com/AllenInstitute/biofile-finder/pull/389/commits/3bee712c637ad2bf7571bed19b960fe11de85598)