Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
AlbertoElias created a review comment on a pull request on Crossmint/crossmint-sdk
This was a leftover attempt at fixing a TypeScript issue. The actual fix was passing default values for `jwt`, `user` etc as undefined
AlbertoElias created a review comment on a pull request on Crossmint/crossmint-sdk
When HttpOnly is set, the client can't send a refresh token because it can't access the cookie, so it needs to be fetched from the cookie in the server
AlbertoElias created a review comment on a pull request on Crossmint/crossmint-sdk
I thought the original name was really bad, and as it hasn't shipped yet, it's not a breaking change. I think the new name is more consistent with the naming elsewhere
AlbertoElias created a review comment on a pull request on Crossmint/crossmint-sdk
It actually depends on the environment. In next.js it's fine with just the path, in remix I had to provide the whole URL. will document it
AlbertoElias pushed 1 commit to albertoe/WAL-2982-auth-client-sdk Crossmint/crossmint-sdk
- removes getSession method efbd7cf
AlbertoElias pushed 1 commit to albertoe/WAL-2982-auth-client-sdk Crossmint/crossmint-sdk
- addresses pr review c4cf67f
AlbertoElias created a review comment on a pull request on Crossmint/crossmint-sdk
it still needs to be valid url, and this param is used in the oauth flow, just not used anymore in the rest of the flows. I think it's good to have an ugly name as a reminder that we need to refact...
AlbertoElias created a review comment on a pull request on Crossmint/crossmint-sdk
I think I'll just delete it. This is a half-baked method just to be API compliant with server sdk. It returns the jwt if it's there for immediate use as we needed that behaviour in the react sdk, b...
AlbertoElias created a review comment on a pull request on Crossmint/crossmint-sdk
Other apps that use the auth client sdk directly, instead of the react one, will want to do similar actions as the ones we take here in the react sdk. The idea of the client auth sdk is to be frame...
AlbertoElias created a review comment on a pull request on Crossmint/crossmint-sdk
Yeah, for further context, all async tasks enter the event loop. It has different stacks that as it loops around picks up a task from each stack. Promises I believe enter the microTask stack and re...
AlbertoElias pushed 1 commit to albertoe/WAL-3057-httponly-cookies Crossmint/crossmint-sdk
- fixes build b49290f
AlbertoElias created a review comment on a pull request on Crossmint/crossmint-sdk
have you tested it in smarter wallets? would it be too hard to remove react-query from there and see how it's being added?
AlbertoElias created a review comment on a pull request on Crossmint/crossmint-sdk
so what happens with web3 login? when is the wallet created?
AlbertoElias created a review comment on a pull request on Crossmint/crossmint-sdk
Open to suggestions. Here I implemented as per the approved PRD and we discussed multiple API surfaces and ended up going with this one. So following this `from` approach is a must. But if there's ...
AlbertoElias created a review comment on a pull request on Crossmint/crossmint-sdk
this is a callback that is called after the react sdk calls logout
AlbertoElias created a review comment on a pull request on Crossmint/crossmint-sdk
not sure what you're referring to
AlbertoElias created a review comment on a pull request on Crossmint/crossmint-sdk
well, how the `Crossmint` object is managed is that a new jwt triggers a new version: https://github.com/Crossmint/crossmint-sdk/blob/main/packages/client/ui/react-ui/src/hooks/useCrossmint.tsx#L23...