Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
AlbertoElias created a review comment on a pull request on Crossmint/crossmint-sdk
what do you mean? what is always truthy?
AlbertoElias created a review comment on a pull request on Crossmint/crossmint-sdk
We also need to delete the cookies. But what we're missing is calling the server when performing a logout
AlbertoElias created a review comment on a pull request on Crossmint/crossmint-sdk
Fair, I explained in other comments why we're calling this
AlbertoElias created a review comment on a pull request on Crossmint/crossmint-sdk
copying from another comment: > handleRefreshToken triggers a task to get the most recent auth material and set off a timer to re-check later on so it's more like a background process that we wa...
AlbertoElias created a review comment on a pull request on Crossmint/crossmint-sdk
This is so we can mimick the API decided for the server sdk but in most cases it won't be used like this. We only expect this to return the jwt. `handleRefreshToken` triggers a task to get the most...
AlbertoElias created a review comment on a pull request on Crossmint/crossmint-sdk
I thought about this too, but didn't want to touch the `apiClient` just in case and followed the same pattern used elsewhere
AlbertoElias created a review comment on a pull request on Crossmint/crossmint-sdk
yeah, initially I removed baseUrl thinking I didn't need it, but it ended up being necessary in one place and I added it back and it stayed like this haha
AlbertoElias pushed 1 commit to albertoe/WAL-3057-httponly-cookies Crossmint/crossmint-sdk
- Fixes custom refresh with httponly as it should get token from cookie fbd1167
AlbertoElias opened a pull request on Crossmint/crossmint-sdk
Auth: Supports setting custom routes for refrsh and configuring cookie options
## Description To support a more secure way to store authentication material, we'd like to support them being stored in Secure + HttpOnly cookies. To do so, they need to be set server-side. So t...
AlbertoElias created a branch on Crossmint/crossmint-sdk
albertoe/WAL-3057-httponly-cookies - Crossmint SDK for client and server integrations
AlbertoElias created a review comment on a pull request on Crossmint/crossmint-sdk
If they install our module, as we have react-query as a dep in our package.json, it will still install for them
AlbertoElias created a review comment on a pull request on Crossmint/crossmint-sdk
Sorry, I had forgotten to push my review in the server PR. PTAL
AlbertoElias created a review comment on a pull request on Crossmint/crossmint-sdk
What do you mean? What kind of overhead?
AlbertoElias created a review comment on a pull request on Crossmint/crossmint-sdk
was this not used at all?
AlbertoElias created a review comment on a pull request on Crossmint/crossmint-sdk
should these applications also use tsup or not worth it? (not for this PR)
AlbertoElias created a review comment on a pull request on Crossmint/crossmint-sdk
why rename? to maintain consistency with nextjs app?
AlbertoElias created a review comment on a pull request on Crossmint/crossmint-sdk
wish it would make sense to hide this in an api call so we could change it easily but not sure it would be worth it
AlbertoElias created a review comment on a pull request on Crossmint/crossmint-sdk
can this be dependent on the chain they set in the auth provider?