Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
AhmedThahir created a review on a pull request on scikit-learn/scikit-learn
@paulAdrienMarie The `refit` parameter was supposed to appear after `cv` parameter. This is not a programming issue, but a conflict with the sklearn docs automation, as I followed the scheme follow...
AhmedThahir created a review on a pull request on scikit-learn/scikit-learn
@paulAdrienMarie The `refit` parameter was supposed to appear after `cv` parameter. This is not a programming issue, but a conflict with the sklearn docs automation. Just sharing this as feedbac...
AhmedThahir created a comment on a pull request on AhmedThahir/scikit-learn
Ah yes, I was confused for moment! But I resolved here: https://github.com/scikit-learn/scikit-learn/pull/30463/commits/6177f9f8a0b0f676a5cbc36a3721eb7d53f7f75c
AhmedThahir closed a pull request on AhmedThahir/scikit-learn
Update _coordinate_descent.py
better this way sorry <!-- Thanks for contributing a pull request! Please ensure you have taken a look at the contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/main/CO...
AhmedThahir commented on a commit on paulAdrienMarie/scikit-learn
> Sorry for the complications ... it was my first pull request ! Thank you for taking the time to explain it to me :) No issues at all, you found a lot of mistakes from my end. I appreciate it
AhmedThahir commented on a commit on paulAdrienMarie/scikit-learn
Join here: https://meet.google.com/rmx-ugsw-aqk
AhmedThahir pushed 2 commits to main AhmedThahir/scikit-learn
AhmedThahir closed a pull request on AhmedThahir/scikit-learn
Update _coordinate_descent.py
<!-- Thanks for contributing a pull request! Please ensure you have taken a look at the contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/main/CONTRIBUTING.md --> ###...
AhmedThahir commented on a commit on paulAdrienMarie/scikit-learn
Hi @paulAdrienMarie, any chance you could do it quickly? It's late here and I'll be traveling tomorrow. Just wanted to make sure that you get your credit, so I'm waiting for you. If you still ne...
AhmedThahir created a comment on a pull request on scikit-learn/scikit-learn
@kayo09, please do not make such reviews - it confuses us. Only @paulAdrienMarie and I are assigned to work on this PR.
AhmedThahir commented on a commit on paulAdrienMarie/scikit-learn
Okay, no issues. You can do this: Just take the content of your _coordinate_descent.py and paste it into https://github.com/AhmedThahir/scikit-learn/blob/main/sklearn/linear_model/_coordinate_de...
AhmedThahir commented on a commit on paulAdrienMarie/scikit-learn
No issues at all! You need to create a PR to my branch: https://github.com/AhmedThahir/scikit-learn/tree/main
AhmedThahir created a comment on an issue on scikit-learn/scikit-learn
https://github.com/scikit-learn/scikit-learn/pull/30468 You're supposed to merge into my PR, not the sklearn main branch 😅
AhmedThahir commented on a commit on paulAdrienMarie/scikit-learn
This is not required, as `refit=True` by default.
AhmedThahir commented on a commit on paulAdrienMarie/scikit-learn
Could you merge this to the PR, so that I can pull it and work on it as well.
AhmedThahir created a comment on an issue on scikit-learn/scikit-learn
Could you commit your changes to that PR?
AhmedThahir created a comment on a pull request on scikit-learn/scikit-learn
I think I'm done from my side with the code changes and documentation. Code changes for `ElasticNetCV` and `MultitaskElasticNetCV` will be done by @paulAdrienMarie
AhmedThahir created a comment on an issue on scikit-learn/scikit-learn
@jeremiedbb , LogisticRegressionCV already has `refit` attribute. Just want to confirm this refit is already doing the same, right?: ``` refit bool, default=True If set to True, the scores ...
AhmedThahir pushed 1 commit to main AhmedThahir/scikit-learn
- Adding for Ridge, Lars, OrthogonalMatchingPursuitCV 777bb55