Ecosyste.ms: Timeline

Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.

zeta-chain/node

kingpinXD created a review on a pull request on zeta-chain/node

View on GitHub

kingpinXD created a review comment on a pull request on zeta-chain/node
The size of validatorRes might be quite big (100 + validators) . Can we add a unit test with a big set .

View on GitHub

kingpinXD created a review on a pull request on zeta-chain/node

View on GitHub

kingpinXD created a review comment on a pull request on zeta-chain/node
Who would be using this query ? Wouldnt it make sense to have a query which returns the TokensFromShares instead ? Becuase returning the shares after converting to Int , will not be useful . Plea...

View on GitHub

kingpinXD created a review on a pull request on zeta-chain/node

View on GitHub

kingpinXD created a review on a pull request on zeta-chain/node

View on GitHub

kingpinXD created a review comment on a pull request on zeta-chain/node
Why do we need to use TransientGasConfig, instead of KVGasConfig .

View on GitHub

kingpinXD created a review on a pull request on zeta-chain/node

View on GitHub

kingpinXD created a review comment on a pull request on zeta-chain/node
Can we log the error here?

View on GitHub

kingpinXD created a review on a pull request on zeta-chain/node

View on GitHub

kingpinXD created a review comment on a pull request on zeta-chain/node
What is the expected behaviour if a user , executes a `CancelUnbondingDelegation` after this . Within the unbending period

View on GitHub

kingpinXD created a review on a pull request on zeta-chain/node

View on GitHub

kingpinXD created a review comment on a pull request on zeta-chain/node
Consider using precompiletypes

View on GitHub

kingpinXD created a review on a pull request on zeta-chain/node

View on GitHub

kingpinXD created a review comment on a pull request on zeta-chain/node
Consider mving the common logic between stake and unstake into a separate function

View on GitHub

kingpinXD created a review on a pull request on zeta-chain/node

View on GitHub

ws4charlie pushed 1 commit to feat-adopt-btcd-v1.16 zeta-chain/node
  • add address types as comments to function call btcutil.DecodeAddress() 8b8ff3c

View on GitHub

coderabbitai[bot] created a comment on a pull request on zeta-chain/node
<!-- This is an auto-generated comment: summarize by coderabbit.ai --> <!-- This is an auto-generated comment: skip review by coderabbit.ai --> > [!IMPORTANT] > ## Review skipped > > Draft detect...

View on GitHub

ws4charlie created a review comment on a pull request on zeta-chain/node
Context: a panic was thrown in the past, so this defer was then introduced as a guard.

View on GitHub

ws4charlie created a review on a pull request on zeta-chain/node

View on GitHub

ws4charlie created a review comment on a pull request on zeta-chain/node
I added a unit test to ensure this feature is disabled on mainnet: https://github.com/zeta-chain/node/pull/3025/commits/7e6368f3ed07f0a3afaa55f2270a65a0da79746a

View on GitHub

ws4charlie created a review on a pull request on zeta-chain/node

View on GitHub

ws4charlie created a review comment on a pull request on zeta-chain/node
updated https://github.com/zeta-chain/node/pull/3025/commits/7e6368f3ed07f0a3afaa55f2270a65a0da79746a

View on GitHub

ws4charlie created a review on a pull request on zeta-chain/node

View on GitHub

ws4charlie created a review comment on a pull request on zeta-chain/node
added https://github.com/zeta-chain/node/pull/3025/commits/7e6368f3ed07f0a3afaa55f2270a65a0da79746a

View on GitHub

ws4charlie created a review on a pull request on zeta-chain/node

View on GitHub

ws4charlie pushed 1 commit to feat-btc-revert-address zeta-chain/node
  • add more description for function; add unit test to ensure that standard memo is disabled for mainnet 7e6368f

View on GitHub

lumtis created a review comment on a pull request on zeta-chain/node
Why this change in this file? looks unrelated to the purpose of the PR?

View on GitHub

lumtis created a review comment on a pull request on zeta-chain/node
```suggestion if err := zetaApp.LoadHeight(height); err != nil { ```

View on GitHub

lumtis created a review on a pull request on zeta-chain/node

View on GitHub

Load more