Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
@kingpinXD, I'm glad to hear that you agree. Refactoring the tests as suggested will indeed make it easier to add more tests in the future. (\^\_^\)♪ <!-- This is an auto-generated reply by CodeR...
kingpinXD created a review comment on a pull request on zeta-chain/node
I also think this is a good idea , it would make it easier to add more tests if needed
kingpinXD created a review comment on a pull request on zeta-chain/node
We can move this to cmd/zetacored/config where we maintain the other prefixes
ws4charlie created a review comment on a pull request on zeta-chain/node
The `DecodeLegacyMemoHex` returns error only when the argument is a invalid hex string, but the argument passed here is guaranteed to be a valid hex string.
kingpinXD created a review comment on a pull request on zeta-chain/node
```suggestion // But coinset will only contain one coin, always. ```
kingpinXD created a review comment on a pull request on zeta-chain/node
Can the NewCoin function panic ? If so, should we consider handling it ?
swift1337 pushed 1 commit to feat/ton-withdrawals zeta-chain/node
- Implement TON cctx scheduler f107ccc
kingpinXD created a review comment on a pull request on zeta-chain/node
Can we modify the comment to reflect the change
ws4charlie created a review comment on a pull request on zeta-chain/node
This unpacking only works on new version. The old version is the `DecodeLegacyMemoHex`.
fbac pushed 1 commit to feat/staking-distribute-function zeta-chain/node
- fix event name typo 884598c
fbac created a review comment on a pull request on zeta-chain/node
nit: not in the scope of this PR, but is this defer recover really needed? Going through `DecodeAddress` code shows that there are no panic raised by it or functions called from it.
ws4charlie created a review comment on a pull request on zeta-chain/node
The wait is done by `utils.WaitCctx....`, so there is no wait in here any more.
codecov[bot] created a comment on a pull request on zeta-chain/node
## [Codecov](https://app.codecov.io/gh/zeta-chain/node/pull/3039?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zeta-chai...
kingpinXD created a review comment on a pull request on zeta-chain/node
Maybe mention the address types that work now with the decode ? P2WSH, P2WPKH, P2SH, P2PKH, TapRoot
coderabbitai[bot] created a review on a pull request on zeta-chain/node
**Actionable comments posted: 0** <details> <summary>🧹 Outside diff range and nitpick comments (12)</summary><blockquote> <details> <summary>pkg/chains/address.go (2)</summary><blockquote> Line ...