Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
lumtis created a review comment on a pull request on zeta-chain/node
Same comment about `require.NoError`
lumtis created a review comment on a pull request on zeta-chain/node
What's the difference between two context? I think we can be more precise in the variable name
lumtis created a review comment on a pull request on zeta-chain/node
Same, I don't think we ever need panics
lumtis created a review comment on a pull request on zeta-chain/node
Some places we use `t.Log` but here logger, any reason?
lumtis created a review comment on a pull request on zeta-chain/node
I don't think we need a directory `tests`, we can directly put `simulation` at the root I think this can also be removed from test coverage
lumtis created a review comment on a pull request on zeta-chain/node
```suggestion ``` ### Import and run simulation test long This test runs the import and run simulation test for a longer duration. It uses the runsim tool to run the same test in parallel thre...
lumtis created a review comment on a pull request on zeta-chain/node
Would be great great to add some empty lines between these paragraphs
lumtis created a review comment on a pull request on zeta-chain/node
```suggestion ### Import Export long test ```
lumtis created a review comment on a pull request on zeta-chain/node
```suggestion This test runs the import export simulation test for a longer duration. It uses the runsim tool to run the same test in parallel threads ```
lumtis created a comment on a pull request on zeta-chain/node
Tested by disabling the mainnet condition (like mainnet is used for E2E tests), this looks good ``` bitcoin | ⏳running - deposit Bitcoin into ZEVM bitcoin | ✅ completed in 6.038452044s - d...
ws4charlie created a review comment on a pull request on zeta-chain/node
Introduced a variable `isStandardMemo` to made the flow clear in the same refactor https://github.com/zeta-chain/node/commit/b2c149c4124f27c83f2ef6f4a55f76f8c3534433
ws4charlie created a review comment on a pull request on zeta-chain/node
simplified in same refactor https://github.com/zeta-chain/node/commit/b2c149c4124f27c83f2ef6f4a55f76f8c3534433
ws4charlie created a review comment on a pull request on zeta-chain/node
in same refactor https://github.com/zeta-chain/node/commit/b2c149c4124f27c83f2ef6f4a55f76f8c3534433
ws4charlie created a review comment on a pull request on zeta-chain/node
This is updated https://github.com/zeta-chain/node/pull/3025/commits/b2c149c4124f27c83f2ef6f4a55f76f8c3534433
ws4charlie created a review comment on a pull request on zeta-chain/node
To make the logic clear, here is the refactor: https://github.com/zeta-chain/node/pull/3025/commits/b2c149c4124f27c83f2ef6f4a55f76f8c3534433
ws4charlie created a review comment on a pull request on zeta-chain/node
I moved as the 1st test in Bitcoin group in commit: https://github.com/zeta-chain/node/pull/3025/commits/b2c149c4124f27c83f2ef6f4a55f76f8c3534433
ws4charlie pushed 1 commit to feat-btc-revert-address zeta-chain/node
- code refactor to make DecodeMemoBytes more redable b2c149c
ws4charlie created a review comment on a pull request on zeta-chain/node
Those variables will be initialized as nil or empty value, and this is done intentionally.
ws4charlie pushed 3 commits to feat-btc-revert-address zeta-chain/node
ws4charlie created a review comment on a pull request on zeta-chain/node
default path added in https://github.com/zeta-chain/node/pull/3025/commits/7a2880bf21e47dfa10d0f3a9dd3756064237afbd