Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
gartnera closed a pull request on zeta-chain/node
chore: always set explicit base compose file
# Description ``` export NODE_COMPOSE_ARGS="-f docker-compose-persistent.yml" make start-e2e-test ``` was broken because we did not provide `-f docker-compose.yml` in `start-e2e-test`. Ens...
github-merge-queue[bot] pushed 1 commit to develop zeta-chain/node
- chore: always set explicit base compose file (#3037) b334267
github-merge-queue[bot] deleted a branch zeta-chain/node
gh-readonly-queue/develop/pr-3037-93ebef490829374170c290c8246a7d3f82cf9dfc
gartnera created a review comment on a pull request on zeta-chain/node
There is no logger here. The error condition is not reachable in this case. I think the least bad thing to do if we want to handle this is to just panic (since it really should never happen)
github-merge-queue[bot] created a branch on zeta-chain/node
gh-readonly-queue/develop/pr-3037-93ebef490829374170c290c8246a7d3f82cf9dfc - ZetaChain’s blockchain node and an observer validator client
ws4charlie created a review comment on a pull request on zeta-chain/node
The edge case: A user serialize below memo (e.g. invalid receiver or revert address) and wrap it into his/her transaction. The memo deserialization will pass without issue. In this case, we shou...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Avoid using `recover` for control flow in tests** Using `recover` to handle expected error conditions can obscure the source of issues and make debugging more diffic...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:hammer_and_wrench: Refactor suggestion_ **Rename struct fields for improved clarity** The fields `A` and `B` in the `StoreKeysPrefixes` struct are not descriptive. Renaming them to more meaning...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Correct the error variable in `require.NoError`** In line 504, `require.NoError(t, err)` is called, but the error from `SimulateFromSeed` is stored in `simErr`. This...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:hammer_and_wrench: Refactor suggestion_ **Refactor test setup to eliminate code duplication** The functions `TestAppImportExport` and `TestAppSimulationAfterImport` contain duplicated setup and...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Add bounds checking for key slicing.** The current implementation assumes the key will always have at least 3 bytes (2 prefix bytes + address). While this might be t...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Security: Protect against shell injection in matrix variables.** Similar to the fix applied in the manual-run job, the matrix variable should be passed through an en...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Fix incorrect test duration description.** The description for the multi seed short test incorrectly states it runs for a longer duration than the long test, which c...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Fix grammatical redundancy.** The word "then" appears twice in succession. ```diff -This state is then then imported into a new simulation. +This state is then impo...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Fix typo in make command.** The make command contains an extra 'g' at the end which would cause it to fail. ```diff -make test-sim-after-import-longg +make test-sim...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Resolve duplicate section headings.** There are two sections titled "Import and run simulation test". Consider renaming the second occurrence to better reflect its l...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:hammer_and_wrench: Refactor suggestion_ **Consider refactoring for better error context and reduced duplication** The function could benefit from: 1. Wrapping errors with additional context 2. ...
coderabbitai[bot] created a review on a pull request on zeta-chain/node
**Actionable comments posted: 11** <details> <summary>🧹 Outside diff range and nitpick comments (3)</summary><blockquote> <details> <summary>tests/simulation/sim/sim_utils.go (1)</summary><blockq...
coderabbitai[bot] created a review on a pull request on zeta-chain/node
**Actionable comments posted: 11** <details> <summary>🧹 Outside diff range and nitpick comments (3)</summary><blockquote> <details> <summary>tests/simulation/sim/sim_utils.go (1)</summary><blockq...
ws4charlie created a review comment on a pull request on zeta-chain/node
It's a good point and it's by intention. Here is the workflow: step-1: call `DecodeMemoBytes` so that we know the `receiver`, `revert address`, `abort address` etc. step-2: call `CheckEventProces...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Avoid using `require.NoError` in deferred cleanup functions** In the deferred function, `require.NoError` is used to check for errors during resource cleanup. Using ...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Ensure proper error handling during cleanup in `TestAppSimulationAfterImport`** Similar to the previous comment, the deferred function in `TestAppSimulationAfterImpo...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Improve error handling in deferred function to avoid masking critical errors** In the deferred function within `TestAppImportExport`, all panics are caught, and the ...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:hammer_and_wrench: Refactor suggestion_ **Consider explicit error handling with logging.** While ignoring commission withdrawal errors is intentional, silently discarding errors makes debugging...