Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Optimize job architecture and prevent command injection.** The current implementation has several issues that need to be addressed: 1. Jobs run on separate VMs, cau...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:hammer_and_wrench: Refactor suggestion_ **Improve error handling with wrapped context.** The error handling could be more descriptive to aid in debugging. ```diff if config.ExportStatePath !=...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Fix typo in make command.** The make command contains an extra 'g' which would cause it to fail. ```diff -make test-sim-after-import-longg +make test-sim-after-impo...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Fix duplicate content and incorrect command.** The "Import and run simulation test" section appears to be incomplete: 1. It uses the same command as the previous sec...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:hammer_and_wrench: Refactor suggestion_ **Apply consistent error handling pattern.** Similar improvement for the params export section. ```diff if config.ExportParamsPath != "" { paramsBz,...
coderabbitai[bot] created a review on a pull request on zeta-chain/node
**Actionable comments posted: 12** <details> <summary>🧹 Outside diff range and nitpick comments (5)</summary><blockquote> <details> <summary>tests/simulation/sim/sim_utils.go (1)</summary><blockq...
coderabbitai[bot] created a review on a pull request on zeta-chain/node
**Actionable comments posted: 12** <details> <summary>🧹 Outside diff range and nitpick comments (5)</summary><blockquote> <details> <summary>tests/simulation/sim/sim_utils.go (1)</summary><blockq...
ws4charlie created a review comment on a pull request on zeta-chain/node
Good catch for improvement. It should be more OOP. I'm going to make `DecodeEventMemoBytes` a method of the event struct self. We'll have to update two fields of the event after decoding: `event....
coderabbitai[bot] created a comment on a pull request on zeta-chain/node
<!-- This is an auto-generated comment: summarize by coderabbit.ai --> <!-- This is an auto-generated comment: skip review by coderabbit.ai --> > [!IMPORTANT] > ## Review skipped > > Draft detect...
kingpinXD created a review comment on a pull request on zeta-chain/node
Consider logging the error , even if we don't need to handle it
gartnera created a review comment on a pull request on zeta-chain/node
we can probably figure out a way to merge this with `run-simulation-tests`. You could have a separate step that generates the matrix.
gartnera created a review comment on a pull request on zeta-chain/node
to make this a required check you need a final step that will aggregate the matrix steps together. See ok in ci.yml or e2e.yml.
gartnera created a review comment on a pull request on zeta-chain/node
jobs run on separate clean VMs so you'd have to merge these
gartnera created a review comment on a pull request on zeta-chain/node
I'd prefer shorter names like `sim.yaml` and `name: sim` which makes the github checks on PRs more easy to read quickly.
coderabbitai[bot] created a comment on a pull request on zeta-chain/node
<!-- This is an auto-generated comment: summarize by coderabbit.ai --> <!-- This is an auto-generated comment: review in progress by coderabbit.ai --> > [!NOTE] > Currently processing new changes ...
kingpinXD pushed 1 commit to sim-import-export zeta-chain/node
- uncomment simulation tests from CI 643490d
ws4charlie created a review comment on a pull request on zeta-chain/node
I have no preference except that the pointer receiver can avoid the copying when the method is called. wdyt
ws4charlie created a review comment on a pull request on zeta-chain/node
We'll have to support both legacy memo and standard memo at some point. Zetaclient has to try deserializing given bytes as a standard memo struct. If serialization fails, zetaclient knows that the ...
swift1337 pushed 1 commit to feat/ton-withdrawals zeta-chain/node
- Update GW (https://github.com/zeta-chain/protocol-contracts-ton/pull/20) a5c9b76
coderabbitai[bot] created a comment on a pull request on zeta-chain/node
<!-- This is an auto-generated comment: summarize by coderabbit.ai --> <!-- This is an auto-generated comment: skip review by coderabbit.ai --> > [!IMPORTANT] > ## Review skipped > > Draft detect...
swift1337 pushed 1 commit to feat/ton-withdrawals zeta-chain/node
- Add addOutboundTracker to *observer*; Add TSS cache for signatures 1041997