Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
lumtis created a review comment on a pull request on zeta-chain/node
```suggestion switch result := event.CheckProcessability(); result { ```
lumtis created a review comment on a pull request on zeta-chain/node
```suggestion func (ob *Observer) NewInboundVoteFromLegacyMemo(event *BTCInboundEvent, amountSats *big.Int) *crosschaintypes.MsgVoteInbound { ```
lumtis created a review comment on a pull request on zeta-chain/node
Should return false if we have an unexpected value, should be covered by test as well
lumtis created a review comment on a pull request on zeta-chain/node
```suggestion func (ob *Observer) CheckEventProcessability(event BTCInboundEvent) bool { ``` Let's stop using pointers when we don't need those
lumtis created a review comment on a pull request on zeta-chain/node
```suggestion // NoAssetCall will be disabled for Bitcoin until full V2 support // https://github.com/zeta-chain/node/issues/2711 ```
lumtis created a review comment on a pull request on zeta-chain/node
Confusing, why not handling the error before
lumtis created a review comment on a pull request on zeta-chain/node
If it is mainnet, we here skip this variable initialization but still goes to the switch reading this variable. This flow should be simplified. If it's mainnet, we should have some logic and ret...
lumtis created a review comment on a pull request on zeta-chain/node
We shouldn't need this call here if we already have this check in `Processability`
lumtis created a review on a pull request on zeta-chain/node
Need some improvements in `event.go`
lumtis created a review on a pull request on zeta-chain/node
Need some improvements in `event.go`
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:hammer_and_wrench: Refactor suggestion_ **Consider explicit error handling for nil message.** While the nil check for `msg.To` is correct, consider adding explicit validation for `msg` itself a...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:bulb: Codebase verification_ **Inconsistency detected in type usage across backend interfaces** There appears to be an inconsistency in the type usage between `backend.go` and its implementatio...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Consider adding error handling for CurrentHeader.** The `CurrentHeader()` call could potentially return nil, which might cause a panic in `CalcBaseFee`. Consider add...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:bulb: Codebase verification_ Based on the findings, I can now provide a final response: **Test coverage exists but needs enhancement for edge cases** The current test suite includes transactio...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:hammer_and_wrench: Refactor suggestion_ **Consider implementing attribute capacity limit.** The `WithAttrs` method continuously appends to the attrs slice without bounds, which could lead to me...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Fix incorrect log level mapping in Handle method.** The warn level logs are being logged as info, which could lead to loss of log severity information. ```diff ...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:hammer_and_wrench: Refactor suggestion_ **Consider adding cleanup for the logger.** The logger setup could benefit from proper cleanup when the server shuts down. ```diff + // Store the ori...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:hammer_and_wrench: Refactor suggestion_ **Enhance WithGroup implementation.** The current implementation ignores group context, which might affect log structuring and readability. ```diff -fun...
coderabbitai[bot] created a review on a pull request on zeta-chain/node
**Actionable comments posted: 8** <details> <summary>🧹 Outside diff range and nitpick comments (12)</summary><blockquote> <details> <summary>contrib/rpcimportable/go.mod (1)</summary><blockquote>...
coderabbitai[bot] created a review on a pull request on zeta-chain/node
**Actionable comments posted: 8** <details> <summary>🧹 Outside diff range and nitpick comments (12)</summary><blockquote> <details> <summary>contrib/rpcimportable/go.mod (1)</summary><blockquote>...
coderabbitai[bot] created a comment on a pull request on zeta-chain/node
<!-- This is an auto-generated comment: summarize by coderabbit.ai --> <!-- This is an auto-generated comment: review in progress by coderabbit.ai --> > [!NOTE] > Currently processing new changes ...
github-actions[bot] published a release on zeta-chain/node
v20.0.5
# CHANGELOG ## v20.0.0 ### Features * [2578](https://github.com/zeta-chain/node/pull/2578) - add Gateway address in protocol contract list * [2630](https://github.com/zeta-chain/node/pull/2630) ...github-actions[bot] created a tag on zeta-chain/node
v20.0.5 - ZetaChain’s blockchain node and an observer validator client
morde08 pushed 1 commit to release/v20 zeta-chain/node
- Revert "stop dht after 5 min (#3032)" (#3034) This reverts commit a43b69ea42bec09c23c49dd6a72926a59b912357. 571b8ae
morde08 closed a pull request on zeta-chain/node
fix: Revert "fix: stop dht after 5min"
Reverts zeta-chain/node#3032 and restores changes to remove DHT completelymorde08 opened a pull request on zeta-chain/node
Revert "fix: stop dht after 5min"
Reverts zeta-chain/node#3032 and restores changes to remove DHT completelymorde08 created a branch on zeta-chain/node
revert-3032-v20-stop-dht-after-5min - ZetaChain’s blockchain node and an observer validator client