Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
ws4charlie opened a draft pull request on zeta-chain/node
fix: SetGatewayAddress might set invalid gateway address
# Description Fixed the issue in method `SetGatewayAddress` and add unit test. # How Has This Been Tested? <!--- Please describe the tests that you ran to verify your changes. Include inst...
ws4charlie created a branch on zeta-chain/node
fix-sol-gateway-address-update - ZetaChain’s blockchain node and an observer validator client
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Replace non-string message in `require.NoError` with a descriptive string** In line 401, passing `revertTx` as the message argument in `require.NoError` may not prov...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:hammer_and_wrench: Refactor suggestion_ **Add explanatory message to `require.True` assertion** Including an error message in the `require.True` assertion on line 402 enhances debuggability by ...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:hammer_and_wrench: Refactor suggestion_ **Consider refactoring test cases to reduce code duplication** The test cases within the `tests` slice contain duplicated code when constructing `BTCInbo...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:hammer_and_wrench: Refactor suggestion_ **Use Consistent Gas Limit Constant in `newDepositAndCallInboundVote`** In the `newDepositAndCallInboundVote` function, the gas limit is hardcoded to `1_...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Ensure Test Coverage for `newCallInboundVote` Function** The usage of `zetacore.PostVoteInboundCallOptionsGasLimit` at line 331 is not currently covered by tests. To...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:hammer_and_wrench: Refactor suggestion_ **Enhance Error Message in `ObserveInbound`** Consider including the transaction hash or additional context in the error message when wrapping the error ...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Ensure Consistency in Logger Method Names** The method name in the logger fields does not match the actual function name. Update `logs.FieldMethod` to reflect the co...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Review Logic for Overriding `Sender` with `RevertAddress`** In `Test_NewInboundVoteMemoStd`, the `Sender` field in the expected vote is set to `revertOptions.RevertA...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:hammer_and_wrench: Refactor suggestion_ **Eliminate Code Duplication in `Test_CheckEventProcessability`** The test loop in `Test_CheckEventProcessability` (lines 299-305) follows a similar stru...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:hammer_and_wrench: Refactor suggestion_ **Abstract Repetitive Test Logic in `Test_DecodeEventMemoBytes`** Similar to previous tests, the loop over test cases in `Test_DecodeEventMemoBytes` (lin...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:hammer_and_wrench: Refactor suggestion_ **Refactor Test Loop for Reusability in `Test_CheckProcessability`** The test execution loop in `Test_CheckProcessability` (lines 112-118) can be refacto...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Maintain Consistent Chain Parameters in `Test_NewInboundVoteMemoStd`** Within `Test_NewInboundVoteMemoStd`, the observer uses `chains.BitcoinMainnet` (line 351), but...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Align Chain Parameters in `Test_NewInboundVoteV1`** In `Test_NewInboundVoteV1`, the observer is set up with `chains.BitcoinMainnet` (line 309), but the test event is...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Ensure Consistent Chain Parameters in `Test_CheckEventProcessability`** In `Test_CheckEventProcessability`, the observer is initialized with `chains.BitcoinTestnet` ...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Safeguard Against Index Out of Range Errors** The condition `len(tx.OutboundParams) == 2` followed by accessing `tx.OutboundParams[1]` assumes that `OutboundParams` ...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Add unit tests for the `OP_PUSHDATA1` case in `DecodeOpReturnMemo`.** The code handling the `memoSize == txscript.OP_PUSHDATA1` condition is essential for parsing sc...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Avoid Potential Slice Access Errors** Even after checking the length, directly accessing `cctxs[0]` could lead to issues if the slice is empty due to unforeseen circ...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Handle Multiple or Missing CCTX Entries Gracefully** The assertion `require.Len(t, cctxs, 1)` enforces that exactly one CCTX is found. In scenarios where multiple CC...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Add nil check for `event.MemoStd` in `NewInboundVoteMemoStd`** The function `NewInboundVoteMemoStd` accesses `event.MemoStd` without verifying if it's non-nil. If `e...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Handle unexpected `InboundProcessability` values in `CheckEventProcessability`** The `switch` statement on `result` does not include a `default` case. If `CheckProce...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Review the error handling when decoding the standard memo** In the switch case where `memoStd != nil`, the code checks `if err != nil` and returns an error. It is un...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Undefined function `parseFloat`: Use `strconv.ParseFloat` for amount parsing** The function `parseFloat` is not defined or imported. To parse the amount from the arg...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Handle potential errors from `DepositBTCWithAmount`** The function `DepositBTCWithAmount` may return an error that should be checked to ensure the test behaves corre...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Typo in variable name `amoutSats`: Correct to `amountSats`** There is a typo in the variable name `amoutSats`. It should be corrected to `amountSats` for accuracy an...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Add missing changelog entries for E2E tests and receiver address fix.** The PR introduces several changes that should be documented in the changelog: 1. Implementati...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:hammer_and_wrench: Refactor suggestion_ **Consider varying default BTC amounts for better test coverage.** Currently, all new Bitcoin standard memo tests use 0.1 BTC as the default amount. Cons...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:hammer_and_wrench: Refactor suggestion_ **Consider adding more validation failure scenarios.** The test case effectively covers the empty receiver address scenario. Consider expanding it to inc...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:hammer_and_wrench: Refactor suggestion_ **Consider adding RevertOptions validation.** While the `WithRevertOptions` function is well-implemented, the `ValidateBasic()` method doesn't validate t...