Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:hammer_and_wrench: Refactor suggestion_ **Consider varying default BTC amounts for better test coverage.** Currently, all new Bitcoin standard memo tests use 0.1 BTC as the default amount. Cons...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:hammer_and_wrench: Refactor suggestion_ **Consider adding more validation failure scenarios.** The test case effectively covers the empty receiver address scenario. Consider expanding it to inc...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:hammer_and_wrench: Refactor suggestion_ **Consider adding RevertOptions validation.** While the `WithRevertOptions` function is well-implemented, the `ValidateBasic()` method doesn't validate t...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:hammer_and_wrench: Refactor suggestion_ **Consider wrapping validation error with context.** While the validation logic is sound, error context would help with debugging. ```diff // validate ...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:hammer_and_wrench: Refactor suggestion_ **Consider explicit error handling for better clarity.** The current implementation might lead to ambiguous nil memo returns. Consider making the success...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Add input validation for deposit amount.** The `parseFloat` call lacks bounds checking for the deposit amount. Consider adding validation to ensure: - The amount is ...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Implement more flexible balance verification.** The current exact balance match doesn't account for potential transaction fees or dust amounts. Consider implementing...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:hammer_and_wrench: Refactor suggestion_ **Refactor balance checking logic to reduce duplication.** The balance checking logic is duplicated. Consider extracting it into a helper function for re...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:hammer_and_wrench: Refactor suggestion_ **Enhance test assertions.** Consider adding more comprehensive validations: - Verify the payload in outbound parameters matches the input - Add assertio...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:hammer_and_wrench: Refactor suggestion_ **Avoid hardcoding test addresses.** Consider moving the revert address to a test constants file or generating it dynamically using the sample package, s...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Enhance memo construction and validation.** The memo construction needs better documentation and validation: 1. The memo format and size constraints should be docume...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:hammer_and_wrench: Refactor suggestion_ **Consider using constants and more explicit test data.** The memo configuration uses magic numbers and could benefit from: 1. Constants for version and ...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Enhance test assertions and error handling.** The assertions section needs improvements: 1. Document or make constant the outbound params index 2. Add timeout to pre...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Enhance test robustness and logging.** The test verification could be improved with: 1. Timeout for waiting on revert completion 2. More precise amount verification ...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Replace hard-coded sleep with polling mechanism.** Using a fixed sleep duration can make tests flaky. Consider implementing a polling mechanism with timeout. ```dif...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Verify specific error condition.** The test should verify that the specific expected error occurs, not just any error. ```diff _, err = r.CctxClient.InTxHashToCctx...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Enhance input validation for donation amount.** The current validation only checks the number of arguments. Consider adding checks for: - Non-negative amounts - Maxi...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:hammer_and_wrench: Refactor suggestion_ **Enhance documentation and add input validation** While the function implementation is correct, consider these improvements: 1. Expand the documentation...
coderabbitai[bot] created a review on a pull request on zeta-chain/node
**Actionable comments posted: 43** <details> <summary>🧹 Outside diff range and nitpick comments (40)</summary><blockquote> <details> <summary>pkg/memo/fields.go (1)</summary><blockquote> Line ra...
coderabbitai[bot] created a review on a pull request on zeta-chain/node
**Actionable comments posted: 43** <details> <summary>🧹 Outside diff range and nitpick comments (40)</summary><blockquote> <details> <summary>pkg/memo/fields.go (1)</summary><blockquote> Line ra...
swift1337 pushed 2 commits to feat/ton-withdrawals zeta-chain/node
coderabbitai[bot] created a comment on a pull request on zeta-chain/node
<!-- This is an auto-generated comment: summarize by coderabbit.ai --> <!-- This is an auto-generated comment: review in progress by coderabbit.ai --> > [!NOTE] > Currently processing new changes ...
github-actions[bot] created a comment on a pull request on zeta-chain/node
<!-- add-pr-comment:add-pr-comment --> *!!!WARNING!!!* `nosec` detected in the following files: tests/simulation/sim/sim_state.go Be very careful about using `#nosec` in code. It can be a quick w...
codecov[bot] created a comment on a pull request on zeta-chain/node
## [Codecov](https://app.codecov.io/gh/zeta-chain/node/pull/3025?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zeta-chai...
ws4charlie pushed 5 commits to feat-btc-revert-address zeta-chain/node
- feat: erc20 auth calls (#3012) * bump protocol contracts to use erc20 auth calls * bump protocol contracts and fix ... 9347165
- fix: support `depositAndCall` and `withdrawAndCall` with empty message (#3018) * add no message tests * add is cros... 41ec117
- docs(rfc): non-evm chain memo design standard (#2963) * upload non-evm chain memo design doc * add changelog entry ... 3aa68fe
- test: add simulation tests (#2947) * debug sim test * start modifuing for v50 * add sim test v1 * add sim export ... 0f8a4c2
- Merge branch 'develop' of https://github.com/zeta-chain/node into feat-btc-revert-address 3647b9d
ws4charlie pushed 1 commit to feat-btc-revert-address zeta-chain/node
- disable standard memo for Bitcoin mainnet 7a537bb
kingpinXD pushed 2 commits to sim-import-export zeta-chain/node
kingpinXD created a branch on zeta-chain/node
sim-import-export - ZetaChain’s blockchain node and an observer validator client
codecov[bot] created a comment on a pull request on zeta-chain/node
## [Codecov](https://app.codecov.io/gh/zeta-chain/node/pull/3029?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=zeta-chai...