Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
ws4charlie pushed 1 commit to feat-btc-revert-address zeta-chain/node
- add e2e tests for bitcoin standard memo deposit cb30c66
kingpinXD pushed 1 commit to feat/staking-distribute-function zeta-chain/node
- fix should return empty array if validators not set unit test 5592432
fbac created a review comment on a pull request on zeta-chain/node
Markdown version formatted by a linter and some minor corrections: ----BEGIN # Zetachain simulation testing ## Overview The blockchain simulation tests how the blockchain application would ...
fbac created a review comment on a pull request on zeta-chain/node
```suggestion * [2894](https://github.com/zeta-chain/node/pull/2894) - increase gas limit for TSS vote tx * [2947](https://github.com/zeta-chain/node/pull/2947) - initialize simulation tests ```
fbac created a review comment on a pull request on zeta-chain/node
```suggestion # Configuration parameters for simulation tests ```
fbac created a review on a pull request on zeta-chain/node
LGTM, left some minor changes regarding formatting in a couple markdowns.
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Prevent `lastScannedLowest` from being set to zero on observation errors** If `ObserveGatewayDepositAndCall` returns an error, `lastScannedGatewayDepositAndCall` may...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Include tests for `GetNoMessageIndex` function** The function `GetNoMessageIndex` is a new addition but is not covered by existing tests. Incorporate unit tests to v...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Add unit tests for the new function `NOMESSAGECALL`** The newly introduced function `NOMESSAGECALL` lacks unit test coverage. To maintain reliability and prevent fut...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Validate `lastScannedGatewayDepositAndCall` before updating `lastScannedLowest`** Ensure that `lastScannedGatewayDepositAndCall` is greater than zero before comparin...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Prevent duplication by appending events after validation.** Currently, `iterator.Event` is appended to the `events` slice before validation and again after a success...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:hammer_and_wrench: Refactor suggestion_ **Simplify the initialization of `isCrossChainCall`.** You can directly assign the boolean expression to `isCrossChainCall` for a more concise implementa...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:hammer_and_wrench: Refactor suggestion_ **Refactor to eliminate code duplication in event observation functions.** The newly added functions `ObserveGatewayDepositAndCall`, `parseAndValidateDep...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Issue: Incorrect function name in error message** The error message in `ParseGatewayEvent` references `ParseGatewayCallEvent`, which may lead to confusion during deb...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Issue: Missing unit tests for `ParseGatewayWithdrawAndCallEvent`** The function `ParseGatewayWithdrawAndCallEvent` is untested. Given its role in parsing combined wi...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Issue: Insufficient test coverage for inbound message constructors** The functions `NewWithdrawalInbound`, `NewCallInbound`, and `NewWithdrawAndCallInbound` are not ...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Issue: Potential backward compatibility concern** The conditional setting of `isCrossChainCall` based on `event.Message` length may affect backward compatibility wit...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Issue: Missing unit tests for `ParseGatewayWithdrawalEvent`** The function `ParseGatewayWithdrawalEvent` is responsible for parsing withdrawal events but is not cove...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Issue: Missing unit tests for `ParseGatewayCallEvent`** The `ParseGatewayCallEvent` function parses call events but lacks test coverage. Ensuring its reliability is ...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Issue: Missing unit tests for `ParseGatewayEvent`** The `ParseGatewayEvent` function is crucial for parsing different gateway events but lacks unit test coverage. Wi...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Avoid Unsafe Conversion from `bytes` to `string`** In the `onCall` function, `message` of type `bytes` is converted to a `string`: ```solidity string memory message...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:hammer_and_wrench: Refactor suggestion_ **Refactor Suggestion: Consolidate common logic in inbound creation functions** The functions `NewWithdrawalInbound`, `NewCallInbound`, and `NewWithdrawA...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Issue: Redundant check for empty message** In `NewWithdrawalInbound`, the `isCrossChainCall` flag is set based on whether the `event.Message` is non-empty. However, ...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Issue: Inconsistent function names in error messages** In the functions `NewWithdrawalInbound`, `NewCallInbound`, and `NewWithdrawAndCallInbound`, the error messages...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:hammer_and_wrench: Refactor suggestion_ **Inconsistent Key Usage in Mappings** In the `onCall` function, the `senderWithMessage` mapping uses `bytes(messageStr)` as the key, whereas other mappi...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Consistent and Safe Handling of `message` Data** Similar to the issue above, in the `onCall` function for connected EVM chains, `message` is converted from `bytes` t...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Properly Convert Address to String Representation** The `getNoMessageIndex` function attempts to concatenate `NO_MESSAGE_CALL` with the `sender` address by encoding ...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Handle errors from `ParseGatewayEvent` properly** Currently, if `types.ParseGatewayEvent` returns an error (`err != nil`), the function silently continues without ha...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Add unit tests for critical code paths** The logic added in lines 61-75 involves fetching the receiver chain and querying the gas limit, which are critical for the c...