Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Properly Convert Address to String Representation** The `getNoMessageIndex` function attempts to concatenate `NO_MESSAGE_CALL` with the `sender` address by encoding ...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Handle errors from `ParseGatewayEvent` properly** Currently, if `types.ParseGatewayEvent` returns an error (`err != nil`), the function silently continues without ha...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Add unit tests for critical code paths** The logic added in lines 61-75 involves fetching the receiver chain and querying the gas limit, which are critical for the c...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:hammer_and_wrench: Refactor suggestion_ **Refactor duplicated code in inbound message creation** The code for creating inbound messages for `withdrawalEvent`, `callEvent`, and `withdrawalAndCal...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Potential overlap in cross-chain call handling** The condition `else if isCrossChainCall` may include cases already covered by `coinType == coin.CoinType_NoAssetCall...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:hammer_and_wrench: Refactor suggestion_ **Consider refactoring to eliminate boolean flag parameters** Passing a boolean parameter like `isCrossChainCall` can make the function `ProcessV2Deposit...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Add error handling for cctx retrieval** Currently, there is no error handling for the retrieval of `cctx` using `utils.WaitCctxMinedByInboundHash`. If this function ...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Specify non-zero `OnRevertGasLimit` for reliability** Setting `OnRevertGasLimit` to zero may lead to transaction failures if a revert occurs during the cross-chain o...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Ensure correct conversion of `messageIndex` to byte slice** The expression `[]byte(messageIndex)` may not correctly convert `messageIndex` to a byte slice if `messag...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:hammer_and_wrench: Refactor suggestion_ **Verify the necessity of approving both ERC20 and ETH tokens** In this test for ERC20 withdrawal, approving both ERC20 (`r.ApproveERC20ZRC20`) and ETH (...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:hammer_and_wrench: Refactor suggestion_ **Avoid modifying global authentication parameters** Directly modifying `r.ZEVMAuth.GasLimit` affects the global state and may lead to unintended side ef...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Potential type conversion issue with `messageIndex`** In line 50, the code converts `messageIndex` to a byte slice using `[]byte(messageIndex)`. If `messageIndex` is...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Check for errors when waiting for cctx to be mined** The function `utils.WaitCctxMinedByInboundHash` may return an error if the context fails to be mined within the ...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Ensure `AssertTestDAppZEVMCalled` handles potential errors** The function `r.AssertTestDAppZEVMCalled` is called without checking for any potential errors it might g...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:hammer_and_wrench: Refactor suggestion_ **Simplify big integer conversion and error checking** Currently, the code uses `SetString` to convert the string argument to a `*big.Int`, and then chec...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Add error handling for `ApproveERC20OnEVM` to ensure robustness** The call to `r.ApproveERC20OnEVM(r.GatewayEVMAddr)` does not handle any potential errors returned b...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:hammer_and_wrench: Refactor suggestion_ **Validate the length of `args` with clear error messaging** While `require.Len(r, args, 1)` checks that `args` has exactly one element, providing a cust...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Handle errors returned by `V2ERC20DepositAndCall`** The function `r.V2ERC20DepositAndCall` may return an error along with the transaction object. Currently, the erro...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:bulb: Codebase verification_ **Incomplete updates to `ZRC20DepositAndCallContract` implementations.** The `isCrossChainCall` parameter has been added to the `FungibleKeeper` interface, but sev...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:bulb: Codebase verification_ **Missing `isCrossChainCall` parameter in function calls to `ZRC20DepositAndCallContract`** Several function calls to `ZRC20DepositAndCallContract` in test files a...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Enhance test coverage and implement missing test case for NewWithdrawAndCallInbound.** The current test case for `NewWithdrawAndCallInbound` is well-structured and c...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Implement or remove the empty test function.** The `TestParseGatewayWithdrawAndCallEvent` function is currently empty. Please implement the test case to validate the...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Implement or remove the empty test function.** The `TestParseGatewayCallEvent` function is currently empty. Please implement the test case to validate the `ParseGate...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Implement or remove the empty test function.** The `TestParseGatewayWithdrawalEvent` function is currently empty. Please implement the test case to validate the `Par...
coderabbitai[bot] created a review comment on a pull request on zeta-chain/node
_:warning: Potential issue_ **Implement or remove the empty test function.** The `TestParseGatewayEvent` function is currently empty. Please implement the test case to validate the `ParseGatewayE...
coderabbitai[bot] created a review on a pull request on zeta-chain/node
**Actionable comments posted: 46** <details> <summary>🧹 Outside diff range and nitpick comments (56)</summary><blockquote> <details> <summary>docs/openapi/openapi.swagger.yaml (1)</summary><block...
coderabbitai[bot] created a review on a pull request on zeta-chain/node
**Actionable comments posted: 46** <details> <summary>🧹 Outside diff range and nitpick comments (56)</summary><blockquote> <details> <summary>docs/openapi/openapi.swagger.yaml (1)</summary><block...
coderabbitai[bot] created a comment on a pull request on zeta-chain/node
<!-- This is an auto-generated comment: summarize by coderabbit.ai --> <!-- This is an auto-generated comment: review in progress by coderabbit.ai --> > [!NOTE] > Currently processing new changes ...
