Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
nbradbury pushed 12 commits to trunk wordpress-mobile/WordPress-Android
- First pass at converting Jetpack migration to Material3 8c1a5e3
- Second pass at converting Jetpack migration to Material3 d3dd9b0
- Added TitleM3, SubtitleM3, and MessageM3 a28d098
- Added site list item preview e203972
- Handle empty site list icon 585c40b
- Handle empty site list icon, P2 5480de1
- Tweaked title line height 0a2940e
- Use correct M3 buttons for welcome step 0c855f7
- Merge branch 'trunk' into issue/21317-jp-migration-m3 973047f
- Removed unused imports a5acde5
- Merge branch 'trunk' into issue/21317-jp-migration-m3 eff1ecf
- Merge pull request #21318 from wordpress-mobile/issue/21317-jp-migration-m3 Convert Jetpack Migration to Material3 368f83e
nbradbury closed a pull request on wordpress-mobile/WordPress-Android
Convert Jetpack Migration to Material3
This PR converts the Jetpack migration flow to Material3. This is not an easy flow to test so I recommend relying on previewing the various "step" screens under `org.wordpress.android.ui.main.jetpa...
sonarcloud[bot] created a comment on a pull request on wordpress-mobile/WordPress-Android
## [](https://sonarcloud.io/dashboard?id=...
wzieba created a review comment on a pull request on wordpress-mobile/WordPress-Android
š [c79408b](https://github.com/wordpress-mobile/WordPress-Android/pull/21261/commits/c79408bb3eba2e877a201c06d5083b079b687e8f)
wzieba created a review comment on a pull request on wordpress-mobile/WordPress-Android
š e78fceba4ff1d4b1219acad04efb642b1e737205
wzieba pushed 1 commit to fluxc_adjust_to_build wordpress-mobile/WordPress-Android
- Reorder libs.versions.toml to match alphabetical order e78fceb
wzieba created a review comment on a pull request on wordpress-mobile/WordPress-Android
> Minor (š): Consider moving this under the CORRECTNESS group. š [2e078a6](https://github.com/wordpress-mobile/WordPress-Android/pull/21261/commits/2e078a6dd25860b87818ca0dd8e9683e3a5aa658) >...
wzieba created a comment on a pull request on wordpress-mobile/WordPress-Android
Thanks @ParaskP7 for the review! I'll minimize suggested changes to include only these which are about code added by this PR and don't touch vendored (or copy-pasted) code to keep things with minim...
sonarcloud[bot] created a comment on a pull request on wordpress-mobile/WordPress-Android
## [](https://sonarcloud.io/dashboard?id=...
wzieba pushed 2 commits to fluxc_adjust_to_build wordpress-mobile/WordPress-Android
dcalhoun created a review on a pull request on wordpress-mobile/WordPress-Android
Changes look sound and the previews rendered as expected. Thank you for adding the helpful previews! šš»āāļø
ParaskP7 created a review on a pull request on wordpress-mobile/WordPress-Android
Approving this too ([context](https://github.com/wordpress-mobile/WordPress-Android/pull/21261#pullrequestreview-2384925007))! š ā¤ļø š
ParaskP7 created a review on a pull request on wordpress-mobile/WordPress-Android
Approving this too ([context](https://github.com/wordpress-mobile/WordPress-Android/pull/21261#pullrequestreview-2384925007))! š ā¤ļø š
ParaskP7 created a review comment on a pull request on wordpress-mobile/WordPress-Android
Suggestion (š”): Since the `kotlin` version is now aligned (a13f97ee87ae671366300ed7ff5183cf68bbfd08), consider replacing `sharedLibs` with `libs` for everything `plugins.kotlin`, at least on the `p...
ParaskP7 created a review comment on a pull request on wordpress-mobile/WordPress-Android
Minor (š): I noticed an extra space on all the other `$TEST_COLLECTOR` steps, maybe this extra space could be removing from everywhere. š
ParaskP7 created a review comment on a pull request on wordpress-mobile/WordPress-Android
Minor (š): For consistency purposes, this could be renamed to a capital `Test` instead, just to match the rest of them. PS: Same applies to `Unit test Login` below.
ParaskP7 created a review comment on a pull request on wordpress-mobile/WordPress-Android
Suggestion (š”): Consider removing everything but these 4 `wp` related properties from this example `gradle.properties` file. ```properties # Optional: used to autofill username and password fie...
ParaskP7 created a review on a pull request on wordpress-mobile/WordPress-Android
š @wzieba ! I have reviewed and (quickly) tested this PR as per the instructions, everything works as expected, an amazing job well done, kudos! š x š ^ š ----- I have left few suggestion...
ParaskP7 created a review on a pull request on wordpress-mobile/WordPress-Android
š @wzieba ! I have reviewed and (quickly) tested this PR as per the instructions, everything works as expected, an amazing job well done, kudos! š x š ^ š ----- I have left few suggestion...
Agoni-0 created a comment on an issue on wordpress-mobile/WordPress-Android
Iād like to have a try on this issue.
sonarcloud[bot] created a comment on a pull request on wordpress-mobile/WordPress-Android
## [](https://sonarcloud.io/dashboard?id=...
dcalhoun created a branch on wordpress-mobile/WordPress-Android
feat/authenticate-private-resource-requests - WordPress for Android
wzieba created a review comment on a pull request on wordpress-mobile/WordPress-Android
I agree with everything you said here, good points š Adjusted in 952ebd7f2703e49f2e6a9daedeeece0d0a3a1051
wzieba pushed 1 commit to fluxc_adjust_to_build wordpress-mobile/WordPress-Android
- Revert not treating warnings as errors in the project Disable warningsAsErrors in `fluxc` only. It was not enabled i... 952ebd7