Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:warning: Potential issue_ **Ensure function comments are complete sentences with proper grammar and punctuation.** The function comments should start with the function name and be complete sent...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:warning: Potential issue_ **Potential nil pointer dereference in 'mapKeyRequest' function** When mapping `keyRequest.Creator` to `ethCreator`, there is no check to ensure `keyRequest.Creator` i...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:warning: Potential issue_ **Correct error message to match response type in 'keysOutput.FromResponse'** The error message mentions `QueryKeyResponse` instead of `QueryKeysResponse`, which might...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:warning: Potential issue_ **Undefined type 'TypesPageResponse' in 'keysOutput' struct** The `keysOutput` struct uses `TypesPageResponse` for `PageResponse`, but this type is not defined. This w...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:warning: Potential issue_ **Improve error message in 'FromResponse' method** In `KeyRequest.FromResponse`, when `res` or `res.KeyRequest` is nil, the error message only mentions a nil response....
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:warning: Potential issue_ **Improve error message in 'Space.FromResponse' method** When checking for nil in `Space.FromResponse`, the error message only mentions `QuerySpaceByIdResponse`. Inclu...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:warning: Potential issue_ **Undefined type 'TypesPageResponse' in 'keyRequestsOutput' struct** The `keyRequestsOutput` struct references an undefined type `TypesPageResponse` for `Pagination`, ...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:warning: Potential issue_ **Clarify error message in 'FromResponse' method** In `SignRequest.FromResponse`, the error message could be more descriptive by specifying whether `res` or `res.SignR...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:warning: Potential issue_ **Undefined type 'TypesPageRequest' in 'allKeysInput' struct** The type `TypesPageRequest` used for `PageRequest` is not defined, which will cause a compilation error....
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:hammer_and_wrench: Refactor suggestion_ **Refactor Functions with Excessive Parameters** The functions `FulfilKeyRequestMethod` and `FulfilSignRequestMethod` have more than five parameters, whi...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:hammer_and_wrench: Refactor suggestion_ **Enhance Error Context by Wrapping Errors** Throughout the code, errors are returned directly without additional context. To improve debuggability and a...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:warning: Potential issue_ **Ensure consistent parameter passing in request constructors** In methods like `SignRequestByIdMethod` and `SpaceByIdMethod`, the request constructor functions `newSi...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:warning: Potential issue_ **Capitalize acronyms consistently in comments** The acronym "ABI" should be capitalized in comments and code to follow Go naming conventions for acronyms, as per the ...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:hammer_and_wrench: Refactor suggestion_ **Avoid using generic package imports like 'common'** Importing packages with generic names like `common` can lead to confusion and potential naming conf...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:warning: Potential issue_ **Replace usage of deprecated `XXX_Merge` with proper protobuf unmarshalling** The `XXX_Merge` method is an internal protobuf function and should be avoided. Use `prot...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:hammer_and_wrench: Refactor suggestion_ **Avoid unnecessary use of `reflect.ValueOf` in `cmn.PackNum`** The `reflect.ValueOf` wrapper may not be necessary if `cmn.PackNum` accepts basic types d...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:hammer_and_wrench: Refactor suggestion_ **Refactor duplicated code in event handling methods to adhere to DRY principle** The `GetCreateTemplateEvent`, `GetUpdateTemplateEvent`, `GetCreateActio...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:hammer_and_wrench: Refactor suggestion_ **Include context in error when converting participant address.** In `mapVote`, wrap the error with additional context to provide clarity on which partic...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:hammer_and_wrench: Refactor suggestion_ **Simplify `FromResponse` methods by returning only an error.** Since the methods modify the receiver and the updated value is accessible to the caller, ...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:hammer_and_wrench: Refactor suggestion_ **Add context to error when converting creator address.** Similarly, when converting the creator's address, the error should include contextual informati...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:hammer_and_wrench: Refactor suggestion_ **Wrap errors with context when converting mention addresses.** In `mapAction`, errors returned from `AddressFromBech32Str` lack contextual information. ...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:warning: Potential issue_ **Add missing ABI tags in `TemplatesInput` struct.** The `TemplatesInput` struct lacks ABI tags for its fields, which may cause issues during serialization and deseria...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:hammer_and_wrench: Refactor suggestion_ **Group imports according to Go conventions.** The import statements should be grouped into standard library packages, third-party packages, and local pa...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:hammer_and_wrench: Refactor suggestion_ **Use field names in struct literals for `TypesAnyType`.** For better readability and to prevent errors if the struct definition changes, it's recommende...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:hammer_and_wrench: Refactor suggestion_ **Consider using `time.Unix` for timestamp mapping.** Instead of manually converting time to seconds and nanoseconds, you can use `time.Unix` to get a `t...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:hammer_and_wrench: Refactor suggestion_ **Index `actionId` in the `ActionVoted` event for efficient event filtering.** Adding the `indexed` keyword to the `actionId` parameter in the `ActionVot...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:hammer_and_wrench: Refactor suggestion_ **Index `actionId` in the `ActionStateChange` event to enhance event filtering.** Indexing `actionId` in this event will improve the ability to monitor a...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:warning: Potential issue_ **Mark `checkAction` as `view` since it does not modify state.** The `checkAction` function appears to only read data without modifying the contract's state. Marking i...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:hammer_and_wrench: Refactor suggestion_ **Index `actionId` in the `CreateAction` event for better traceability.** Indexing `actionId` enhances the ability to search and filter events, aiding in...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:warning: Potential issue_ **Avoid using `msg` as a variable name to prevent confusion with global `msg` object.** Using `msg` as a variable name may cause confusion with Solidity's global `msg`...