Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:hammer_and_wrench: Refactor suggestion_ **Index `templateId` in the `UpdateTemplate` event for consistent querying.** Adding `indexed` to `templateId` allows for streamlined filtering of templa...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:hammer_and_wrench: Refactor suggestion_ **Index `templateId` in the `CreateTemplate` event to facilitate event queries.** By indexing `templateId`, you enable more efficient querying of templat...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:hammer_and_wrench: Refactor suggestion_ **Use Correct Capitalization for Initialisms in Struct Field Names** According to the [Uber Go Style Guide](https://github.com/uber-go/guide/blob/master/...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:warning: Potential issue_ **Correct the error message to match the variable name.** The error message in `newMsgAddKeychainWriter` refers to `newAdminAddress`, but the variable is `newWriterAdd...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:warning: Potential issue_ **Validate `Status` field before converting to enum** In `newKeyRequestsRequest`, `input.Status` is directly cast to `types.KeyRequestStatus` without validation. This ...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:warning: Potential issue_ **Handle potential nil `KeybaseId.Value` to prevent nil pointer dereference** In `mapKeychain`, when `keychain.KeybaseId` is not nil, you assign `keybaseId = keychain....
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:warning: Potential issue_ **Validate `Status` field before converting to enum** In `newSignRequestsRequest`, `input.Status` is directly cast to `types.SignRequestStatus` without checking if it'...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:hammer_and_wrench: Refactor suggestion_ **Use 'ID' instead of 'Id' in identifier names** Consistent capitalization of initialisms improves code clarity. Rename `templateId` to `templateID` as p...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:hammer_and_wrench: Refactor suggestion_ **Use 'ID' instead of 'Id' in identifier names** To follow the initialism capitalization rules, change `actionId` to `actionID`. Apply this diff: ```...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:hammer_and_wrench: Refactor suggestion_ **Update function comments to start with the function name** Per the Go conventions and the [Uber Go Style Guide](https://github.com/uber-go/guide/blob/m...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:hammer_and_wrench: Refactor suggestion_ **Use 'ID' instead of 'Id' in identifier names** In line with the Uber Go Style Guide, please rename `actionId` to `actionID` to maintain consistency wit...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:hammer_and_wrench: Refactor suggestion_ **Update function comments to start with the function name** Ensure that comments for exported functions begin with the function name to adhere to Go doc...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:hammer_and_wrench: Refactor suggestion_ **Use 'ID' instead of 'Id' in identifier names** According to the [Uber Go Style Guide](https://github.com/uber-go/guide/blob/master/style.md#initialisms...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:hammer_and_wrench: Refactor suggestion_ **Update function comments to start with the function name** Starting comments with the function name improves consistency and aids documentation generat...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:hammer_and_wrench: Refactor suggestion_ **Update function comments to start with the function name** As per the Go conventions, function comments should start with the name of the function. Thi...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:hammer_and_wrench: Refactor suggestion_ **Update function comments to start with the function name** Comments for exported functions should begin with the function's name as per Go conventions ...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:warning: Potential issue_ **Validate 'voteType' value to ensure it's within expected range** While you ensure `voteType` is of type `uint8`, there is no check to confirm that it matches valid `...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:warning: Potential issue_ **Handle potential Unicode issues in string arguments** When working with strings that may contain Unicode characters, it's important to ensure they are handled correc...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:warning: Potential issue_ **Avoid using `panic`; return an error instead** Using `panic` for standard error handling is discouraged in Go, as it can lead to unexpected crashes. Instead, conside...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:hammer_and_wrench: Refactor suggestion_ **Consider refactoring the large switch-case in `Run` method** The `Run` method has a large switch-case statement that could be simplified or refactored ...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:warning: Potential issue_ **Return `ActionStatus` enum instead of `string` in `checkAction`.** The `checkAction` function returns a `string`, which might lead to inconsistencies or errors due t...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:hammer_and_wrench: Refactor suggestion_ **Ensure consistent parameter naming in events for clarity.** The events `CreateTemplate`, `UpdateTemplate`, `CreateAction`, and `ActionStateChange` use ...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:hammer_and_wrench: Refactor suggestion_ **Use `ActionStatus` enum instead of `int32` for the `status` parameter.** In the function `actionsByAddress`, the `status` parameter is currently of typ...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:hammer_and_wrench: Refactor suggestion_ **Group imports according to Go conventions** The imports are not properly grouped. According to the Go conventions and the [Uber Go Style Guide](https:/...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:warning: Potential issue_ **Avoid panicking; handle unknown methods gracefully** Panicking when an unknown method is encountered can lead to undesirable behavior. It's recommended to return an ...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:hammer_and_wrench: Refactor suggestion_ **Enhance error handling in ActionsByAddressQuery and its helper** Consider improving error handling in both the main function and its helper to provide ...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:hammer_and_wrench: Refactor suggestion_ **Enhance error handling in TemplatesQuery and its helper** Consider improving error handling in both the main function and its helper to provide more sp...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:hammer_and_wrench: Refactor suggestion_ **Enhance error handling in TemplateByIdQuery and its helper** Consider improving error handling in both the main function and its helper to provide more...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:hammer_and_wrench: Refactor suggestion_ **Enhance error handling in newActionsQuery** Consider adding more specific error handling when unpacking args to the ActionsInput struct. This will prov...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:warning: Potential issue_ **Use `%w` to wrap errors for better error unwrapping** When wrapping errors with `fmt.Errorf`, use `%w` instead of `%s` to allow error unwrapping, as recommended in G...