Ecosyste.ms: Timeline

Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.

warden-protocol/wardenprotocol

coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:hammer_and_wrench: Refactor suggestion_ **Consider alternatives to `init()` for test registration** The use of `init()` functions is generally discouraged as it can lead to unexpected behavior ...

View on GitHub

coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:hammer_and_wrench: Refactor suggestion_ **Reorganize imports and remove unused ones** The import statements should be reorganized to follow Go style conventions: 1. Standard library packages 2....

View on GitHub

coderabbitai[bot] created a review on a pull request on warden-protocol/wardenprotocol
**Actionable comments posted: 20** <details> <summary>🧹 Outside diff range and nitpick comments (4)</summary><blockquote> <details> <summary>precompiles/act/abi.json (1)</summary><blockquote> `3...

View on GitHub

coderabbitai[bot] created a review on a pull request on warden-protocol/wardenprotocol
**Actionable comments posted: 20** <details> <summary>🧹 Outside diff range and nitpick comments (4)</summary><blockquote> <details> <summary>precompiles/act/abi.json (1)</summary><blockquote> `3...

View on GitHub

backsapc pushed 3 commits to feature/precompile-x/822-act warden-protocol/wardenprotocol
  • Renamed ActPrecompile test 75ba7c5
  • Cleanup warden precompile tests 4fd623d
  • Additions and fixes to act precompile 3648d8d

View on GitHub

jlehtimaki created a review on a pull request on warden-protocol/wardenprotocol

View on GitHub

coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:hammer_and_wrench: Refactor suggestion_ **Avoid stuttering in type names** The type name `IActActionStateChange` includes redundant prefixes that lead to stuttering. Since the type is defined w...

View on GitHub

coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:hammer_and_wrench: Refactor suggestion_ **Avoid using `init` functions** According to the [Uber Go Style Guide](https://github.com/uber-go/guide/blob/master/style.md#package-initialization), `i...

View on GitHub

coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:hammer_and_wrench: Refactor suggestion_ **Replace `time.Sleep` with `require.Eventually`** Avoid using fixed delays in tests. `require.Eventually` provides a better approach to wait for conditi...

View on GitHub

coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:hammer_and_wrench: Refactor suggestion_ **Replace `time.Sleep` with `require.Eventually`** The use of `time.Sleep` can make tests slower and less reliable. Consider using `require.Eventually` t...

View on GitHub

coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:hammer_and_wrench: Refactor suggestion_ **Replace `time.Sleep` with `require.Eventually`** Using `time.Sleep` in tests can lead to flaky tests and unnecessary delays. Instead, use `require.Even...

View on GitHub

coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:warning: Potential issue_ **Rename 'TypeUrl' field to 'TypeURL' in AnyType struct.** To adhere to Go naming conventions for acronyms, the `TypeUrl` field in the `AnyType` struct should be renam...

View on GitHub

coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:warning: Potential issue_ **Use a pointer receiver for FromResponse method.** The `FromResponse` method modifies the `ActionByIdResponse` struct, so it should use a pointer receiver for better ...

View on GitHub

coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:warning: Potential issue_ **Use a pointer receiver for FromResponse method.** The `FromResponse` method modifies the `ActionsByAddressResponse` struct, so it should use a pointer receiver for b...

View on GitHub

coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:warning: Potential issue_ **Use a pointer receiver for FromResponse method.** The `FromResponse` method modifies the `ActionsResponse` struct, so it should use a pointer receiver for better per...

View on GitHub

coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:warning: Potential issue_ **Use pointer receivers and rename 'Id' field to 'ID'.** 1. The `FromResponse` methods for `TemplatesResponse` and `TemplateByIdResponse` should use pointer receivers ...

View on GitHub

coderabbitai[bot] created a review on a pull request on warden-protocol/wardenprotocol
**Actionable comments posted: 12** <details> <summary>🧹 Outside diff range and nitpick comments (4)</summary><blockquote> <details> <summary>precompiles/common/address.go (2)</summary><blockquote...

View on GitHub

coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:warning: Potential issue_ **Rename 'Id' field to 'ID' to follow Go naming conventions.** In the `Action` struct, the `Id` field should be renamed to `ID` to comply with Go naming conventions fo...

View on GitHub

coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:hammer_and_wrench: Refactor suggestion_ **Enhance function robustness and documentation** While the function is concise, consider implementing the following improvements: 1. Add error handling...

View on GitHub

coderabbitai[bot] created a review on a pull request on warden-protocol/wardenprotocol
**Actionable comments posted: 12** <details> <summary>🧹 Outside diff range and nitpick comments (4)</summary><blockquote> <details> <summary>precompiles/common/address.go (2)</summary><blockquote...

View on GitHub

backsapc pushed 1 commit to feature/precompile-x/822-act warden-protocol/wardenprotocol
  • Migration to common.Address b5f345c

View on GitHub

coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:warning: Potential issue_ **Remove Redundant Import of `v1beta3` Package** The package `"github.com/warden-protocol/wardenprotocol/warden/x/warden/types/v1beta3"` is imported twice, once withou...

View on GitHub

coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:warning: Potential issue_ **Group Imports According to Go Conventions** The import statements are not grouped according to Go conventions. Imports should be organized into three sections separa...

View on GitHub

coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:hammer_and_wrench: Refactor suggestion_ **Expand test coverage for space management** The test case "work with space" creates a new space and performs basic validations. However, it mentions th...

View on GitHub

coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:warning: Potential issue_ **Handle potential errors when starting the Warden node** Currently, the Warden node is started in a separate goroutine without capturing any errors that might occur d...

View on GitHub

coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:warning: Potential issue_ **Avoid hardcoding sensitive information** In lines 56 and 182, the `keychainKeybaseId` is assigned values that resemble actual API keys or sensitive identifiers. Even...

View on GitHub

coderabbitai[bot] created a review on a pull request on warden-protocol/wardenprotocol
**Actionable comments posted: 5** <details> <summary>🧹 Outside diff range and nitpick comments (2)</summary><blockquote> <details> <summary>tests/cases/warden_precompile.go (2)</summary><blockquo...

View on GitHub

coderabbitai[bot] created a review on a pull request on warden-protocol/wardenprotocol
**Actionable comments posted: 5** <details> <summary>🧹 Outside diff range and nitpick comments (2)</summary><blockquote> <details> <summary>tests/cases/warden_precompile.go (2)</summary><blockquo...

View on GitHub

mn13 pushed 3 commits to feature/precompile-x/822-act warden-protocol/wardenprotocol
  • warden precompile events WIP db15ce7
  • warden precompile events fixes 7397575
  • complete warden precompile events tests fdc00e1

View on GitHub

coderabbitai[bot] created a review on a pull request on warden-protocol/wardenprotocol
**Actionable comments posted: 0** <details> <summary>🧹 Outside diff range and nitpick comments (2)</summary><blockquote> <details> <summary>warden/x/warden/keeper/query_all_keys_test.go (1)</summ...

View on GitHub

Load more