Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:bulb: Codebase verification_ **Inconsistent usage of pointers for `types.Key` detected** The analysis reveals that some functions in the `warden/x/warden/keeper` package use `types.Key` by val...
coderabbitai[bot] created a review on a pull request on warden-protocol/wardenprotocol
**Actionable comments posted: 1** <details> <summary>🧹 Outside diff range and nitpick comments (4)</summary><blockquote> <details> <summary>warden/x/warden/keeper/msg_server_update_key.go (1)</su...
coderabbitai[bot] created a review on a pull request on warden-protocol/wardenprotocol
**Actionable comments posted: 1** <details> <summary>🧹 Outside diff range and nitpick comments (4)</summary><blockquote> <details> <summary>warden/x/warden/keeper/msg_server_update_key.go (1)</su...
mn13 pushed 1 commit to fix/new-key-event-id warden-protocol/wardenprotocol
- fix linter errors ecb81ca
coderabbitai[bot] created a comment on a pull request on warden-protocol/wardenprotocol
<!-- This is an auto-generated comment: summarize by coderabbit.ai --> <!-- This is an auto-generated comment: review in progress by coderabbit.ai --> > [!NOTE] > Currently processing new changes ...
mn13 created a branch on warden-protocol/wardenprotocol
fix/new-key-event-id - Monorepo for the Warden Protocol.
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:warning: Potential issue_ **Incorrect Address Serialization** Appending 12 zero bytes to an Ethereum address for serialization may not correctly format the address. Ethereum addresses should be...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:warning: Potential issue_ **Typo in Parameter Name: Correct `writerAddres` to `writerAddress`** The parameter `writerAddres` in the `GetAddKeychainWriterEvent` function is misspelled. It should...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:warning: Potential issue_ **Redundant Address Conversion** The `removedOwner` parameter is already provided as a `*common.Address`, but the code converts the `typedEvent.GetRemovedOwner()` from...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:warning: Potential issue_ **Missing Import Alias for `v1beta3` Package** The `v1beta3` package is used without being imported with this alias. This may lead to a compilation error due to an und...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:warning: Potential issue_ **Use of Deprecated Method `XXX_Merge`** The method `XXX_Merge` is used to parse the SDK event into `typedEvent`. Methods prefixed with `XXX_` are deprecated and inten...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:warning: Potential issue_ **Avoid Variable Shadowing and Handle Errors Properly** Within the anonymous function passed to `precommon.ParseSdkEvent`, the variable `b` is redeclared, which shadow...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:warning: Potential issue_ **Correct the Error Message for Clarity** In the `GetNewKeyRequestEvent` function, the error message for the key type parsing has a repetitive word: `"invalid key type...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:hammer_and_wrench: Refactor suggestion_ **Error Handling Simplification** The pattern for writing event data is repeated across multiple functions. Consider creating a helper function to reduce...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:hammer_and_wrench: Refactor suggestion_ **Use `KeyType` enum instead of `int32` for key type fields** In the structs `Key` and `KeyRequest`, the fields `Type` and `KeyType` are currently define...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:warning: Potential issue_ **Correct grammatical errors in documentation comments** Several documentation comments have grammatical errors involving missing articles or incorrect verb forms. For...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:hammer_and_wrench: Refactor suggestion_ **Consider adding error handling and documentation** While the current implementation is concise, it could benefit from two improvements: 1. Error Handl...
coderabbitai[bot] created a review on a pull request on warden-protocol/wardenprotocol
**Actionable comments posted: 11** <details> <summary>🧹 Outside diff range and nitpick comments (10)</summary><blockquote> <details> <summary>precompiles/common/address.go (1)</summary><blockquot...
coderabbitai[bot] created a review on a pull request on warden-protocol/wardenprotocol
**Actionable comments posted: 11** <details> <summary>🧹 Outside diff range and nitpick comments (10)</summary><blockquote> <details> <summary>precompiles/common/address.go (1)</summary><blockquot...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:warning: Potential issue_ **Correct the Error Message for Clarity** In the `GetNewKeyRequestEvent` function, the error message for the `"key_type"` case reads `"invalid key type type"`, which i...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:warning: Potential issue_ **Avoid Variable Shadowing and Handle Errors Properly** In the anonymous function passed to `precommon.ParseSdkEvent`, the variable `b` is redeclared, which shadows th...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:warning: Potential issue_ **Ensure Proper Serialization of the `creator` Address** When writing the `creator` address to the buffer, using `b.Write([]byte(val))` may not serialize the address c...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:warning: Potential issue_ **Ensure Proper Serialization of the `new_owner` Address** In the `GetAddSpaceOwnerEvent` function, the `new_owner` attribute is written using `b.Write([]byte(val))`, ...
coderabbitai[bot] created a review on a pull request on warden-protocol/wardenprotocol
**Actionable comments posted: 4** <details> <summary>📜 Review details</summary> **Configuration used: .coderabbit.yaml** **Review profile: CHILL** <details> <summary>📥 Commits</summary> Files t...
coderabbitai[bot] created a review on a pull request on warden-protocol/wardenprotocol
**Actionable comments posted: 4** <details> <summary>📜 Review details</summary> **Configuration used: .coderabbit.yaml** **Review profile: CHILL** <details> <summary>📥 Commits</summary> Files t...
mn13 pushed 1 commit to feature/precompile-x/822-act warden-protocol/wardenprotocol
- warden precompile: parse sdk events WIP 5f9f853
coderabbitai[bot] created a review on a pull request on warden-protocol/wardenprotocol
**Actionable comments posted: 0** <details> <summary>🧹 Outside diff range and nitpick comments (2)</summary><blockquote> <details> <summary>.github/workflows/scan-fs.yaml (2)</summary><blockquote...
coderabbitai[bot] created a comment on a pull request on warden-protocol/wardenprotocol
<!-- This is an auto-generated comment: summarize by coderabbit.ai --> <!-- This is an auto-generated comment: review in progress by coderabbit.ai --> > [!NOTE] > Currently processing new changes ...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:warning: Potential issue_ **Fix typo in method name: `WaitRunnning` should be `WaitRunning`** There's a typo in the method name `WaitRunnning`. It should be corrected to `WaitRunning` to match ...