Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:hammer_and_wrench: Refactor suggestion_ **Reorganize import statements for better readability** The import statements should be grouped and ordered according to the Go style conventions: standa...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:hammer_and_wrench: Refactor suggestion_ **Replace `time.Sleep` with `require.Eventually` for more reliable tests** The use of `time.Sleep` throughout the test can lead to flaky tests and unnece...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:hammer_and_wrench: Refactor suggestion_ **Consider alternatives to `init()` for test registration** The use of `init()` functions is generally discouraged as it can lead to unexpected behavior ...
coderabbitai[bot] created a review on a pull request on warden-protocol/wardenprotocol
**Actionable comments posted: 5** <details> <summary>📜 Review details</summary> **Configuration used: .coderabbit.yaml** **Review profile: CHILL** <details> <summary>📥 Commits</summary> Files t...
coderabbitai[bot] created a review on a pull request on warden-protocol/wardenprotocol
**Actionable comments posted: 5** <details> <summary>📜 Review details</summary> **Configuration used: .coderabbit.yaml** **Review profile: CHILL** <details> <summary>📥 Commits</summary> Files t...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:hammer_and_wrench: Refactor suggestion_ **Extend the previous refactoring to include Action events.** The `GetCreateActionEvent`, `parseCreateActionEvent`, `GetActionVotedEvent`, and `parseActi...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:hammer_and_wrench: Refactor suggestion_ **Consider refactoring to reduce code duplication.** The `GetUpdateTemplateEvent` and `parseUpdateTemplateEvent` functions are nearly identical to their ...
coderabbitai[bot] created a review on a pull request on warden-protocol/wardenprotocol
**Actionable comments posted: 2** <details> <summary>🧹 Outside diff range and nitpick comments (1)</summary><blockquote> <details> <summary>precompiles/act/events.go (1)</summary><blockquote> `1...
coderabbitai[bot] created a review on a pull request on warden-protocol/wardenprotocol
**Actionable comments posted: 2** <details> <summary>🧹 Outside diff range and nitpick comments (1)</summary><blockquote> <details> <summary>precompiles/act/events.go (1)</summary><blockquote> `1...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
@Pitasi, glad you agree! (\_/) (^‿^) (")_(") <!-- This is an auto-generated reply by CodeRabbit -->
backsapc pushed 1 commit to feature/precompile-x/822-act warden-protocol/wardenprotocol
- Migrated events to new method e60ccf1
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:hammer_and_wrench: Refactor suggestion_ **Consider using `uint256` for timestamps instead of custom `Timestamp` struct** The `Timestamp` struct uses separate `uint64` fields for seconds and nan...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:warning: Potential issue_ **Rename `Test_EthTransactionReader` to conform to Go naming conventions** Per the Uber Go Style Guide, type names should use CamelCase without underscores. Consider r...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:warning: Potential issue_ **Assign transaction to `tx` variable before checking success** The result of `alice.Tx(...)` is not assigned to `tx`, but `tx` is used in `checks.SuccessTx(t, tx)`. T...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:hammer_and_wrench: Refactor suggestion_ **Extend the previous refactoring to include Action events.** The `GetCreateActionEvent` and `parseCreateActionEvent` functions follow the same pattern a...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:warning: Potential issue_ **Fix typo in method name `WaitRunnning`** The method `WaitRunnning` appears to have a typo with an extra 'n'. It should be `WaitRunning`. Apply this diff to correc...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:hammer_and_wrench: Refactor suggestion_ **Update method receivers after renaming the type** Following the renaming of the type, ensure that all method receivers are updated accordingly to match...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:hammer_and_wrench: Refactor suggestion_ **Ensure function parameters are consistently named** In the function `newTemplate`, the parameter `definition` might be better named `expression` to mai...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:hammer_and_wrench: Refactor suggestion_ **Encapsulate constants within a library or contract for better organization** Defining constants at the file level is permissible, but encapsulating the...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:warning: Potential issue_ **Consistently use `err` for error variables** The variable `err2` is used instead of `err`, which can be confusing. To maintain consistency, consider restructuring th...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:warning: Potential issue_ **Remove commented-out code for a cleaner codebase** Commented-out code can clutter the codebase and make it harder to maintain. If this code is no longer needed, cons...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:warning: Potential issue_ **Reorganize import statements to follow Go style conventions** According to the Uber Go Style Guide, imports should be grouped in the following order, separated by bl...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:warning: Potential issue_ **Consistently use `err` for error variables** Similar to the previous comment, `err2` is used here. For consistency and readability, please use `err` or restructure t...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:warning: Potential issue_ **Parameter order: place `context.Context` as the first parameter** According to the Uber Go Style Guide, the `context.Context` parameter should be the first parameter...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:warning: Potential issue_ **Fix typo in method name: `WaitRunnning` should be `WaitRunning`** There's a typo in the method name `WaitRunnning`. It should be corrected to `WaitRunning` to match ...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:warning: Potential issue_ **Remove commented-out code for a cleaner codebase** Leaving commented-out code can clutter the codebase and make maintenance more difficult. If `dave` is not needed, ...
coderabbitai[bot] created a review comment on a pull request on warden-protocol/wardenprotocol
_:warning: Potential issue_ **Replace `time.Sleep` with `require.Eventually` for reliable asynchronous testing** Using `time.Sleep` introduces arbitrary delays and can make tests flaky or slower ...